From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 429235960 for ; Tue, 29 Sep 2015 16:48:52 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 29 Sep 2015 07:48:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,608,1437462000"; d="scan'208";a="779947508" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 29 Sep 2015 07:48:34 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.38]) by irsmsx105.ger.corp.intel.com ([169.254.7.235]) with mapi id 14.03.0248.002; Tue, 29 Sep 2015 15:48:33 +0100 From: "Chilikin, Andrey" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 1/3] librte_ether: add RTE_ETH_FDIR_OTHER for flow director behavior Thread-Index: AQHQ+sLuIXShgrQSyEatQ/X6mFAI/J5TgrKAgAARqhA= Date: Tue, 29 Sep 2015 14:48:32 +0000 Message-ID: References: <1443536800-13269-1-git-send-email-andrey.chilikin@intel.com> <1443536800-13269-2-git-send-email-andrey.chilikin@intel.com> <20150929143823.GE6748@bricha3-MOBL3> In-Reply-To: <20150929143823.GE6748@bricha3-MOBL3> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] librte_ether: add RTE_ETH_FDIR_OTHER for flow director behavior X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 14:48:52 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Tuesday, September 29, 2015 3:38 PM > To: Chilikin, Andrey > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] librte_ether: add RTE_ETH_FDIR_OTHER > for flow director behavior >=20 > On Tue, Sep 29, 2015 at 03:26:38PM +0100, Andrey Chilikin wrote: > > Add new flow director behavior RTE_ETH_FDIR_OTHER to assign a queue by > > other filters > > > > Signed-off-by: Andrey Chilikin > > --- > > lib/librte_ether/rte_eth_ctrl.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/lib/librte_ether/rte_eth_ctrl.h > > b/lib/librte_ether/rte_eth_ctrl.h index 26b7b33..3acf501 100644 > > --- a/lib/librte_ether/rte_eth_ctrl.h > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > @@ -417,6 +417,7 @@ struct rte_eth_fdir_input { enum > > rte_eth_fdir_behavior { > > RTE_ETH_FDIR_ACCEPT =3D 0, > > RTE_ETH_FDIR_REJECT, > > + RTE_ETH_FDIR_OTHER, > > }; > > > > /** > > -- > > 1.7.4.1 > > > Is "OTHER" meant to be a "NOOP" or a generic hold-all for a set of other > possible behaviours. From the description, I would assume NOOP - in which > case would RTE_ETH_FDIR_NOOP not be a better name? >=20 > /Bruce "NOOP" sounds like no operation at all, but FD still performs matching and = extracts flexible payload to the RX descriptor, it only skips queue assignm= ent which is done by other filters with lower priority. Maybe RTE_ETH_FDIR_= PASSTHRU? Regards, Andrey