From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B854A0521; Tue, 3 Nov 2020 15:00:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E20D1CA74; Tue, 3 Nov 2020 15:00:22 +0100 (CET) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 1159BCA6E for ; Tue, 3 Nov 2020 15:00:20 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id p4so1270376plr.1 for ; Tue, 03 Nov 2020 06:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=6IBFHXC9NzF0N4TbyrGqbZuCn1INYsENzWsKYXyKMbg=; b=pWw37FDwD6tKTgD01IBgvmFL5GASSCUdVx9Fus1Uvu6qHabh4EHCeDMyl4jyQAX87S L91aCTIlFN2eUFX/69TbdhvNBHUiJxY3ASfxFaTTIK9TISZ9bBFMAiAQbLOMZDDgU6Kj B1nSsepLzHuKhykAEH5iHZFa+ypD9aiKGe0HxzLtcxpy8kmJ+2z5g9gf5Y08W5cyMB8m aMMSmm62ZqeukT9jnRbu29mvkNdVQePtvW8hfnvzRrJmGxsv5rf7sltLUVxzEC5Y73UC yeamiWE+KStTMfINAJ+2RrryBmO53idhdq6PYBI08T71dzR++y5xBlH5dSFhFKx8UPzw XdIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=6IBFHXC9NzF0N4TbyrGqbZuCn1INYsENzWsKYXyKMbg=; b=XGKnEaJHPjx6hZC/5tlF8s3tpAiYwrmIC/FdGnAiP0zaKo91f0BTqPYEEAP4YMBmIl MqmuBqhfGRo+XOvmsQYkZUmsDeKxTYG0IpiAG0Dp0sFh90UAM1x6kdRVmAF5EVLefAHk T5v4LfggL3S2TyJG8HlvCnaCIAODwwzL8JwGNofxn4ZIPDnhMF7EebZpjrAgs+IkjfQ9 a9mpuBd+naWFVYKJvBmEqt5B6EhRovR+rR2u2gLTLsWBB0tk4Iikc9pHbScfg+aCed3a 2R+Qg/5kcDqOplpuC8JYCe8kOrlYAUHTKqm7WZXNGmFETGIfD+UFRKIHTeByErh3oi56 sylw== X-Gm-Message-State: AOAM530WK9aZThwArrB2YH59YEMMkeq9qT85JqT0w0m7/dNY4dlCn/ke rHOYUPJwcwSoIlK5qADeJ+Lq3g== X-Google-Smtp-Source: ABdhPJyU7TXvpP2dXrNEST+huwPTRiqUrOOfDX5DGUJ20Hhps0nb8w0UhTn2w6SGd07Z7JRFVS655Q== X-Received: by 2002:a17:902:788f:b029:d6:4c68:f652 with SMTP id q15-20020a170902788fb02900d64c68f652mr26262063pll.1.1604412016817; Tue, 03 Nov 2020 06:00:16 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:ec73:c9e1:ffcb:ec27? ([2600:1700:6b0:fde0:ec73:c9e1:ffcb:ec27]) by smtp.gmail.com with ESMTPSA id z3sm17345047pfk.159.2020.11.03.06.00.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2020 06:00:16 -0800 (PST) From: Andrew Boyer Message-Id: Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Date: Tue, 3 Nov 2020 09:00:11 -0500 In-Reply-To: Cc: dev@dpdk.org, cardigliano@ntop.org To: Ferruh Yigit References: <20201102183527.69209-1-aboyer@pensando.io> <20201102183527.69209-9-aboyer@pensando.io> X-Mailer: Apple Mail (2.3608.120.23.2.4) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 8/8] ionic: nits - whitespace, logging, helper variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Nov 3, 2020, at 8:06 AM, Ferruh Yigit = wrote: >=20 > On 11/2/2020 6:35 PM, Andrew Boyer wrote: >> These are minor cleanups which did not deserve their own patches. >> Signed-off-by: Andrew Boyer >> --- >> drivers/net/ionic/ionic_ethdev.c | 10 ++++------ >> drivers/net/ionic/ionic_lif.c | 22 ++++++++++----------- >> drivers/net/ionic/ionic_main.c | 4 +--- >> drivers/net/ionic/ionic_rxtx.c | 33 = ++++++++++++++------------------ >> 4 files changed, 29 insertions(+), 40 deletions(-) >> ... >=20 > As far as I can see this patchset has, > 1- minor fixes > 2- some code refactoring > 3- Whitespace updates >=20 > Would you mind whitespace changes for now, and separate patch for 1 & = 2? Please clarify - looks like there=E2=80=99s a word missing? -Andrew=