Re: [dpdk-dev] [RFC] mlx5: flow counters support on the linux-rdma v19 base

[Yongseok Koh <yskoh@mellanox.com>]

> On Aug 20, 2018, at 6:34 AM, viacheslavo <viacheslavo@mellanox.com> wrote:
> 
> Mellanox mlx5 PMD supports Flow Counters via Verbs library.
> The current implementation is based on the Mellanox proprietary
> Verbs library included in MLNX OFED packages. The Flow Counter
> support is recently added into linux-rdma release (v19),
> so the mlx5 PMD update is needed to provide Counter feature
> on the base of linux-rdma.
> 
> mlx5 PMD can be compiled with MLNX OFED or linux-rdma v19
> and provide flow counters for both.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/Makefile    | 10 +++++++
> drivers/net/mlx5/mlx5.c      |  6 ++++
> drivers/net/mlx5/mlx5_flow.c | 67 ++++++++++++++++++++++++++++++++++++--------
> drivers/net/mlx5/mlx5_glue.c | 41 +++++++++++++++++++++++++++
> drivers/net/mlx5/mlx5_glue.h | 16 +++++++++++
> 5 files changed, 128 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> index 2e70dec..ca4c143 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -155,6 +155,16 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto-config-h.sh
> 		type 'struct ibv_counter_set_init_attr' \
> 		$(AUTOCONF_OUTPUT)
> 	$Q sh -- '$<' '$@' \
> +		HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT \
> +		infiniband/verbs.h \
> +		type 'struct ibv_counters_init_attr' \
> +		$(AUTOCONF_OUTPUT)
> +	$Q sh -- '$<' '$@' \
> +		HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45 \
> +		infiniband/verbs.h \
> +		type 'struct ibv_counters_init_attr' \
> +		$(AUTOCONF_OUTPUT)
> +	$Q sh -- '$<' '$@' \

I don't see any difference between the two -
HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT and HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45??

Thanks
Yongseok

> 		HAVE_RDMA_NL_NLDEV \
> 		rdma/rdma_netlink.h \
> 		enum RDMA_NL_NLDEV \
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index ec63bc6..ad289f0 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -730,8 +730,10 @@
> 	unsigned int mprq_min_stride_num_n = 0;
> 	unsigned int mprq_max_stride_num_n = 0;
> #ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> 	struct ibv_counter_set_description cs_desc = { .counter_type = 0 };
> #endif
> +#endif
> 	struct ether_addr mac;
> 	char name[RTE_ETH_NAME_MAX_LEN];
> 	int own_domain_id = 0;
> @@ -1001,11 +1003,15 @@
> 	DRV_LOG(DEBUG, "checksum offloading is %ssupported",
> 		(config.hw_csum ? "" : "not "));
> #ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> 	config.flow_counter_en = !!attr.max_counter_sets;
> 	mlx5_glue->describe_counter_set(ctx, 0, &cs_desc);
> 	DRV_LOG(DEBUG, "counter type = %d, num of cs = %ld, attributes = %d",
> 		cs_desc.counter_type, cs_desc.num_of_cs,
> 		cs_desc.attributes);
> +#else
> +	config.flow_counter_en = 1;
> +#endif
> #endif
> 	config.ind_table_max_size =
> 		attr.rss_caps.max_rwq_indirection_table_size;
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index ca4625b..4d762dd 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -290,7 +290,11 @@ struct mlx5_flow_counter {
> 	uint32_t shared:1; /**< Share counter ID with other flow rules. */
> 	uint32_t ref_cnt:31; /**< Reference counter. */
> 	uint32_t id; /**< Counter ID. */
> -	struct ibv_counter_set *cs; /**< Holds the counters for the rule. */
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> +struct ibv_counters *cs; /**< Holds the counters for the rule. */
> +#else
> +struct ibv_counter_set *cs; /**< Holds the counters for the rule. */
> +#endif
> 	uint64_t hits; /**< Number of packets matched by the rule. */
> 	uint64_t bytes; /**< Number of bytes matched by the rule. */
> };
> @@ -519,27 +523,32 @@ struct mlx5_flow_tunnel_info {
> static struct mlx5_flow_counter *
> mlx5_flow_counter_new(struct rte_eth_dev *dev, uint32_t shared, uint32_t id)
> {
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> 	struct priv *priv = dev->data->dev_private;
> 	struct mlx5_flow_counter *cnt;
> 
> -	LIST_FOREACH(cnt, &priv->flow_counters, next) {
> -		if (!cnt->shared || cnt->shared != shared)
> -			continue;
> -		if (cnt->id != id)
> -			continue;
> -		cnt->ref_cnt++;
> -		return cnt;
> +	if (shared) {
> +		LIST_FOREACH(cnt, &priv->flow_counters, next)
> +		if (cnt->shared && cnt->id == id) {
> +			cnt->ref_cnt++;
> +			return cnt;
> +		}
> 	}
> -#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> 
> 	struct mlx5_flow_counter tmpl = {
> 		.shared = shared,
> 		.id = id,
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> +		.cs = mlx5_glue->create_counter_set
> +			(priv->ctx,
> +			 &(struct ibv_counters_init_attr){0}),
> +#else
> 		.cs = mlx5_glue->create_counter_set
> 			(priv->ctx,
> 			 &(struct ibv_counter_set_init_attr){
> 				 .counter_set_id = id,
> 			 }),
> +#endif
> 		.hits = 0,
> 		.bytes = 0,
> 	};
> @@ -548,17 +557,40 @@ struct mlx5_flow_tunnel_info {
> 		rte_errno = errno;
> 		return NULL;
> 	}
> +
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> +	struct ibv_counter_attach_attr attach_attr = {0};
> +	int ret;
> +
> +	attach_attr.counter_desc = IBV_COUNTER_PACKETS;
> +	attach_attr.index = 0;
> +	ret = ibv_attach_counters_point_flow(tmpl.cs, &attach_attr, NULL);
> +	if (!ret) {
> +		attach_attr.counter_desc = IBV_COUNTER_BYTES;
> +		attach_attr.index = 1;
> +		ret = ibv_attach_counters_point_flow(tmpl.cs,
> +						     &attach_attr,
> +						     NULL);
> +	}
> +	if (ret) {
> +		claim_zero(mlx5_glue->destroy_counter_set(tmpl.cs));
> +		rte_errno = ret;
> +		return NULL;
> +	}
> +#endif
> 	cnt = rte_calloc(__func__, 1, sizeof(*cnt), 0);
> 	if (!cnt) {
> +		claim_zero(mlx5_glue->destroy_counter_set(tmpl.cs));
> 		rte_errno = ENOMEM;
> 		return NULL;
> 	}
> 	*cnt = tmpl;
> 	LIST_INSERT_HEAD(&priv->flow_counters, cnt, next);
> 	return cnt;
> -#endif
> +#else
> 	rte_errno = ENOTSUP;
> 	return NULL;
> +#endif
> }
> 
> /**
> @@ -2307,7 +2339,7 @@ struct mlx5_flow_tunnel_info {
> 		flow->counter = mlx5_flow_counter_new(dev, count->shared,
> 						      count->id);
> 		if (!flow->counter)
> -			return rte_flow_error_set(error, ENOTSUP,
> +			return rte_flow_error_set(error, rte_errno,
> 						  RTE_FLOW_ERROR_TYPE_ACTION,
> 						  action,
> 						  "cannot get counter"
> @@ -2320,7 +2352,11 @@ struct mlx5_flow_tunnel_info {
> 					  "flow counters are not supported.");
> 	flow->modifier |= MLX5_FLOW_MOD_COUNT;
> #ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> +	counter.counters = flow->counter->cs;
> +#else
> 	counter.counter_set_handle = flow->counter->cs->handle;
> +#endif
> 	if (size <= flow_size)
> 		mlx5_flow_spec_verbs_add(flow, &counter, size);
> 	return size;
> @@ -3373,6 +3409,13 @@ struct rte_flow *
> 	if (flow->modifier & MLX5_FLOW_MOD_COUNT) {
> 		struct rte_flow_query_count *qc = data;
> 		uint64_t counters[2] = {0, 0};
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> +		int err = mlx5_glue->query_counter_set(
> +				flow->counter->cs,
> +				counters,
> +				RTE_DIM(counters),
> +				IBV_READ_COUNTERS_ATTR_PREFER_CACHED);
> +#else
> 		struct ibv_query_counter_set_attr query_cs_attr = {
> 			.cs = flow->counter->cs,
> 			.query_flags = IBV_COUNTER_SET_FORCE_UPDATE,
> @@ -3383,7 +3426,7 @@ struct rte_flow *
> 		};
> 		int err = mlx5_glue->query_counter_set(&query_cs_attr,
> 						       &query_out);
> -
> +#endif
> 		if (err)
> 			return rte_flow_error_set
> 				(error, err,
> diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/mlx5/mlx5_glue.c
> index 84f9492..b2b39ad 100644
> --- a/drivers/net/mlx5/mlx5_glue.c
> +++ b/drivers/net/mlx5/mlx5_glue.c
> @@ -211,6 +211,39 @@
> 	return ibv_dereg_mr(mr);
> }
> 
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> +static struct ibv_counters *
> +mlx5_glue_create_counters(struct ibv_context *context,
> +			  struct ibv_counters_init_attr *init_attr)
> +{
> +	return ibv_create_counters(context, init_attr);
> +}
> +
> +static int
> +mlx5_glue_destroy_counters(struct ibv_counters *counters)
> +{
> +	return ibv_destroy_counters(counters);
> +}
> +
> +static int
> +mlx5_glue_attach_counters(struct ibv_counters *counters,
> +		     struct ibv_counter_attach_attr *attr,
> +		     struct ibv_flow *flow)
> +{
> +	return ibv_attach_counters_point_flow(counters, attr, flow);
> +}
> +
> +static int
> +mlx5_glue_query_counters(struct ibv_counters *counters,
> +			 uint64_t *counters_value,
> +			 uint32_t ncounters,
> +			 uint32_t flags)
> +{
> +	return ibv_read_counters(counters, counters_value, ncounters, flags);
> +}
> +#endif
> +
> +#ifndef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> static struct ibv_counter_set *
> mlx5_glue_create_counter_set(struct ibv_context *context,
> 			     struct ibv_counter_set_init_attr *init_attr)
> @@ -262,6 +295,7 @@
> 	return ibv_query_counter_set(query_attr, cs_data);
> #endif
> }
> +#endif
> 
> static void
> mlx5_glue_ack_async_event(struct ibv_async_event *event)
> @@ -378,10 +412,17 @@
> 	.modify_qp = mlx5_glue_modify_qp,
> 	.reg_mr = mlx5_glue_reg_mr,
> 	.dereg_mr = mlx5_glue_dereg_mr,
> +#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> +	.create_counter_set = mlx5_glue_create_counters,
> +	.destroy_counter_set = mlx5_glue_destroy_counters,
> +	.attach_counter_set = mlx5_glue_attach_counters,
> +	.query_counter_set = mlx5_glue_query_counters,
> +#else
> 	.create_counter_set = mlx5_glue_create_counter_set,
> 	.destroy_counter_set = mlx5_glue_destroy_counter_set,
> 	.describe_counter_set = mlx5_glue_describe_counter_set,
> 	.query_counter_set = mlx5_glue_query_counter_set,
> +#endif
> 	.ack_async_event = mlx5_glue_ack_async_event,
> 	.get_async_event = mlx5_glue_get_async_event,
> 	.port_state_str = mlx5_glue_port_state_str,
> diff --git a/drivers/net/mlx5/mlx5_glue.h b/drivers/net/mlx5/mlx5_glue.h
> index e584d36..c5ff3cb 100644
> --- a/drivers/net/mlx5/mlx5_glue.h
> +++ b/drivers/net/mlx5/mlx5_glue.h
> @@ -89,6 +89,21 @@ struct mlx5_glue {
> 	struct ibv_mr *(*reg_mr)(struct ibv_pd *pd, void *addr,
> 				 size_t length, int access);
> 	int (*dereg_mr)(struct ibv_mr *mr);
> +#ifdef	HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT_V45
> +	struct ibv_counters *(*create_counter_set)
> +		(struct ibv_context *context,
> +		 struct ibv_counters_init_attr *init_attr);
> +	int (*destroy_counter_set)(struct ibv_counters *cs);
> +	int (*attach_counter_set)
> +		(struct ibv_counters *cs,
> +		 struct ibv_counter_attach_attr *attr,
> +		 struct ibv_flow *flow);
> +	int (*query_counter_set)
> +		(struct ibv_counters *cs,
> +		 uint64_t *counters_value,
> +		 uint32_t ncounters,
> +		 uint32_t flags);
> +#else
> 	struct ibv_counter_set *(*create_counter_set)
> 		(struct ibv_context *context,
> 		 struct ibv_counter_set_init_attr *init_attr);
> @@ -99,6 +114,7 @@ struct mlx5_glue {
> 		 struct ibv_counter_set_description *cs_desc);
> 	int (*query_counter_set)(struct ibv_query_counter_set_attr *query_attr,
> 				 struct ibv_counter_set_data *cs_data);
> +#endif
> 	void (*ack_async_event)(struct ibv_async_event *event);
> 	int (*get_async_event)(struct ibv_context *context,
> 			       struct ibv_async_event *event);
> -- 
> 1.8.3.1
>