From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.arccn.ru (vpn.arccn.ru [95.182.74.2]) by dpdk.org (Postfix) with SMTP id 16A66C31C for ; Mon, 13 Apr 2015 09:21:45 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.arccn.ru (Postfix) with ESMTP id A84A7A0092 for ; Mon, 13 Apr 2015 10:21:44 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=arccn.ru; h= x-mailer:to:references:message-id:date:date:in-reply-to:from :from:subject:subject:mime-version:content-type:content-type; s= dkim; t=1428909703; x=1429773703; bh=J3PBJBcYWabQl/pUeXa97Y+6Cq+ GEi8ls+ves7Q6zBI=; b=VJN0fLycSKAD1MDI0AdBRFly9OqbrtXY5FtaK3ukT+q PDDqNzfRwsN+g7K06/yCcBal0+l4U6vX7sFwk/raV9L5gHbzGCJ17xR6agwH8F7+ LEQ8/JKS3sxoI40U4k9W2nR6B6+7Yu9L/3tlf0ex/ldrPAN86cDKk5oPXGyFda4E = X-Virus-Scanned: Debian amavisd-new at mail.arccn.ru Received: from mail.arccn.ru ([127.0.0.1]) by localhost (mail.arccn.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xri8UECbyqF0 for ; Mon, 13 Apr 2015 10:21:43 +0300 (MSK) Received: from [172.20.99.25] (unknown [172.20.242.11]) by mail.arccn.ru (Postfix) with ESMTPSA id D6C8DA0091; Mon, 13 Apr 2015 10:11:10 +0300 (MSK) Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) From: Igor Ryzhov In-Reply-To: Date: Mon, 13 Apr 2015 10:11:10 +0300 Message-Id: References: <1428510667-6438-1-git-send-email-iryzhov@nfware.com> To: "Ouyang, Changchun" X-Mailer: Apple Mail (2.2098) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" , Igor Ryzhov Subject: Re: [dpdk-dev] [PATCH] doc: fix vhost guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2015 07:21:45 -0000 Hello, Changchun. Previous paragraph says =C2=ABTo enable vhost, turn on vhost library in = the configure file config/common_linuxapp=C2=BB, but string in a = code-block is =C2=ABCONFIG_RTE_LIBRTE_VHOST=3Dn=C2=BB. I thought that = idea is to use the default string from the config file that user have to = change, not already changed string. So I used the same style. Regards, Igor > 13 =D0=B0=D0=BF=D1=80. 2015 =D0=B3., =D0=B2 7:52, Ouyang, Changchun = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >=20 > Hi Igor, >=20 > Good catch, comments as below. >=20 >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Igor Ryzhov >> Sent: Thursday, April 9, 2015 12:31 AM >> To: dev@dpdk.org >> Cc: Igor Ryzhov >> Subject: [dpdk-dev] [PATCH] doc: fix vhost guide >>=20 >> Guide says that a configure parameter to choose between vhost cuse = and >> vhost user will be introduced in the future, but it=E2=80=99s already = added by commit >> 28a1ccca41bf. >>=20 >> Signed-off-by: Igor Ryzhov >> --- >> doc/guides/sample_app_ug/vhost.rst | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >>=20 >> diff --git a/doc/guides/sample_app_ug/vhost.rst >> b/doc/guides/sample_app_ug/vhost.rst >> index 8a7eb3b..df8cd8c 100644 >> --- a/doc/guides/sample_app_ug/vhost.rst >> +++ b/doc/guides/sample_app_ug/vhost.rst >> @@ -309,13 +309,12 @@ Compiling the Sample Code >>=20 >> CONFIG_RTE_LIBRTE_VHOST=3Dn >>=20 >> - vhost user is turned on by default in the = lib/librte_vhost/Makefile. >> - To enable vhost cuse, uncomment vhost cuse and comment vhost = user >> manually. In future, a configure will be created for switch between = two >> implementations. >> + vhost user is turned on by default in the configure file >> config/common_linuxapp. >> + To enable vhost cuse, disable vhost user. >>=20 >> .. code-block:: console >>=20 >> - SRCS-$(CONFIG_RTE_LIBRTE_VHOST) +=3D = vhost_cuse/vhost-net-cdev.c >> vhost_cuse/virtio-net-cdev.c vhost_cuse/eventfd_copy.c >> - #SRCS-$(CONFIG_RTE_LIBRTE_VHOST) +=3D = vhost_user/vhost-net-user.c >> vhost_user/virtio-net-user.c vhost_user/fd_man.c >> + CONFIG_RTE_LIBRTE_VHOST_USER=3Dy >=20 > If it wants to guide user how to enable vhost cuse, then I think > It makes sense to change it into: CONFIG_RTE_LIBRTE_VHOST_USER=3Dn >=20 > Thanks > Changchun