From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92380A0521; Tue, 3 Nov 2020 05:42:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01DBAA8E9; Tue, 3 Nov 2020 05:42:40 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80043.outbound.protection.outlook.com [40.107.8.43]) by dpdk.org (Postfix) with ESMTP id 3B950A54B; Tue, 3 Nov 2020 05:42:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m8bSGLXyBPoXGEz8Sm3p//PD6eTHVfEGWBA3OGm/vL8=; b=qnKGZ48711SOJ/4Mc/ndvYxqjs+j2UIx8OywAUMcX/m8TvEPTzATnnPIdgSim04K8522mhgmPVRjr5M0i8WwasBasZWRFFGeVQP10/FPcdp8eGeU/aS/sQEotAQFuD+JaOx8GzKCP81ZcUwsdJqqPRq57uW3IWZ4h9Sx1mW7SlA= Received: from DB6PR07CA0111.eurprd07.prod.outlook.com (2603:10a6:6:2c::25) by HE1PR0802MB2172.eurprd08.prod.outlook.com (2603:10a6:3:cb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.28; Tue, 3 Nov 2020 04:42:33 +0000 Received: from DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::f) by DB6PR07CA0111.outlook.office365.com (2603:10a6:6:2c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.10 via Frontend Transport; Tue, 3 Nov 2020 04:42:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT004.mail.protection.outlook.com (10.152.20.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Tue, 3 Nov 2020 04:42:33 +0000 Received: ("Tessian outbound ba2270a55485:v64"); Tue, 03 Nov 2020 04:42:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 898d4bb191106fec X-CR-MTA-TID: 64aa7808 Received: from a052fb7cf42b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D59386C4-50AF-4D52-BBD7-3F0D7B1256AC.1; Tue, 03 Nov 2020 04:42:26 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a052fb7cf42b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 Nov 2020 04:42:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TKJfCqXj+Qr4C39v4kOWrr1mYi94Qq6A+yUsOJqdxnSU3fS/dIjIhPg3w6YBgcEkRa8dqWMWwicpWqEZzuFVSnLQw+YzCXOTAQ8nyMc11Dx104da/sP3HJe+MH8MMZYZccDkv0DVEdyvJ9WJgb5ri6ybaVmOorCzu2DuUo33vLF8d6h5hy8qGoWWy9qfFEFCugYw15duDLMRdM9genRLcSVSWKDmBelGO1MwVDZOo8WYV4FWupUUoi0+09eTppjb+ElkHtjh6EOx74TzpfEwxgT3OQ5jaEWex7zJZqudZRsHUrJ/IK6Dh84iSOCOVYzzQP/Crc2lHzs1tkZNmxSbvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m8bSGLXyBPoXGEz8Sm3p//PD6eTHVfEGWBA3OGm/vL8=; b=LWmwo+3aC2sh7LmgC25mj8HJkoVKcEvKPMpAsWa8VtWGX465im+WOHdCwPDSw2EP6E1dvQPGogoWge2dPjUlSPyJtC001hzc0X9TDTwomSSCmWDMAPbNGu/nPvaajd6Y7cBluWAWV8aS5R/69uQtB5uaasp1/n2bduh6S28aLv9ZgbF59NRvviWJnj3N3rJrAC8I29X+/sK5yc7rkOe7vqp2G+2YVxyUPq5CTIp3FjTxzuLl9u4uvLx6Xz9N5gwKiSZp4Cdq9g2edqvXpcTC3g6CIT1PDrbTPB/x1fh3Q80qaLwM+shgAFFArQEjMeVECUHIN/Z/OyingUObw4hrdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m8bSGLXyBPoXGEz8Sm3p//PD6eTHVfEGWBA3OGm/vL8=; b=qnKGZ48711SOJ/4Mc/ndvYxqjs+j2UIx8OywAUMcX/m8TvEPTzATnnPIdgSim04K8522mhgmPVRjr5M0i8WwasBasZWRFFGeVQP10/FPcdp8eGeU/aS/sQEotAQFuD+JaOx8GzKCP81ZcUwsdJqqPRq57uW3IWZ4h9Sx1mW7SlA= Received: from VI1PR08MB4622.eurprd08.prod.outlook.com (2603:10a6:803:bc::17) by VE1PR08MB5614.eurprd08.prod.outlook.com (2603:10a6:800:1a8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Tue, 3 Nov 2020 04:42:24 +0000 Received: from VI1PR08MB4622.eurprd08.prod.outlook.com ([fe80::e9cc:b2a4:eb77:980b]) by VI1PR08MB4622.eurprd08.prod.outlook.com ([fe80::e9cc:b2a4:eb77:980b%7]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 04:42:24 +0000 From: Dharmik Thakkar To: Honnappa Nagarahalli CC: Bruce Richardson , Vladimir Medvedkin , Gavin Hu , Ruifeng Wang , "dev@dpdk.org" , nd , "stable@dpdk.org" Thread-Topic: [PATCH v2 2/4] test/lpm: return error on failure in rcu qsbr perf Thread-Index: AQHWsXOPvIi/NlmMPUumPVnoUlysAqm1nksAgAA2P4A= Date: Tue, 3 Nov 2020 04:42:24 +0000 Message-ID: References: <20201029153634.10647-1-dharmik.thakkar@arm.com> <20201102235203.6342-1-dharmik.thakkar@arm.com> <20201102235203.6342-3-dharmik.thakkar@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [72.182.82.154] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9031122d-18f5-4de9-8716-08d87fb2e129 x-ms-traffictypediagnostic: VE1PR08MB5614:|HE1PR0802MB2172: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5IHnBvwrhlrHmiY96c3Z1SjSzK/DtNblkNJ2pLLS7Bl26diyBh0eYaxltv8uB/g+y9/ZZ7KMjsaROA4JHorKwZS1hpLBy0qTbqEJlErrt+q5oKNMchm7CVkIR010YSb9FM7kRfWavnVtAjLq/vdMg6Wo7I6451m1DE1qJs9SxxHLQRrmGc/u9RBi2121M/0bmeGDY8v1dF8ApX2mFVF6TKH6Yq1J/wB99N0hNBiD0DdNL4QewrFKuvvxlYp1P0q+U2Va217ET6PCo92N9iK5PY4h02gqL4JsK18BRK+1jX7LvZzXOq0CLLVf+blnpmKVu1bx+P6TyNO8E9qIgOhJlw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB4622.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(136003)(396003)(366004)(86362001)(478600001)(6486002)(316002)(5660300002)(37006003)(8936002)(71200400001)(4326008)(83380400001)(36756003)(76116006)(6862004)(91956017)(6636002)(66946007)(6512007)(54906003)(2906002)(64756008)(66556008)(66476007)(2616005)(66446008)(33656002)(6506007)(53546011)(26005)(186003)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: hT2R8DU9wllCs3ssmjdVzuL1iJjSTohi13i7dSuMjZc4SdG4Lw1TRdFiNlOufxU/VtpqKotgBeBidZHhxMWWweIc1SHImNPjQVm2vgoyqn6E/rI6f7TOGskk7QTfsEObAogGEnxnEbTckgFe0Z1Z9iBNWEmaV4CRwbSzieJno+ZgR/AoQN/dE8+UFO2CxsIP35u3prxL3GKN+04mpkXJznIjB67qnL1LOZKNoKrtMW2+1dQbAH3ULK8TMyVfNcD8B4ObcHWT3LArTkROwumYM/MlMgTMCnubhLsLSh86G5C0bHTHWw/XnXv4wTJ/IJHqpMbclXn8gy1uZItEeWwKnCTvaIojbZFRkg+lk+CKLDWOYEgSwuuaN9OhOKNk4/+V0K0RCoiFUaaGv4Vw/KYyMwdpk+i27kDLoDynwR7dL8GhlQ+C76zYse2crz7R7wWPsOAeUFlStNYvNclFOP8vnPAQBtRloQnCfMV0B8F0+023VYCEzUaNyScpNofFib/FQFfc0XxE94ElE6kW+NDF9Uze5aG476Tn83oyzQzOA1ldZQTrTCTOPSv4H//tZ/m2tLtn1bzFqT4NO+vQAWrhT46BNhfx5cV5ulNT6nufga7ztecRxuBROR9cYZaotN2te51yORQjgm9xL/n1oS4nFQ== Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5614 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5f64c2fc-8948-4bb6-4458-08d87fb2dbfd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PLhXwbf+cmN/ymKL+qvUlxCVEHvPaxFy2zP8tuJLqSXsWjhF+cjRsKozDNKJ0fjjvTvRJ+BwSOJZZtLsLwVgKMDh1NwFTLEukQMjcefg7cFxgADRdEeiODP8Z1OK8NnCXHyDa5b++LT3D9YPvNm0rDJ6mlLEOhW8G2BA28Di6N+zGaUyCx086MKZP8LPPbrLTJ5sPUXZ9qmBrmgYPuwBRyuzSCcbrWv5eP/31UbIbOrgLP0ii2iImJ8yi2n9fjlIx/+MMQwGD8XADUmyZPjLNiJ+z0G+/ywjmcoktFJPT0KGyReN/MdnQKfD5oaIs36GQDY6pJqCfUXUlOemGxZSxArOK+2i3O7AJSZbfyOHIdS3pFdVVmaZCskElb6iT4k7QVaRB7qVG/KQlGcB3uH0ZQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(46966005)(5660300002)(6862004)(54906003)(186003)(2616005)(82310400003)(83380400001)(316002)(2906002)(37006003)(33656002)(26005)(478600001)(6512007)(36756003)(8676002)(4326008)(6636002)(70586007)(450100002)(336012)(8936002)(86362001)(6506007)(47076004)(70206006)(82740400003)(81166007)(53546011)(356005)(6486002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2020 04:42:33.1261 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9031122d-18f5-4de9-8716-08d87fb2e129 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2172 Subject: Re: [dpdk-dev] [PATCH v2 2/4] test/lpm: return error on failure in rcu qsbr perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Nov 2, 2020, at 7:28 PM, Honnappa Nagarahalli wrote: >=20 > >=20 >>=20 >> Return error if Add/Delete fail in multiwriter perf test >>=20 >> Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") >> Cc: honnappa.nagarahalli@arm.com >> Cc: stable@dpdk.org >>=20 >> Signed-off-by: Dharmik Thakkar >> Reviewed-by: Ruifeng Wang >> --- >> app/test/test_lpm_perf.c | 4 ++++ >> 1 file changed, 4 insertions(+) >>=20 >> diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index >> 45164b23214b..55084816ab91 100644 >> --- a/app/test/test_lpm_perf.c >> +++ b/app/test/test_lpm_perf.c >> @@ -453,6 +453,8 @@ test_lpm_rcu_qsbr_writer(void *arg) >> next_hop_add) !=3D 0) { >> printf("Failed to add iteration %d, route# >> %d\n", >> i, j); >> + pthread_mutex_unlock(&lpm_mutex); >> + return -1; > Would be good to use the "goto error" method used in this file in other f= unctions. Yes, will update in the next version. >=20 >> } >> pthread_mutex_unlock(&lpm_mutex); >> } >> @@ -464,6 +466,8 @@ test_lpm_rcu_qsbr_writer(void *arg) >> large_ldepth_route_table[j].depth) !=3D 0) { >> printf("Failed to delete iteration %d, route# >> %d\n", >> i, j); >> + pthread_mutex_unlock(&lpm_mutex); >> + return -1; >> } >> pthread_mutex_unlock(&lpm_mutex); >> } >> -- >> 2.17.1