From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: Ali Alnubani <alialnu@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix initialization of struct members
Date: Thu, 15 Nov 2018 05:50:46 +0000 [thread overview]
Message-ID: <AD70D29B-776C-4CF6-A5D8-251706517CEC@mellanox.com> (raw)
In-Reply-To: <DB7PR05MB4426CCEDCBDDC228ABE37718C3C30@DB7PR05MB4426.eurprd05.prod.outlook.com>
> On Nov 14, 2018, at 4:06 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
>
> Adding Koh, see below
>
> Tuesday, November 13, 2018 9:11 PM, Ali Alnubani:
>> Subject: [PATCH 2/2] net/mlx5: fix initialization of struct members
>>
>> This patch fixes compilation errors with meson and the clang compiler caused
>> by some of the struct members not being initialized.
>>
>> ```
>> ../drivers/net/mlx5/mlx5_mr.c:345:37: error: missing field 'end'
>> initializer [-Werror,-Wmissing-field-initializers]
>> struct mlx5_mr_cache entry = { 0, };
>> ^
>> ../drivers/net/mlx5/mlx5_mr.c:389:36: error: missing field 'end'
>> initializer [-Werror,-Wmissing-field-initializers]
>> struct mlx5_mr_cache ret = { 0, };
>> ^
>> ../drivers/net/mlx5/mlx5_mr.c:691:35: error: missing field 'end'
>> initializer [-Werror,-Wmissing-field-initializers]
>> struct mlx5_mr_cache ret = { 0, };
>> ^ ```
>>
>> The compilation errors reproduce with
>> clang version 3.4.2 (tags/RELEASE_34/dot2-final) on RHEL.
>>
>> Fixes: e1114ff6a5ab ("net/mlx5: support e-switch flow count action")
>> Fixes: db48f9db5d9f ("net/mlx5: support new flow counter API")
>> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
>> Fixes: 65c9d24170c9 ("net/mlx5: enable loopback by configured mode")
>> Fixes: 87011737b715 ("mlx5: add software counters")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
>
> [...]
>
>> diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c index
>> f4b15d3f6..435eaeee2 100644
>> --- a/drivers/net/mlx5/mlx5_mr.c
>> +++ b/drivers/net/mlx5/mlx5_mr.c
>> @@ -342,8 +342,9 @@ mr_insert_dev_cache(struct rte_eth_dev *dev,
>> struct mlx5_mr *mr)
>> DRV_LOG(DEBUG, "port %u inserting MR(%p) to global cache",
>> dev->data->port_id, (void *)mr);
>> for (n = 0; n < mr->ms_bmp_n; ) {
>> - struct mlx5_mr_cache entry = { 0, };
>> + struct mlx5_mr_cache entry;
>>
>> + memset(&entry, 0, sizeof(entry));
>> /* Find a contiguous chunk and advance the index. */
>> n = mr_find_next_chunk(mr, &entry, n);
>> if (!entry.end)
>> @@ -386,8 +387,9 @@ mr_lookup_dev_list(struct rte_eth_dev *dev, struct
>> mlx5_mr_cache *entry,
>> if (mr->ms_n == 0)
>> continue;
>> for (n = 0; n < mr->ms_bmp_n; ) {
>> - struct mlx5_mr_cache ret = { 0, };
>> + struct mlx5_mr_cache ret;
>>
>> + memset(&ret, 0, sizeof(ret));
>
> do you have concerns about the performance w/ this extra memset?
For the three funcs modified with memset here are all slow-paths for the MR.
It is safe for performance.
Thanks,
Yongseok
>
>> n = mr_find_next_chunk(mr, &ret, n);
>> if (addr >= ret.start && addr < ret.end) {
>> /* Found. */
>> @@ -688,8 +690,9 @@ mlx5_mr_create(struct rte_eth_dev *dev, struct
>> mlx5_mr_cache *entry,
>> */
>> for (n = 0; n < ms_n; ++n) {
>> uintptr_t start;
>> - struct mlx5_mr_cache ret = { 0, };
>> + struct mlx5_mr_cache ret;
>>
>> + memset(&ret, 0, sizeof(ret));
>> start = data_re.start + n * msl->page_sz;
>> /* Exclude memsegs already registered by other MRs. */
>> if (mr_lookup_dev(dev, &ret, start) == UINT32_MAX) { diff --
>> git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index
>> eef485021..b27fc4798 100644
>> --- a/drivers/net/mlx5/mlx5_rxq.c
>> +++ b/drivers/net/mlx5/mlx5_rxq.c
>> @@ -1782,7 +1782,7 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,
>> struct mlx5_ind_table_ibv *ind_tbl;
>> struct ibv_qp *qp;
>> #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
>> - struct mlx5dv_qp_init_attr qp_init_attr = {0};
>> + struct mlx5dv_qp_init_attr qp_init_attr;
>> #endif
>> int err;
>>
>> @@ -1795,6 +1795,7 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,
>> return NULL;
>> }
>> #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
>> + memset(&qp_init_attr, 0, sizeof(qp_init_attr));
>> if (tunnel) {
>> qp_init_attr.comp_mask =
>>
>> MLX5DV_QP_INIT_ATTR_MASK_QP_CREATE_FLAGS;
>> diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c
>> index a14d1e491..fccb9af0d 100644
>> --- a/drivers/net/mlx5/mlx5_stats.c
>> +++ b/drivers/net/mlx5/mlx5_stats.c
>> @@ -354,10 +354,11 @@ int
>> mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) {
>> struct priv *priv = dev->data->dev_private;
>> - struct rte_eth_stats tmp = {0};
>> + struct rte_eth_stats tmp;
>> unsigned int i;
>> unsigned int idx;
>>
>> + memset(&tmp, 0, sizeof(tmp));
>> /* Add software counters. */
>> for (i = 0; (i != priv->rxqs_n); ++i) {
>> struct mlx5_rxq_data *rxq = (*priv->rxqs)[i];
>> --
>> 2.11.0
>
next prev parent reply other threads:[~2018-11-15 5:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 19:11 [dpdk-dev] [PATCH 1/2] net/mlx4: " Ali Alnubani
2018-11-13 19:11 ` [dpdk-dev] [PATCH 2/2] net/mlx5: " Ali Alnubani
2018-11-14 12:06 ` Shahaf Shuler
2018-11-15 5:50 ` Yongseok Koh [this message]
2018-11-15 8:49 ` [dpdk-dev] [PATCH 1/2] net/mlx4: " Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AD70D29B-776C-4CF6-A5D8-251706517CEC@mellanox.com \
--to=yskoh@mellanox.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).