From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA7B341CBE; Fri, 17 Feb 2023 10:07:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D9F640F17; Fri, 17 Feb 2023 10:07:56 +0100 (CET) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id C898B40EE1 for ; Fri, 17 Feb 2023 10:07:54 +0100 (CET) Received: by mail-wr1-f50.google.com with SMTP id n3so52572wri.10 for ; Fri, 17 Feb 2023 01:07:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=sf0p9yc3rFBt3H0D4G+8mvkkus6d5LslaGsD+g0CndQ=; b=LZ9oRkZhbDqB96axtO7X403fdpan9TAju8HK62KIHhlVPM2/mY3gz1QeN6wIELEsIG SrtM5ImF1QVgbO1A9gCtvrN3mMMTETiE4RQH6ryIsMUeNIJ7Lm2BFHCcnIiWbXOD2DRb 8lTUe/bJH1A7a06hKBvC+UtaSww+Tjao74oXq4D6SWMdIuJlyexsQZCWMUZ9F0Bd8JGm KLqj+nUrM/asvwhUmLEGAQaWlU2CazJWZ5YsKlT+caIrvhnMS/oS/OkiUu3eE3XgLUTv XWGMb56/fgrmRl4fzjH9zB2sxP06hJE1cPjplvMGspr/TK9itAHpKZt9630yy0mVPX9o LkyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sf0p9yc3rFBt3H0D4G+8mvkkus6d5LslaGsD+g0CndQ=; b=Q5AHzM46pbspA3ZcEDYGnNGswbn/f7yDyw8a1w0TH672IDIZWa3evVoIH+HLTB15+H NCeACBBVmB8nOTxODapmw2SLdticebg/MyzYBCwbvk4MwU557WoSVqYOET9nW9q+yt65 ZcE8etoXRfEDW/TBH6G7iwYyveJbgrvfJBGc+rqmU390L1il164uzOMqDdgkCpIsa0jw uBls60uatWlYRPaZ74I0BIXzhQDtoF8xdG76NkZcxq6cy4R6FQufsAqQZOazuTrp03ms OjtSWeqdb72c+1RGZ6spBjijItXgGXQ+EJXNA+6ZJFp8L95zorfuHuDMUIQhDa5oICuy FilQ== X-Gm-Message-State: AO0yUKV9BowEkXE3tRN71QRnee5xM9+z9CHgqPQNGeqAhPEFM0JqjTGj JQSFziOJv0kljqr0Mk48X5A= X-Google-Smtp-Source: AK7set/wsszgr5opPw7M+936PK0EYQdR8BGQQkU8C0gZF0Q8Pj0X7wisnK+0+KvS4Y2qZWtcn68rCQ== X-Received: by 2002:adf:dd08:0:b0:2c6:3d2a:435b with SMTP id a8-20020adfdd08000000b002c63d2a435bmr1489012wrm.67.1676624874223; Fri, 17 Feb 2023 01:07:54 -0800 (PST) Received: from smtpclient.apple ([176.41.28.141]) by smtp.gmail.com with ESMTPSA id w9-20020a5d6089000000b002be099f78c0sm3616312wrt.69.2023.02.17.01.07.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Feb 2023 01:07:53 -0800 (PST) From: Levend Sayar Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_A985E7C8-43CB-4FA6-BAFF-2E7283E6C264" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH 1/2] net/gve: change offloading capability Date: Fri, 17 Feb 2023 12:07:42 +0300 In-Reply-To: Cc: Junfeng Guo , dev@dpdk.org To: Rushil Gupta References: <20230216185814.27830-1-levendsayar@gmail.com> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --Apple-Mail=_A985E7C8-43CB-4FA6-BAFF-2E7283E6C264 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Thanks Rushil for acknowledging. Best, Levend > On 16 Feb 2023, at 23:14, Rushil Gupta wrote: >=20 > Makes sense. The virtual device only does L4 checksum. >=20 > Acked-by: Rushil Gupta > >=20 > On Thu, Feb 16, 2023 at 10:58 AM Levend Sayar > wrote: >> Google Virtual NIC is not doing IPv4 checksummimg. >> Removed that capability from PMD. >>=20 >> Signed-off-by: Levend Sayar > >> --- >> drivers/net/gve/gve_ethdev.c | 1 - >> 1 file changed, 1 deletion(-) >>=20 >> diff --git a/drivers/net/gve/gve_ethdev.c = b/drivers/net/gve/gve_ethdev.c >> index 06d1b796c8..fef2458a16 100644 >> --- a/drivers/net/gve/gve_ethdev.c >> +++ b/drivers/net/gve/gve_ethdev.c >> @@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct = rte_eth_dev_info *dev_info) >> dev_info->rx_offload_capa =3D 0; >> dev_info->tx_offload_capa =3D >> RTE_ETH_TX_OFFLOAD_MULTI_SEGS | >> - RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | >> RTE_ETH_TX_OFFLOAD_UDP_CKSUM | >> RTE_ETH_TX_OFFLOAD_TCP_CKSUM | >> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | >> --=20 >> 2.37.1 (Apple Git-137.1) >>=20 --Apple-Mail=_A985E7C8-43CB-4FA6-BAFF-2E7283E6C264 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Thanks Rushil = for = acknowledging.

Best,
Levend

=
On 16 Feb 2023, at 23:14, Rushil = Gupta <rushilg@google.com> wrote:

Makes sense. The virtual device only does L4 = checksum.

Acked-by: Rushil Gupta <rushilg@google.com>

On Thu, = Feb 16, 2023 at 10:58 AM Levend Sayar <levendsayar@gmail.com> = wrote:
Google Virtual NIC is not doing IPv4 = checksummimg.
Removed that capability from PMD.

Signed-off-by: Levend Sayar <levendsayar@gmail.com>
---
 drivers/net/gve/gve_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/gve/gve_ethdev.c = b/drivers/net/gve/gve_ethdev.c
index 06d1b796c8..fef2458a16 100644
--- a/drivers/net/gve/gve_ethdev.c
+++ b/drivers/net/gve/gve_ethdev.c
@@ -282,7 +282,6 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct = rte_eth_dev_info *dev_info)
        dev_info->rx_offload_capa =3D 0;
        dev_info->tx_offload_capa =3D
                = RTE_ETH_TX_OFFLOAD_MULTI_SEGS   |
-              =  RTE_ETH_TX_OFFLOAD_IPV4_CKSUM   |
                = RTE_ETH_TX_OFFLOAD_UDP_CKSUM    |
                = RTE_ETH_TX_OFFLOAD_TCP_CKSUM    |
                = RTE_ETH_TX_OFFLOAD_SCTP_CKSUM   |
--
2.37.1 (Apple Git-137.1)


= --Apple-Mail=_A985E7C8-43CB-4FA6-BAFF-2E7283E6C264--