From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22CF2A0471 for ; Fri, 19 Jul 2019 03:14:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44C3A322C; Fri, 19 Jul 2019 03:14:52 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E6BAC2C2B for ; Fri, 19 Jul 2019 03:14:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 18:14:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,280,1559545200"; d="scan'208";a="252002933" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 18 Jul 2019 18:14:49 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 18:14:49 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 18:14:48 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.55]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 09:14:46 +0800 From: "Zhang, Xiao" To: "Wang, Haiyue" , "Zhang, Qi Z" , "dev@dpdk.org" CC: "Xing, Beilei" Thread-Topic: [v2] net/i40e: fix SFP X722 not work with FW4.16 Thread-Index: AQHVPXCowLyxgq4lz0qtqOrnP3JQAKbQmLyAgAABb4CAAId4AA== Date: Fri, 19 Jul 2019 01:14:46 +0000 Message-ID: References: <1563470021-16325-1-git-send-email-xiao.zhang@intel.com> <1563490319-53151-1-git-send-email-xiao.zhang@intel.com> <039ED4275CED7440929022BC67E7061153D69617@SHSMSX105.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v2] net/i40e: fix SFP X722 not work with FW4.16 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Friday, July 19, 2019 9:02 AM > To: Zhang, Qi Z ; Zhang, Xiao ; > dev@dpdk.org > Cc: Xing, Beilei > Subject: RE: [v2] net/i40e: fix SFP X722 not work with FW4.16 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Friday, July 19, 2019 08:57 > > To: Zhang, Xiao ; dev@dpdk.org > > Cc: Xing, Beilei ; Wang, Haiyue > > > > Subject: RE: [v2] net/i40e: fix SFP X722 not work with FW4.16 > > > > > > > > > -----Original Message----- > > > From: Zhang, Xiao > > > Sent: Friday, July 19, 2019 6:52 AM > > > To: dev@dpdk.org > > > Cc: Xing, Beilei ; Wang, Haiyue > > > ; Zhang, Qi Z ; Zhang, > > > Xiao > > > Subject: [v2] net/i40e: fix SFP X722 not work with FW4.16 > > > > Please add fix line and Cc stable. > > Fixes: 73cd7d6dc8e1 ("net/i40e: use set switch AQ instead of register > > setting") > > > > > > > > FW4.16 of SFP X722 does not support setting TPID by > > > set_switch_config adminq operation, for firmware version less than > > > 4.16 TPID is set by register instead. For device SFP X722, disable > > > adminq flag to follow the same path with old firmware version to make= it > work. > > > > > > Signed-off-by: Xiao Zhang > > > --- > > > v2 > > > Unset adminq flag instead of only checking device id when set TPID. > > > v1 > > > Check device id when setting TPID, use adminq if not SFP X722, else > > > use register. > > > --- > > > drivers/net/i40e/i40e_ethdev.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > > b/drivers/net/i40e/i40e_ethdev.c index 2b9fc45..2b2c877 100644 > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > @@ -1358,6 +1358,10 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, > > > void *init_params __rte_unused) > > > PMD_INIT_LOG(ERR, "Failed to init adminq: %d", ret); > > > return -EIO; > > > } > > > + /* Firmware of SFP x722 does not support adminq option */ > > > + if (hw->device_id =3D=3D I40E_DEV_ID_SFP_X722) > > > + hw->flags &=3D ~I40E_HW_FLAG_802_1AD_CAPABLE; > > > + > The commit log says some version like FW4.16 doesn't support ADQ, but thi= s line > of code means all FW doesn't support ADQ. Which one is right ? :-) Old versions do not support ADQ and did not use ADQ operation in the code. = And new FW with version 4.16 also does not support ADQ neither but used the= ADQ operation in the code. So all FW of SFP X722 do not support ADQ, the commit log may be confuse, I = will make it more clear. >=20 > > > PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d > eetrack > > > %04x", > > > hw->aq.fw_maj_ver, hw->aq.fw_min_ver, > > > hw->aq.api_maj_ver, hw->aq.api_min_ver, > > > -- > > > 2.7.4