DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] drivers/net: fix address of first segment
@ 2019-09-24  5:48 Joyce Kong
  2019-09-24  5:48 ` [dpdk-dev] [PATCH 1/2] net/i40e: " Joyce Kong
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Joyce Kong @ 2019-09-24  5:48 UTC (permalink / raw)
  To: dev; +Cc: nd, thomas, jerinj, xiao.zhang, gavin.hu, honnappa.nagarahalli

The series fix (dereference after null check) coverity issue on NEON vPMD.
Which for x86 sse/avx2 (commit 4916f63985ddb56af43980252d1134d051523685,
commit 739c35f08bc0296ffda47f006f1903a67527063f) have been merged.

Joyce Kong (2):
  net/i40e: fix address of first segment
  net/ixgbe: fix address of first segment

 drivers/net/i40e/i40e_rxtx_vec_neon.c   | 1 +
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 1 +
 2 files changed, 2 insertions(+)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH 1/2] net/i40e: fix address of first segment
  2019-09-24  5:48 [dpdk-dev] [PATCH 0/2] drivers/net: fix address of first segment Joyce Kong
@ 2019-09-24  5:48 ` Joyce Kong
  2019-09-24  6:47   ` Zhang, Xiao
  2019-09-24  5:48 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: " Joyce Kong
  2019-10-17  5:39 ` [dpdk-dev] [PATCH 0/2] drivers/net: " Ye Xiaolong
  2 siblings, 1 reply; 6+ messages in thread
From: Joyce Kong @ 2019-09-24  5:48 UTC (permalink / raw)
  To: dev
  Cc: nd, thomas, jerinj, xiao.zhang, gavin.hu, honnappa.nagarahalli, stable

This patch fixes (dereference after null check) coverity issue.
The address of first segmented packets was not set correctly during
reassembling packets which led to this issue.

Coverity issue: 343422, 343403
Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector driver")
Cc: stable@dpdk.org

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 drivers/net/i40e/i40e_rxtx_vec_neon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c
index 864eb9a..deb185f 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_neon.c
+++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c
@@ -474,6 +474,7 @@ i40e_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
 			i++;
 		if (i == nb_bufs)
 			return nb_bufs;
+		rxq->pkt_first_seg = rx_pkts[i];
 	}
 	return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i,
 		&split_flags[i]);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH 2/2] net/ixgbe: fix address of first segment
  2019-09-24  5:48 [dpdk-dev] [PATCH 0/2] drivers/net: fix address of first segment Joyce Kong
  2019-09-24  5:48 ` [dpdk-dev] [PATCH 1/2] net/i40e: " Joyce Kong
@ 2019-09-24  5:48 ` Joyce Kong
  2019-09-24  6:48   ` Zhang, Xiao
  2019-10-17  5:39 ` [dpdk-dev] [PATCH 0/2] drivers/net: " Ye Xiaolong
  2 siblings, 1 reply; 6+ messages in thread
From: Joyce Kong @ 2019-09-24  5:48 UTC (permalink / raw)
  To: dev
  Cc: nd, thomas, jerinj, xiao.zhang, gavin.hu, honnappa.nagarahalli, stable

This patch fixes (dereference after null check) coverity issue.
The address of first segmented packets was not set correctly during
reassembling packets which led to this issue.

Coverity issue: 13245
Fixes: 8a44c15aa57d ("net/ixgbe: extract non-x86 specific code from vector driver")
Cc: stable@dpdk.org

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
---
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
index eeb8259..26c0ef5 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
@@ -375,6 +375,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
 			i++;
 		if (i == nb_bufs)
 			return nb_bufs;
+		rxq->pkt_first_seg = rx_pkts[i];
 	}
 	return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i,
 		&split_flags[i]);
-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix address of first segment
  2019-09-24  5:48 ` [dpdk-dev] [PATCH 1/2] net/i40e: " Joyce Kong
@ 2019-09-24  6:47   ` Zhang, Xiao
  0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Xiao @ 2019-09-24  6:47 UTC (permalink / raw)
  To: Joyce Kong, dev
  Cc: nd, thomas, jerinj, gavin.hu, honnappa.nagarahalli, stable



> -----Original Message-----
> From: Joyce Kong [mailto:joyce.kong@arm.com]
> Sent: Tuesday, September 24, 2019 1:49 PM
> To: dev@dpdk.org
> Cc: nd@arm.com; thomas@monjalon.net; jerinj@marvell.com; Zhang, Xiao
> <xiao.zhang@intel.com>; gavin.hu@arm.com; honnappa.nagarahalli@arm.com;
> stable@dpdk.org
> Subject: [PATCH 1/2] net/i40e: fix address of first segment
> 
> This patch fixes (dereference after null check) coverity issue.
> The address of first segmented packets was not set correctly during
> reassembling packets which led to this issue.
> 
> Coverity issue: 343422, 343403
> Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector
> driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> ---
>  drivers/net/i40e/i40e_rxtx_vec_neon.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c
> b/drivers/net/i40e/i40e_rxtx_vec_neon.c
> index 864eb9a..deb185f 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c
> +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c
> @@ -474,6 +474,7 @@ i40e_recv_scattered_pkts_vec(void *rx_queue, struct
> rte_mbuf **rx_pkts,
>  			i++;
>  		if (i == nb_bufs)
>  			return nb_bufs;
> +		rxq->pkt_first_seg = rx_pkts[i];
>  	}
>  	return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i,
>  		&split_flags[i]);
> --
> 2.7.4

Reviewed-by: Xiao Zhang <xiao.zhang@intel.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix address of first segment
  2019-09-24  5:48 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: " Joyce Kong
@ 2019-09-24  6:48   ` Zhang, Xiao
  0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Xiao @ 2019-09-24  6:48 UTC (permalink / raw)
  To: Joyce Kong, dev
  Cc: nd, thomas, jerinj, gavin.hu, honnappa.nagarahalli, stable



> -----Original Message-----
> From: Joyce Kong [mailto:joyce.kong@arm.com]
> Sent: Tuesday, September 24, 2019 1:49 PM
> To: dev@dpdk.org
> Cc: nd@arm.com; thomas@monjalon.net; jerinj@marvell.com; Zhang, Xiao
> <xiao.zhang@intel.com>; gavin.hu@arm.com; honnappa.nagarahalli@arm.com;
> stable@dpdk.org
> Subject: [PATCH 2/2] net/ixgbe: fix address of first segment
> 
> This patch fixes (dereference after null check) coverity issue.
> The address of first segmented packets was not set correctly during
> reassembling packets which led to this issue.
> 
> Coverity issue: 13245
> Fixes: 8a44c15aa57d ("net/ixgbe: extract non-x86 specific code from vector
> driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> ---
>  drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
> b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
> index eeb8259..26c0ef5 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
> @@ -375,6 +375,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct
> rte_mbuf **rx_pkts,
>  			i++;
>  		if (i == nb_bufs)
>  			return nb_bufs;
> +		rxq->pkt_first_seg = rx_pkts[i];
>  	}
>  	return i + reassemble_packets(rxq, &rx_pkts[i], nb_bufs - i,
>  		&split_flags[i]);
> --
> 2.7.4

Reviewed-by: Xiao Zhang <xiao.zhang@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 0/2] drivers/net: fix address of first segment
  2019-09-24  5:48 [dpdk-dev] [PATCH 0/2] drivers/net: fix address of first segment Joyce Kong
  2019-09-24  5:48 ` [dpdk-dev] [PATCH 1/2] net/i40e: " Joyce Kong
  2019-09-24  5:48 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: " Joyce Kong
@ 2019-10-17  5:39 ` Ye Xiaolong
  2 siblings, 0 replies; 6+ messages in thread
From: Ye Xiaolong @ 2019-10-17  5:39 UTC (permalink / raw)
  To: Joyce Kong
  Cc: dev, nd, thomas, jerinj, xiao.zhang, gavin.hu, honnappa.nagarahalli

On 09/24, Joyce Kong wrote:
>The series fix (dereference after null check) coverity issue on NEON vPMD.
>Which for x86 sse/avx2 (commit 4916f63985ddb56af43980252d1134d051523685,
>commit 739c35f08bc0296ffda47f006f1903a67527063f) have been merged.
>
>Joyce Kong (2):
>  net/i40e: fix address of first segment
>  net/ixgbe: fix address of first segment
>
> drivers/net/i40e/i40e_rxtx_vec_neon.c   | 1 +
> drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 1 +
> 2 files changed, 2 insertions(+)
>
>-- 
>2.7.4
>

For series:

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel.

Thanks,
Xiaolong

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-10-17  5:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24  5:48 [dpdk-dev] [PATCH 0/2] drivers/net: fix address of first segment Joyce Kong
2019-09-24  5:48 ` [dpdk-dev] [PATCH 1/2] net/i40e: " Joyce Kong
2019-09-24  6:47   ` Zhang, Xiao
2019-09-24  5:48 ` [dpdk-dev] [PATCH 2/2] net/ixgbe: " Joyce Kong
2019-09-24  6:48   ` Zhang, Xiao
2019-10-17  5:39 ` [dpdk-dev] [PATCH 0/2] drivers/net: " Ye Xiaolong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).