From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0062.outbound.protection.outlook.com [104.47.2.62]) by dpdk.org (Postfix) with ESMTP id 3CE671B7A2 for ; Tue, 15 May 2018 19:05:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ldmCVOPyV3VgCCSy2zU5NWV6thOxe/cGaQcXENuLXHU=; b=wB3KdfJkRzKqv+JNRmX2bQJWCHzogumWBD4HS8kKMBxAM760XnrPlDXBjaIpIjjy4WXdU1nzZouLpXRVl336rOfUs97Xxynit/rnzlZ4H0NLZz9gq2ms8d6u5/eEpJHeB4eJDi5Vcv420KrmPoW9ryXrwfd5RBRXdG5mp8k9BE4= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2832.eurprd05.prod.outlook.com (10.172.11.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Tue, 15 May 2018 17:05:38 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::11b2:1e2d:709c:695d%13]) with mapi id 15.20.0755.018; Tue, 15 May 2018 17:05:37 +0000 From: Yongseok Koh To: Gavin Hu CC: "dev@dpdk.org" , Sirshak Das , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , Shahaf Shuler Thread-Topic: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue Thread-Index: AQHT7C6E0b3pe6+RTUeSVUPHYaf+u6QxBYUA Date: Tue, 15 May 2018 17:05:37 +0000 Message-ID: References: <1526372924-28411-1-git-send-email-gavin.hu@arm.com> <1526376227-25534-1-git-send-email-gavin.hu@arm.com> <1526376227-25534-2-git-send-email-gavin.hu@arm.com> In-Reply-To: <1526376227-25534-2-git-send-email-gavin.hu@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2832; 7:HHx3mcH+RLXaNMKNNcpkth0rOE0hORX/Vm/O+5gk6UuOpujnNBeqYpTf9SSkkSuzDo9sYhRWiQIzi4aW6ZK479AfrnAlt58a4DhOQiLD1jw9u9LmhlgDr2bs57ejwS5W7phSzL6ONmIArd9PC3oqxFPiPTaam9+ar7EpjQFgXE1UMSlESkzNb+RcLsksBYJt0I/Gt3hEQS+xfQIXxvKY5pb2kP8zoH9kknVixbyRmn2SOGwyeIqW4NpnNjAnT68K x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2832; x-ms-traffictypediagnostic: VI1PR0501MB2832: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR0501MB2832; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2832; x-forefront-prvs: 0673F5BE31 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(39380400002)(396003)(366004)(376002)(199004)(189003)(36756003)(476003)(11346002)(305945005)(3846002)(6436002)(3660700001)(82746002)(6246003)(53936002)(2900100001)(107886003)(99286004)(102836004)(6486002)(53546011)(6506007)(6512007)(229853002)(6116002)(97736004)(7736002)(186003)(2906002)(26005)(76176011)(68736007)(486006)(2616005)(3280700002)(446003)(6916009)(478600001)(33656002)(14454004)(8676002)(8936002)(106356001)(25786009)(83716003)(66066001)(105586002)(54906003)(81156014)(4326008)(316002)(5660300001)(5250100002)(86362001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2832; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 0kX39dq8JLkX0JlAk0S8wK7XYNoqDWgibOIrOQbygMvSFADRAMbwTq4QExcTU0jO63ioCU6UIgtbgVyU9kfR/rjZ7UmBWMvKahrRt94SFktFjHIyxxJ1s4Vhc4zdY+zNStNVkoyftae+ATWd+i3BLb0uxxoUYqL5RjdAwsDSojgmforAPIMitfTKYggdHSNw spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <0A7F155C733E8C4F968F51DE9CA34E9C@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 133fa9d5-1701-41d4-7ec3-08d5ba8614af X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 133fa9d5-1701-41d4-7ec3-08d5ba8614af X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2018 17:05:37.7754 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2832 Subject: Re: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 17:05:40 -0000 > On May 15, 2018, at 2:23 AM, Gavin Hu wrote: The title should start from 'net/mlx5: ...' and please be more specific why that pair of parentheses is needed. Add more commit messages and it'd be better to add the error messages like you do in the other commit. To me, it still looks unnecessary. Thanks, Yongseok > Signed-off-by: Gavin Hu > Signed-off-by: Sirshak Das > Reviewed-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli > --- > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx= 5_rxtx_vec_neon.h > index 2673d6b..71a5eaf 100644 > --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > @@ -167,8 +167,8 @@ txq_scatter_v(struct mlx5_txq_data *txq, struct rte_m= buf **pkts, > vst1q_u8((void *)t_wqe, ctrl); > /* Fill ESEG in the header. */ > vst1q_u16((void *)(t_wqe + 1), > - (uint16x8_t) { 0, 0, cs_flags, rte_cpu_to_be_16(len), > - 0, 0, 0, 0 }); > + ((uint16x8_t) { 0, 0, cs_flags, rte_cpu_to_be_16(len), > + 0, 0, 0, 0 })); > txq->wqe_ci =3D wqe_ci; > } > if (!n) > @@ -300,10 +300,10 @@ txq_burst_v(struct mlx5_txq_data *txq, struct rte_m= buf **pkts, uint16_t pkts_n, > vst1q_u8((void *)t_wqe, ctrl); > /* Fill ESEG in the header. */ > vst1q_u8((void *)(t_wqe + 1), > - (uint8x16_t) { 0, 0, 0, 0, > - cs_flags, 0, 0, 0, > - 0, 0, 0, 0, > - 0, 0, 0, 0 }); > + ((uint8x16_t) { 0, 0, 0, 0, > + cs_flags, 0, 0, 0, > + 0, 0, 0, 0, > + 0, 0, 0, 0 })); > #ifdef MLX5_PMD_SOFT_COUNTERS > txq->stats.opackets +=3D pkts_n; > #endif > --=20 > 2.1.4 >=20