From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0E68AA00E6
	for <public@inbox.dpdk.org>; Wed,  7 Aug 2019 14:53:49 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id B8BD92BD3;
	Wed,  7 Aug 2019 14:53:48 +0200 (CEST)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com
 (mail-eopbgr70089.outbound.protection.outlook.com [40.107.7.89])
 by dpdk.org (Postfix) with ESMTP id 6699D2BCE
 for <dev@dpdk.org>; Wed,  7 Aug 2019 14:53:47 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=WnPu5NXPoEjdHmtqrNnh1VeiSMLOsKyfSCji43ggXus+zjC7vF/PHwYuxAmtYpoKhS+k3lAGA5zCntWrG4NEnUgfTBQH+qKmf/6A0X+iFLEW8NiPzuDKJF2GtkNnz+6ANLoiwJZzp2fDgYSD/m0tuKhy9r6vl81dURZH2vecgPmnNLi62MxqE5xSB/dk+woVX1Zp/3/NlFNyLjD1B4skl428PxjhA1AEJn9jY7edLUvXVwUFsUhahWLJPoTcJUmygfYwTzmxU1cTiixK/WMwZF9hI7sg7388139VtdFgYUS7XXVw+YpNyhA/pZ1CqtV2Fzf+BnzNhxXfZ+aDZujhQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DHG+LRaFbeTcZw3+pBmu7oB4em9qzWIaSHBy50ANp98=;
 b=NOoIfe2Wcg3i4bHS2LML+1DxGbIhB+1YL1gvh+kcqQucb+sQm9SSPZx2t7mqJjnflXerEDCq6SE3NlGh5IjRN+VnLo6eExO0TnyTh8brXZmHXUQhMnEbxmj1Xg90u+KmmM265rxlqI3eB/HPDa6cShqp0ZCtTPqVg0L/kQnRJnRYm5J0CgNjrkd0lTrxhxvu+DGiK1MC9OsiUf0mkLZoldKdqeAcx3fL+vCXFysd+2vgHEOAZB5ueRSH53Myj4f50/RhPZqFCrkX75TfeVHFt6fbD1op35pYMqye12rsNmLQ2XW5EkRVKqIoBTIg6ZCFHD5CDEJLeAVdHryvl0FQzQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass
 header.d=nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; 
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=DHG+LRaFbeTcZw3+pBmu7oB4em9qzWIaSHBy50ANp98=;
 b=BEKQ8cr5HnQb2IFaAt9PpjeB18L1RmRQHkWtn+GYZTuzdExnlvjg+1igvypk65lHXLOaJNPeQAkTOz7Od/T+eZaKInxkjEj6Gzbj5W8BN2XMbumKgbwwg0FedMj1/2BhU9NZ51bj+DFmpn146+0HVBbcDTclEvbGvKWx6FMWkSQ=
Received: from AM0PR04MB6356.eurprd04.prod.outlook.com (10.255.182.81) by
 AM0PR04MB4145.eurprd04.prod.outlook.com (52.134.90.138) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.2157.15; Wed, 7 Aug 2019 12:53:46 +0000
Received: from AM0PR04MB6356.eurprd04.prod.outlook.com
 ([fe80::25b3:79e7:7821:2943]) by AM0PR04MB6356.eurprd04.prod.outlook.com
 ([fe80::25b3:79e7:7821:2943%7]) with mapi id 15.20.2136.018; Wed, 7 Aug 2019
 12:53:46 +0000
From: Gagandeep Singh <G.Singh@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>, "Burakov, 
 Anatoly" <anatoly.burakov@intel.com>, Olivier Matz <olivier.matz@6wind.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, Nipun Gupta
 <nipun.gupta@nxp.com>
Thread-Topic: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4
Thread-Index: AdVNHj9/AhAZfjvsT6Gj7tUvv0gPag==
Date: Wed, 7 Aug 2019 12:53:46 +0000
Message-ID: <AM0PR04MB63566933179DA13F296B21D1E1D40@AM0PR04MB6356.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=G.Singh@nxp.com; 
x-originating-ip: [92.120.0.6]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 1ff79c0d-d4df-48af-3fd2-08d71b364913
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);
 SRVR:AM0PR04MB4145; 
x-ms-traffictypediagnostic: AM0PR04MB4145:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM0PR04MB4145618F530AC9B26DF8904FE1D40@AM0PR04MB4145.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 01221E3973
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(4636009)(136003)(346002)(396003)(366004)(39860400002)(376002)(189003)(199004)(66446008)(81166006)(102836004)(66946007)(14454004)(66476007)(486006)(476003)(64756008)(66556008)(2906002)(54906003)(76116006)(478600001)(99286004)(316002)(3846002)(256004)(8936002)(6116002)(6916009)(4326008)(25786009)(68736007)(81156014)(66066001)(33656002)(55016002)(5660300002)(26005)(7696005)(53546011)(6506007)(52536014)(9686003)(229853002)(6246003)(186003)(6436002)(53936002)(71200400001)(71190400001)(86362001)(8676002)(74316002)(7736002)(305945005);
 DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB4145;
 H:AM0PR04MB6356.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; MX:1; A:1; 
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: LVVN8EosWh6vQZxAfvNYEDX+mvD2G+HNxw1kt5mGNuIfyeAiiAwA5eOlsAS4B8HxiZF6+gbN0e+G3EilSkKhH2NlMY0629z25aS0aQQjirqr+DDvMxb4FtWHEZAz/XdJ4w/2HimHb41TeZT4hdZbdwV+2IvRYMMGzJJVsz+Sck2baUzTE/AIIgepKoXZ6puG0S2TXcmyIAN2VFQsXpgd2cSkdCvJwPGDaktPgzHZgtWk5vPTppa7JG1k+SGxkv22DL33Eo1sG/byvVCZAcbQzAa2YOfJc9entc33nZX+VyYmSNLuefpTBg+WMtYsodv1VPA8fHQsOcU04U/j2M+U5aJjxIOj+ZAXEyjtRscZlF2d2/DT68Pb457Pk+gUfmxI3gMm5A143lF341Mf+hBELDHQ2GC8/1bPWMOfvoN0Yug=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ff79c0d-d4df-48af-3fd2-08d71b364913
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2019 12:53:46.3487 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G.Singh@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4145
Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

> 07/08/2019 14:00, David Marchand:
> > On Wed, Aug 7, 2019 at 12:26 PM Gagandeep Singh <g.singh@nxp.com>
> wrote:
> > >
> > > DPDK currently is supporting maximum 3 hugepage,
> > > sizes whereas system can support more than this e.g.
> > > 64K, 2M, 32M and 1G.
> >
> > You can mention ARM platform here, and that this issue starts with
> > kernel 5.2 (and I would try to mention this in the title as well).
> > This is better than an annotation that will be lost.
> >
> >
> > > Having these four hugepage sizes available to use by DPDK,
> > > which is valid in case of '--in-memory' EAL option or
> > > using 4 separate mount points for each hugepage size;
> > > hugepage_info_init() API reports an error.
> >
> > Can you describe what is the impact from a user point of view rather
> > than mentioning this internal function?
>=20
> Yes please, we need to understand how much it is critical.

It is critical for stacks like VPP which uses by default in-memory.
There stack would be broken on kernel 5.2 and above.
I will change the description to make it clear.=20

> Should we Cc stable@dpdk.org for backport?
yes

> Should it be merged at the last minute in 19.08?
If this is the only change, that we need to do (i.e. no dynamic allocation)=
, then yes it can go.