From: Shahaf Shuler <shahafs@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Jan Viktorin <viktorin@rehivetech.com>,
Gavin Hu <gavin.hu@arm.com>,
Chao Zhu <chaozhu@linux.vnet.ibm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: remove redundant API description
Date: Wed, 20 Mar 2019 06:46:36 +0000 [thread overview]
Message-ID: <AM0PR0502MB37953A97DCBB2E349111BBAEC3410@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20190319211601.31983-1-thomas@monjalon.net>
Tuesday, March 19, 2019 11:16 PM, Thomas Monjalon:
> Subject: [dpdk-dev] [PATCH] eal: remove redundant API description
>
> Atomic functions are described in doxygen of the file
> lib/librte_eal/common/include/generic/rte_atomic.h
> The copies in arch-specific files are redundant and confuse readers about the
> genericity of the API.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> .../common/include/arch/arm/rte_atomic_32.h | 18 ------------------
> .../common/include/arch/ppc_64/rte_atomic.h | 18 ------------------
> .../common/include/generic/rte_atomic.h | 3 ---
> 3 files changed, 39 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h
> b/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h
> index 859562e59..7dc0d06d1 100644
> --- a/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h
> +++ b/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h
> @@ -15,28 +15,10 @@ extern "C" {
>
> #include "generic/rte_atomic.h"
>
> -/**
> - * General memory barrier.
> - *
> - * Guarantees that the LOAD and STORE operations generated before the
> - * barrier occur before the LOAD and STORE operations generated after.
> - */
> #define rte_mb() __sync_synchronize()
>
> -/**
> - * Write memory barrier.
> - *
> - * Guarantees that the STORE operations generated before the barrier
> - * occur before the STORE operations generated after.
> - */
> #define rte_wmb() do { asm volatile ("dmb st" : : : "memory"); } while
> (0)
>
> -/**
> - * Read memory barrier.
> - *
> - * Guarantees that the LOAD operations generated before the barrier
> - * occur before the LOAD operations generated after.
> - */
> #define rte_rmb() __sync_synchronize()
>
> #define rte_smp_mb() rte_mb()
> diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> index ce38350bd..2dd59fd78 100644
> --- a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> @@ -49,32 +49,14 @@ extern "C" {
> #include <stdint.h>
> #include "generic/rte_atomic.h"
>
> -/**
> - * General memory barrier.
> - *
> - * Guarantees that the LOAD and STORE operations generated before the
> - * barrier occur before the LOAD and STORE operations generated after.
> - */
> #define rte_mb() asm volatile("sync" : : : "memory")
>
> -/**
> - * Write memory barrier.
> - *
> - * Guarantees that the STORE operations generated before the barrier
> - * occur before the STORE operations generated after.
> - */
> #ifdef RTE_ARCH_64
> #define rte_wmb() asm volatile("lwsync" : : : "memory")
> #else
> #define rte_wmb() asm volatile("sync" : : : "memory")
> #endif
>
> -/**
> - * Read memory barrier.
> - *
> - * Guarantees that the LOAD operations generated before the barrier
> - * occur before the LOAD operations generated after.
> - */
> #ifdef RTE_ARCH_64
> #define rte_rmb() asm volatile("lwsync" : : : "memory")
> #else
> diff --git a/lib/librte_eal/common/include/generic/rte_atomic.h
> b/lib/librte_eal/common/include/generic/rte_atomic.h
> index 4afd1acc3..e91742702 100644
> --- a/lib/librte_eal/common/include/generic/rte_atomic.h
> +++ b/lib/librte_eal/common/include/generic/rte_atomic.h
> @@ -25,7 +25,6 @@
> *
> * Guarantees that the LOAD and STORE operations generated before the
> * barrier occur before the LOAD and STORE operations generated after.
> - * This function is architecture dependent.
> */
> static inline void rte_mb(void);
>
> @@ -34,7 +33,6 @@ static inline void rte_mb(void);
> *
> * Guarantees that the STORE operations generated before the barrier
> * occur before the STORE operations generated after.
> - * This function is architecture dependent.
> */
> static inline void rte_wmb(void);
>
> @@ -43,7 +41,6 @@ static inline void rte_wmb(void);
> *
> * Guarantees that the LOAD operations generated before the barrier
> * occur before the LOAD operations generated after.
> - * This function is architecture dependent.
> */
> static inline void rte_rmb(void);
> ///@}
> --
> 2.20.1
next prev parent reply other threads:[~2019-03-20 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 21:16 Thomas Monjalon
2019-03-19 21:16 ` Thomas Monjalon
2019-03-20 6:46 ` Shahaf Shuler [this message]
2019-03-20 6:46 ` Shahaf Shuler
2019-03-28 22:53 ` Thomas Monjalon
2019-03-28 22:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB37953A97DCBB2E349111BBAEC3410@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).