From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <shahafs@mellanox.com> Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150085.outbound.protection.outlook.com [40.107.15.85]) by dpdk.org (Postfix) with ESMTP id B2510316B for <dev@dpdk.org>; Tue, 2 Apr 2019 07:39:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UC8c30HqO8f7MIAkb3tITJT23ujlIL4yl2f8moPbwcg=; b=Yktytzp7ZZrpsLV986B9MiXJ08Ajivo86/YlC3vQY3T4d97RERioeLzzI7Q0vZ/GDqmR4DZEnYuhcS1FI95KIhT0ekeN2/OZUKR9dFJIvmZNgHSRs69plpx+DLmA/E4d0iJ0ug935rT1KvYp/Hel3oqmanidPLGGD+K5sXSFwLI= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3940.eurprd05.prod.outlook.com (52.133.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Tue, 2 Apr 2019 05:39:46 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1750.014; Tue, 2 Apr 2019 05:39:46 +0000 From: Shahaf Shuler <shahafs@mellanox.com> To: Yongseok Koh <yskoh@mellanox.com> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH v2 1/3] net/mlx5: fix recursive inclusion of header file Thread-Index: AQHU6NEIp22dy4ecNEer4ui+cgZu5KYoWzQQ Date: Tue, 2 Apr 2019 05:39:46 +0000 Message-ID: <AM0PR0502MB379542F69FF5C421B8A4D9FEC3560@AM0PR0502MB3795.eurprd05.prod.outlook.com> References: <20190325193627.19726-1-yskoh@mellanox.com> <20190401212225.26380-1-yskoh@mellanox.com> <20190401212225.26380-2-yskoh@mellanox.com> In-Reply-To: <20190401212225.26380-2-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28cddb31-ad35-4ea6-2127-08d6b72d9d72 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR0502MB3940; x-ms-traffictypediagnostic: AM0PR0502MB3940: x-microsoft-antispam-prvs: <AM0PR0502MB3940386D07D70A0B14908840C3560@AM0PR0502MB3940.eurprd05.prod.outlook.com> x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(366004)(346002)(376002)(396003)(189003)(199004)(105586002)(305945005)(6246003)(4326008)(6862004)(5660300002)(106356001)(8936002)(52536014)(81166006)(2906002)(6116002)(74316002)(68736007)(186003)(66066001)(97736004)(7736002)(8676002)(99286004)(3846002)(6636002)(229853002)(11346002)(86362001)(33656002)(6436002)(25786009)(7696005)(6506007)(76176011)(81156014)(14454004)(26005)(316002)(9686003)(478600001)(102836004)(476003)(71190400001)(53936002)(446003)(55016002)(71200400001)(256004)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3940; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: W7Y/LA96nNpSlQTIG5EElEDi10/sLGTZsGW5Emk2G9fFm/6X0SJUTlOBL2K7wtETaYdnr82R/AC2uiNEKOuPXsoADTIYa9DBHUCf3cTxaw0KcR9zp/Bf1NPJVY+0dxDKC013NP8p+P/nzglL9FsqvEiuWREQEe+VpGskn8ugTwewoV72FJ+m0O+hKfG2KsdwW7/97lw8BVNaLjPJhNswxo+i9kutiUL6SPnNJBGE+eU4GDuGQy+O6QAwo66daqXTUPSiWl1hXcabSAG567ErYRXX/To1j6Xm6erQwXenyo2bvQrH0Ak93Fh8/bV7yYRxx3rLiABam5oNkwO4Z6L+ykGkgkRypSA2ovdrNxMsHMI5PPn+qfU7MZ6Zku6+I0LXkl4qzYgrE8icAKYIj8XKLLk12xaxzgjTkYmVIdj7Zd0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28cddb31-ad35-4ea6-2127-08d6b72d9d72 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 05:39:46.0826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3940 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix recursive inclusion of header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 02 Apr 2019 05:39:47 -0000 Tuesday, April 2, 2019 12:22 AM, Yongseok Koh: > Subject: [PATCH v2 1/3] net/mlx5: fix recursive inclusion of header file >=20 > mlx5.h includes mlx5_rxtx.h and mlx5_rxtx.h includes mlx5.h recursively. >=20 > Signed-off-by: Yongseok Koh <yskoh@mellanox.com> Acked-by: Shahaf Shuler <shahafs@mellanox.com> > --- > drivers/net/mlx5/mlx5.h | 1 - > drivers/net/mlx5/mlx5_flow.c | 5 +++-- > drivers/net/mlx5/mlx5_flow_dv.c | 3 ++- > drivers/net/mlx5/mlx5_flow_verbs.c | 5 +++-- > drivers/net/mlx5/mlx5_vlan.c | 3 ++- > 5 files changed, 10 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > 47a7d75f7a..8ce8361a85 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -33,7 +33,6 @@ >=20 > #include "mlx5_utils.h" > #include "mlx5_mr.h" > -#include "mlx5_rxtx.h" > #include "mlx5_autoconf.h" > #include "mlx5_defs.h" >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index bc6a7c1eba..3eb8bf0c83 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -30,9 +30,10 @@ >=20 > #include "mlx5.h" > #include "mlx5_defs.h" > -#include "mlx5_prm.h" > -#include "mlx5_glue.h" > #include "mlx5_flow.h" > +#include "mlx5_glue.h" > +#include "mlx5_prm.h" > +#include "mlx5_rxtx.h" >=20 > /* Dev ops structure defined in mlx5.c */ extern const struct eth_dev_o= ps > mlx5_dev_ops; diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 966dad9838..3e0a64ec4b 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -29,9 +29,10 @@ >=20 > #include "mlx5.h" > #include "mlx5_defs.h" > -#include "mlx5_prm.h" > #include "mlx5_glue.h" > #include "mlx5_flow.h" > +#include "mlx5_prm.h" > +#include "mlx5_rxtx.h" >=20 > #ifdef HAVE_IBV_FLOW_DV_SUPPORT >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c > b/drivers/net/mlx5/mlx5_flow_verbs.c > index 49dd13e6d2..3956df1a7e 100644 > --- a/drivers/net/mlx5/mlx5_flow_verbs.c > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c > @@ -29,9 +29,10 @@ >=20 > #include "mlx5.h" > #include "mlx5_defs.h" > -#include "mlx5_prm.h" > -#include "mlx5_glue.h" > #include "mlx5_flow.h" > +#include "mlx5_glue.h" > +#include "mlx5_prm.h" > +#include "mlx5_rxtx.h" >=20 > #define VERBS_SPEC_INNER(item_flags) \ > (!!((item_flags) & MLX5_FLOW_LAYER_TUNNEL) ? > IBV_FLOW_SPEC_INNER : 0) diff --git a/drivers/net/mlx5/mlx5_vlan.c > b/drivers/net/mlx5/mlx5_vlan.c index 6568a3a475..4004930942 100644 > --- a/drivers/net/mlx5/mlx5_vlan.c > +++ b/drivers/net/mlx5/mlx5_vlan.c > @@ -27,10 +27,11 @@ > #include <rte_ethdev_driver.h> > #include <rte_common.h> >=20 > -#include "mlx5_utils.h" > #include "mlx5.h" > #include "mlx5_autoconf.h" > #include "mlx5_glue.h" > +#include "mlx5_rxtx.h" > +#include "mlx5_utils.h" >=20 > /** > * DPDK callback to configure a VLAN filter. > -- > 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BC98CA0679 for <public@inbox.dpdk.org>; Tue, 2 Apr 2019 07:39:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B2B5343C; Tue, 2 Apr 2019 07:39:48 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150085.outbound.protection.outlook.com [40.107.15.85]) by dpdk.org (Postfix) with ESMTP id B2510316B for <dev@dpdk.org>; Tue, 2 Apr 2019 07:39:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UC8c30HqO8f7MIAkb3tITJT23ujlIL4yl2f8moPbwcg=; b=Yktytzp7ZZrpsLV986B9MiXJ08Ajivo86/YlC3vQY3T4d97RERioeLzzI7Q0vZ/GDqmR4DZEnYuhcS1FI95KIhT0ekeN2/OZUKR9dFJIvmZNgHSRs69plpx+DLmA/E4d0iJ0ug935rT1KvYp/Hel3oqmanidPLGGD+K5sXSFwLI= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3940.eurprd05.prod.outlook.com (52.133.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Tue, 2 Apr 2019 05:39:46 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1750.014; Tue, 2 Apr 2019 05:39:46 +0000 From: Shahaf Shuler <shahafs@mellanox.com> To: Yongseok Koh <yskoh@mellanox.com> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH v2 1/3] net/mlx5: fix recursive inclusion of header file Thread-Index: AQHU6NEIp22dy4ecNEer4ui+cgZu5KYoWzQQ Date: Tue, 2 Apr 2019 05:39:46 +0000 Message-ID: <AM0PR0502MB379542F69FF5C421B8A4D9FEC3560@AM0PR0502MB3795.eurprd05.prod.outlook.com> References: <20190325193627.19726-1-yskoh@mellanox.com> <20190401212225.26380-1-yskoh@mellanox.com> <20190401212225.26380-2-yskoh@mellanox.com> In-Reply-To: <20190401212225.26380-2-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28cddb31-ad35-4ea6-2127-08d6b72d9d72 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR0502MB3940; x-ms-traffictypediagnostic: AM0PR0502MB3940: x-microsoft-antispam-prvs: <AM0PR0502MB3940386D07D70A0B14908840C3560@AM0PR0502MB3940.eurprd05.prod.outlook.com> x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(366004)(346002)(376002)(396003)(189003)(199004)(105586002)(305945005)(6246003)(4326008)(6862004)(5660300002)(106356001)(8936002)(52536014)(81166006)(2906002)(6116002)(74316002)(68736007)(186003)(66066001)(97736004)(7736002)(8676002)(99286004)(3846002)(6636002)(229853002)(11346002)(86362001)(33656002)(6436002)(25786009)(7696005)(6506007)(76176011)(81156014)(14454004)(26005)(316002)(9686003)(478600001)(102836004)(476003)(71190400001)(53936002)(446003)(55016002)(71200400001)(256004)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3940; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: W7Y/LA96nNpSlQTIG5EElEDi10/sLGTZsGW5Emk2G9fFm/6X0SJUTlOBL2K7wtETaYdnr82R/AC2uiNEKOuPXsoADTIYa9DBHUCf3cTxaw0KcR9zp/Bf1NPJVY+0dxDKC013NP8p+P/nzglL9FsqvEiuWREQEe+VpGskn8ugTwewoV72FJ+m0O+hKfG2KsdwW7/97lw8BVNaLjPJhNswxo+i9kutiUL6SPnNJBGE+eU4GDuGQy+O6QAwo66daqXTUPSiWl1hXcabSAG567ErYRXX/To1j6Xm6erQwXenyo2bvQrH0Ak93Fh8/bV7yYRxx3rLiABam5oNkwO4Z6L+ykGkgkRypSA2ovdrNxMsHMI5PPn+qfU7MZ6Zku6+I0LXkl4qzYgrE8icAKYIj8XKLLk12xaxzgjTkYmVIdj7Zd0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28cddb31-ad35-4ea6-2127-08d6b72d9d72 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 05:39:46.0826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3940 Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/mlx5: fix recursive inclusion of header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190402053946.PPmg8IMACyb5HDQfuLMO4DsTmwti5SKliH6qmoXxaIE@z> Tuesday, April 2, 2019 12:22 AM, Yongseok Koh: > Subject: [PATCH v2 1/3] net/mlx5: fix recursive inclusion of header file >=20 > mlx5.h includes mlx5_rxtx.h and mlx5_rxtx.h includes mlx5.h recursively. >=20 > Signed-off-by: Yongseok Koh <yskoh@mellanox.com> Acked-by: Shahaf Shuler <shahafs@mellanox.com> > --- > drivers/net/mlx5/mlx5.h | 1 - > drivers/net/mlx5/mlx5_flow.c | 5 +++-- > drivers/net/mlx5/mlx5_flow_dv.c | 3 ++- > drivers/net/mlx5/mlx5_flow_verbs.c | 5 +++-- > drivers/net/mlx5/mlx5_vlan.c | 3 ++- > 5 files changed, 10 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > 47a7d75f7a..8ce8361a85 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -33,7 +33,6 @@ >=20 > #include "mlx5_utils.h" > #include "mlx5_mr.h" > -#include "mlx5_rxtx.h" > #include "mlx5_autoconf.h" > #include "mlx5_defs.h" >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index bc6a7c1eba..3eb8bf0c83 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -30,9 +30,10 @@ >=20 > #include "mlx5.h" > #include "mlx5_defs.h" > -#include "mlx5_prm.h" > -#include "mlx5_glue.h" > #include "mlx5_flow.h" > +#include "mlx5_glue.h" > +#include "mlx5_prm.h" > +#include "mlx5_rxtx.h" >=20 > /* Dev ops structure defined in mlx5.c */ extern const struct eth_dev_o= ps > mlx5_dev_ops; diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 966dad9838..3e0a64ec4b 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -29,9 +29,10 @@ >=20 > #include "mlx5.h" > #include "mlx5_defs.h" > -#include "mlx5_prm.h" > #include "mlx5_glue.h" > #include "mlx5_flow.h" > +#include "mlx5_prm.h" > +#include "mlx5_rxtx.h" >=20 > #ifdef HAVE_IBV_FLOW_DV_SUPPORT >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c > b/drivers/net/mlx5/mlx5_flow_verbs.c > index 49dd13e6d2..3956df1a7e 100644 > --- a/drivers/net/mlx5/mlx5_flow_verbs.c > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c > @@ -29,9 +29,10 @@ >=20 > #include "mlx5.h" > #include "mlx5_defs.h" > -#include "mlx5_prm.h" > -#include "mlx5_glue.h" > #include "mlx5_flow.h" > +#include "mlx5_glue.h" > +#include "mlx5_prm.h" > +#include "mlx5_rxtx.h" >=20 > #define VERBS_SPEC_INNER(item_flags) \ > (!!((item_flags) & MLX5_FLOW_LAYER_TUNNEL) ? > IBV_FLOW_SPEC_INNER : 0) diff --git a/drivers/net/mlx5/mlx5_vlan.c > b/drivers/net/mlx5/mlx5_vlan.c index 6568a3a475..4004930942 100644 > --- a/drivers/net/mlx5/mlx5_vlan.c > +++ b/drivers/net/mlx5/mlx5_vlan.c > @@ -27,10 +27,11 @@ > #include <rte_ethdev_driver.h> > #include <rte_common.h> >=20 > -#include "mlx5_utils.h" > #include "mlx5.h" > #include "mlx5_autoconf.h" > #include "mlx5_glue.h" > +#include "mlx5_rxtx.h" > +#include "mlx5_utils.h" >=20 > /** > * DPDK callback to configure a VLAN filter. > -- > 2.11.0