From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130083.outbound.protection.outlook.com [40.107.13.83]) by dpdk.org (Postfix) with ESMTP id 381832BA7; Tue, 5 Mar 2019 09:19:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wErPWF8ogT5JhthKU+PWwINpouJ3uUehfgr51gXhw0Y=; b=I9nOQYGXhvOW2C2J62qO8SYvtU3gb9cU2yD6qQXGxaGflTHq5zMeEkVH7CVKzKj7RH+oS6IwSwQkGLAj+SFVgAubuQ0BFbjzfeRec1ZKG1bSQE+ZV9uPu5p22V5wr7myk5yztsjPFSGXaeaclWOTtTJijbyULi1f2ZySzIAJNjU= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0SPR01MB010.eurprd05.prod.outlook.com (52.133.36.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Tue, 5 Mar 2019 08:19:27 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1665.017; Tue, 5 Mar 2019 08:19:27 +0000 From: Shahaf Shuler To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Matan Azrad Thread-Topic: [PATCH 06/12] net/mlx4: fix incorrect rxq errors stat Thread-Index: AQHU0nwZPXYtpBViTESI96mQjpzKtKX8svxw Date: Tue, 5 Mar 2019 08:19:27 +0000 Message-ID: References: <1551698315-2611-1-git-send-email-david.marchand@redhat.com> <1551698315-2611-7-git-send-email-david.marchand@redhat.com> In-Reply-To: <1551698315-2611-7-git-send-email-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7ea7d9c9-509f-4069-444a-08d6a14348fb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0SPR01MB010; x-ms-traffictypediagnostic: AM0SPR01MB010: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; AM0SPR01MB010; 23:nuLK1155gDhbqkFjP9gdkBCsfFVekNL1kU/RrK2h8?= =?us-ascii?Q?55KPQAktOtX853accqn3s/vEBqtGREDTUeheJhdvFBwI8Nng/5c4nO8Ss8YF?= =?us-ascii?Q?It/pVOInsGr54G5XISEog1tL0oVhVQcRODylhg4iF46rqHZ2nPewsSF6m5Iu?= =?us-ascii?Q?xUPT4cqGzENck2rarSz8II62DlLtfMewq73SxPRfthqAq1w3uquQuKArcB+0?= =?us-ascii?Q?HZHlIs8d6WWe1E8L+Etc5lKNLugvL68GkyHTr9nDrExWxXVsJiEZLVjFp7DM?= =?us-ascii?Q?OX+uwHR9VHIwXk4WDDCD8k8O4XvesDKYzeaVNvcf7ZS3SqeW31ETNltEYxc7?= =?us-ascii?Q?PhpEqU1AfkjJTNPhI34khw/bDAoclHimIy24G9kbzYaExPdsUAKaBP1NbUJp?= =?us-ascii?Q?xmcIlflXFnYmtIN9g0RtQzwDF94yR3aTREYsCbs40cVJzZSLMTDeoqj7jDMI?= =?us-ascii?Q?CoOerzNhpUUpr+D5k0ftaExL6XOK9nqeYHpINCZegZKkR3Ae/T+QBoBDk3Q+?= =?us-ascii?Q?wkOAPGrAEcNy8Pd3hfxa3wqgRt1PPOiiQaMz5CMmYJZsF9mP4czaC1J51r22?= =?us-ascii?Q?Z3IMGqqsMc/Fj3dx84VOxyeYtMnh7gzmQtFjl3OKYH3r49Ppieijs4lUsIl7?= =?us-ascii?Q?pkuqF60tsPQnA6+nWjU7yOEN3GEQ0aM8fSUSHPsR1ve1WxjyU4JURzQnoSmB?= =?us-ascii?Q?06evoci8gAQB87XASD46Eg6SwA35xOcVi05Ghij4plTHDK9Gth7+EktBEuGD?= =?us-ascii?Q?8ihWBIb0/jmxx7TuzjMADtpjeX/VKn4b4OI+wmmCYHYiBLFQ2VYQe81oBdcB?= =?us-ascii?Q?yQpDbSTX8fhQe+Sh+Qqakvogws/z9IK4kFcxQ7K2/VuZo2Tb0LGWxQYdXD1/?= =?us-ascii?Q?yZCVV0xoC9nURHz8GceTs2FWVHQx4Izej4eD3KiSMfpBM8TrXV/BYpjBWOht?= =?us-ascii?Q?Muz2mEt6cFaWC6Sqr+Waj71c7f4qHhLNBfd5r925i9wwM4YTrNze+PlFid+r?= =?us-ascii?Q?xqIWbgnBI4xiRFCZvCo9iEMhUG1Hizhy1Am2eyt2lkIC/rTAVLhdUv/RweWB?= =?us-ascii?Q?WYS1ZWGFWH6HAQYjkCRo5imJABoMgchVLTBubIeF8MOFrBAxw7B+bjD8/ybb?= =?us-ascii?Q?MbGW4bwDsmyv3HZsKQSI6htf4lP/DxKHzalNzZoFIetGme+yLsU5XioVylrw?= =?us-ascii?Q?fUEWcUgR5GcNrtZJd/u/rtOJfrXbwTUHGMDT88+bKV6UvLRdOIA+vbXuSX3T?= =?us-ascii?Q?+bU0H4PowkoqnGEPFBRK8iHiE00h78RtpMLytJ5JLcZZmnt3howvuYbla8Dq?= =?us-ascii?B?QT09?= x-microsoft-antispam-prvs: x-forefront-prvs: 0967749BC1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(39860400002)(396003)(376002)(366004)(189003)(199004)(6116002)(3846002)(446003)(106356001)(105586002)(256004)(14444005)(33656002)(11346002)(486006)(476003)(478600001)(107886003)(14454004)(66066001)(4326008)(9686003)(55016002)(99286004)(2501003)(8936002)(68736007)(6436002)(25786009)(6246003)(229853002)(26005)(76176011)(7696005)(186003)(102836004)(6506007)(53936002)(8676002)(305945005)(316002)(54906003)(81166006)(4744005)(81156014)(74316002)(5660300002)(86362001)(110136005)(71200400001)(71190400001)(7736002)(52536013)(97736004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0SPR01MB010; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 4sc67DXhSQ1IFFl8lJcgOwOEzjmjjdsuWLDwtG9I+CNmtEflvoD1y5G2gkfSCkrwoO5nQ967jyVW14KVRbL7USR4YCj6kwxLAJAPcLzsDsxl6sw3/GQdCA3VGKLkhLYMjQp3XChldt90nSLirkvwPKRMdTrNegl13xatVpsAOKWksHRbvB50ZiSGcHpb1DkQTsM4sw18rVe+S7AnE3Jy/vteUYX6aApZHPCI7IMnA5xgeXjJ7h1EV9Q1FJWke+l9agqD4rNZY2smQO+D6rCizd2w4cQwEkVlJDFa6jkNX+7hLSYdhaiNgQUA0V9cUjNyqAU5gldEsyE2nKgf/v1KiDCtddDpwoEmw3Yf1dlEUo4HZM5QtxA7KKOqaaE+vVEPmjvjvcPf1yrYxDE8dD0hDt7d/0j6Ot9LskKHgLOyKtM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea7d9c9-509f-4069-444a-08d6a14348fb X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 08:19:27.7070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0SPR01MB010 Subject: Re: [dpdk-dev] [PATCH 06/12] net/mlx4: fix incorrect rxq errors stat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 08:19:29 -0000 Monday, March 4, 2019 1:18 PM, David Marchand: > Subject: [PATCH 06/12] net/mlx4: fix incorrect rxq errors stat >=20 > Transmit errors must not be reported in q_errors[] which is for reception= . >=20 > Fixes: 7fae69eeff13 ("mlx4: new poll mode driver") > Cc: stable@dpdk.org > Cc: Matan Azrad > Cc: Shahaf Shuler > Signed-off-by: David Marchand > --- > drivers/net/mlx4/mlx4_ethdev.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/mlx4/mlx4_ethdev.c > b/drivers/net/mlx4/mlx4_ethdev.c index 4dae67a..41c46d3 100644 > --- a/drivers/net/mlx4/mlx4_ethdev.c > +++ b/drivers/net/mlx4/mlx4_ethdev.c > @@ -661,7 +661,6 @@ int mlx4_fw_version_get(struct rte_eth_dev *dev, > char *fw_ver, size_t fw_size) > if (idx < RTE_ETHDEV_QUEUE_STAT_CNTRS) { > tmp.q_opackets[idx] +=3D txq->stats.opackets; > tmp.q_obytes[idx] +=3D txq->stats.obytes; > - tmp.q_errors[idx] +=3D txq->stats.odropped; > } > tmp.opackets +=3D txq->stats.opackets; > tmp.obytes +=3D txq->stats.obytes; Acked-by: Shahaf Shuler > -- > 1.8.3.1