From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40066.outbound.protection.outlook.com [40.107.4.66]) by dpdk.org (Postfix) with ESMTP id C78B22BA3; Tue, 5 Mar 2019 09:18:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98O4DfOkXj9cChwnjh0V3VDd1xbyMpw5aIFcJ8KtIZY=; b=LVepIWUwlLnMvLUZESTenGwt8dKGoO2hB36IYJfLktw2A/QenEyRDxyIwbQKYJR76BvmOE1viPhfnlgwm3xXxJsSI0M9NUEMYTPXd92xtMP8kFDdQhs4jIqMhr4+LbiE/gHn3GaccFGFh7LJn5KUi6if+/G6XpFD01907ur1Y4A= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0SPR01MB010.eurprd05.prod.outlook.com (52.133.36.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Tue, 5 Mar 2019 08:18:10 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1665.017; Tue, 5 Mar 2019 08:18:10 +0000 From: Shahaf Shuler To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , Yongseok Koh Thread-Topic: [PATCH 07/12] net/mlx5: fix incorrect rxq errors stat Thread-Index: AQHU0nwbGVPQ6dd7N0GiWIsmtcN+XqX8ss4A Date: Tue, 5 Mar 2019 08:18:10 +0000 Message-ID: References: <1551698315-2611-1-git-send-email-david.marchand@redhat.com> <1551698315-2611-8-git-send-email-david.marchand@redhat.com> In-Reply-To: <1551698315-2611-8-git-send-email-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e0ba1938-e1ad-4697-bcd3-08d6a1431af0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0SPR01MB010; x-ms-traffictypediagnostic: AM0SPR01MB010: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; AM0SPR01MB010; 23:z/MJQgZZpuDOfxy5Cb8bKkmfELBAZ5HL2ycodlvFq?= =?us-ascii?Q?vLqJ/8SciOn0sqgSpws5wnhI8F8zR7AjCvLb3f+Uwl5qIN9z/Es1byyXk57i?= =?us-ascii?Q?SEae9Vr2twPAV5mFoaLz+u9JSRBOYu4y7NTMC85PwnJhRE3nU+rB3qexZ5pJ?= =?us-ascii?Q?mSlMO2+XNhbFGXRRYRzgCIamvaiXk4ScppY//xJ3txwVKd8ec1jWZl85sJgw?= =?us-ascii?Q?dtfpe4oRRYC0Gdf16MdZOE8lbmkYHDdxKNGhf44VSJclvuZAdj1ghUexYx8B?= =?us-ascii?Q?y8kFQOJ3W5TXZVJsL5iPGoshjKJLcmfGcOPfNj1E39a3XfaDzokuT2Ywx47d?= =?us-ascii?Q?I5yF0b7MdWEapWr20QY5u7qXGff7cVJMX0fDtEeJL5NIk7ocf32ti+OVkfKG?= =?us-ascii?Q?0LS46KDb9F9k5YodL4jSHBjChxIav2KY+Z62u5AsQVh1T6vTMNHiSe23OyGP?= =?us-ascii?Q?O/baQCfTrmtigSTYgEh1yr6XYpSibm+1qQ1EuLnv4S8YQWykqQovC6s2p5mf?= =?us-ascii?Q?0Rtmpt51PuuUKxW5D81MABfazPO4EAExvzK2DIQ1Ncexq8qG4bywtVZYXL46?= =?us-ascii?Q?UhiryKb+6WL0nXC9EvyJmn51G1He7GamixauEkV/9Z57gpN8uHYaYFcvC66l?= =?us-ascii?Q?66DXzEwwP5kfv0ibNnRk0qa+YwdKR/BwSqRtNvm1E8tzzFIk4uE1axmVdQgs?= =?us-ascii?Q?XcOi0JqN+IK+wMdB+pNfEESCTE5ac9LoPBUQXHKruZ0scj+iKwZ4JqG4Vbjg?= =?us-ascii?Q?WYvtk+WKeNgI+ixj28Bh0bDEIKrozngIV7rYKC2LOoRZA3zkHAAfMLlJyoqE?= =?us-ascii?Q?5jIVuG4AAdnoEe288uppaQNSo+M6l7im4gvFdma16J7LyJA69MnSt1OMTfue?= =?us-ascii?Q?i+5IJBhBSamgHxMuPNHZqDKJ8shochF496zQojzqHHWw9vwxKk9fxN7jcVyC?= =?us-ascii?Q?b0tsq9fA/k+iwCrJQS3HAruDOE2FR1xSwPlHss5AwQQRM1NiVF1MbeP6mh6h?= =?us-ascii?Q?6YHX/uTXDWSCHDlgaIih9N3afiJZGywYtHgSIlohFbM1mLvNau84cgZyCQoW?= =?us-ascii?Q?QKQ79K15PgTw1uU03TeXd6FDGDyek1rOZkXM6QJ7jp87j9z5HZEZ+erTDBSd?= =?us-ascii?Q?dMYEdIOxc5SmUTPQXsb6kZSK/ZWhyKceqni/dF1LOeLJTgPXftWTVApOU6Pc?= =?us-ascii?Q?KhxNcaXhfAS+T12Tf08o9wSIfL4G3sL8bn8MSLkVFzkS4MderQd36thGFFrA?= =?us-ascii?Q?K9htaxh8GfdbbuhHiAaGX73DzLUH/NDqe9frnwkk1D2pb4LHgtyJLFg+KhCf?= =?us-ascii?B?QT09?= x-microsoft-antispam-prvs: x-forefront-prvs: 0967749BC1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(39860400002)(396003)(376002)(366004)(189003)(199004)(6116002)(3846002)(446003)(106356001)(105586002)(256004)(14444005)(33656002)(11346002)(486006)(476003)(478600001)(107886003)(14454004)(66066001)(4326008)(9686003)(55016002)(99286004)(2501003)(8936002)(68736007)(6436002)(25786009)(6246003)(229853002)(26005)(76176011)(7696005)(186003)(102836004)(6506007)(53936002)(8676002)(305945005)(316002)(54906003)(81166006)(4744005)(81156014)(74316002)(5660300002)(86362001)(110136005)(71200400001)(71190400001)(7736002)(52536013)(97736004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0SPR01MB010; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 4rHcxu52XZ5I2gPgY1oVRnyvXc5IWog6259DGew1AaTJOWwcXHn2qDcMibLklr2mTIWFI5aq6QfSBYnCDRRYvWO5X1sgogmJIe/mvwpTH82UfnlDtQZn1kM2zMGjVR67C9CDuccUk4easPqi5CKy0SbHm0+92U7Y/e3GnGHxVTpdMZ6QEExK8uX2XnCmF1Rm2glh6w9qYZkh1G9dYP/agUOq/9kWLx/+Tq1qKlVJx3oxsN2FEoNNjRZ+IJzK3pc9s/OYi+xl6D9b9wnWFRXAoS+XhWGsQZhVybgT4+M75qwZEw8uPfkchlf//bclREY9wRlPanWjgsngn4L7tmuxqXx7jXmZ/7DEE4Key9IxCsq/Lxk4Vt7W5fkLOyGUlfrG/F4+kNmuA+DP9ZlPO2CVr4FVO/1foiwCcjEBo+skozk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0ba1938-e1ad-4697-bcd3-08d6a1431af0 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 08:18:10.4818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0SPR01MB010 Subject: Re: [dpdk-dev] [PATCH 07/12] net/mlx5: fix incorrect rxq errors stat X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 08:18:14 -0000 Monday, March 4, 2019 1:19 PM, David Marchand: > Subject: [PATCH 07/12] net/mlx5: fix incorrect rxq errors stat >=20 > Transmit errors must not be reported in q_errors[] which is for reception= . >=20 > Fixes: 87011737b715 ("mlx5: add software counters") > Fixes: 9f9a48eb2978 ("net/mlx5: fix Tx stats error counter definition") > Cc: stable@dpdk.org > Cc: Shahaf Shuler > Cc: Yongseok Koh > Signed-off-by: David Marchand > --- > drivers/net/mlx5/mlx5_stats.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.= c > index 6906dc8..ef7bc14 100644 > --- a/drivers/net/mlx5/mlx5_stats.c > +++ b/drivers/net/mlx5/mlx5_stats.c > @@ -409,7 +409,6 @@ > tmp.q_opackets[idx] +=3D txq->stats.opackets; > tmp.q_obytes[idx] +=3D txq->stats.obytes; #endif > - tmp.q_errors[idx] +=3D txq->stats.oerrors; > } > #ifdef MLX5_PMD_SOFT_COUNTERS > tmp.opackets +=3D txq->stats.opackets; > -- > 1.8.3.1 Acked-by: Shahaf Shuler