From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20063.outbound.protection.outlook.com [40.107.2.63]) by dpdk.org (Postfix) with ESMTP id 53F764CA0 for ; Wed, 8 May 2019 06:44:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q92Tp/Wx+bqqSHUIjVMRO8sVifa0Z5/+GldhMU/rlYc=; b=mUTShr0gl9PNImREeykUqL7Zmj3zVHPzeMoui4u8EinwX7NBBZkDzKfbasQL1ZsrDwviwg7+3fZunzMvMbG6E/TTzABXoaU6NVkmrEyOABxxsQ5bZMxZazqQSYXbE6sW2wsIJWGlSi9ybXS3KyKsvtiejseeRARarLyHfnkz9dY= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Wed, 8 May 2019 04:44:22 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d%7]) with mapi id 15.20.1856.012; Wed, 8 May 2019 04:44:22 +0000 From: Shahaf Shuler To: Ori Kam , Yongseok Koh , Matan Azrad CC: "dev@dpdk.org" , Ori Kam Thread-Topic: [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules Thread-Index: AQHVBNqqzokYTeKBFkCA8oLYw6fvlqZgoqHg Date: Wed, 8 May 2019 04:44:22 +0000 Message-ID: References: <1557236494-4808-1-git-send-email-orika@mellanox.com> In-Reply-To: <1557236494-4808-1-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1cc709d-137d-49f3-4b7f-08d6d36fd70e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4001; x-ms-traffictypediagnostic: AM0PR0502MB4001: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 0031A0FFAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(396003)(39860400002)(136003)(199004)(189003)(305945005)(26005)(55016002)(66946007)(2906002)(73956011)(76116006)(25786009)(110136005)(7736002)(316002)(54906003)(33656002)(7696005)(4326008)(64756008)(66556008)(6116002)(186003)(9686003)(68736007)(256004)(99286004)(3846002)(6436002)(66446008)(5660300002)(66066001)(81166006)(81156014)(8936002)(6246003)(107886003)(66476007)(14454004)(446003)(8676002)(52536014)(6636002)(74316002)(4744005)(11346002)(53936002)(486006)(76176011)(71200400001)(71190400001)(86362001)(102836004)(476003)(478600001)(229853002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: y/xTR1WlK0NHv0UrC4Vts0S/xx6z1JfsCv0uKOHiIA871uKce+pPywbP5NVqeBJyy+Kr5T00+e4/RPxufelSxJzpq1yBdSrDGUFirY7N2kes8OwfWth31mXuTepBuOYylDnRfa6HGs9pE8oIabCBgmf6w8+vhaO2jwETjV1arV2eYhjEI7ZPt0YJkS52n9/MzG6cBM5yriisH+a0rEIXnufVSUiSMUfAAOdWBYCHRkk1G5TTt0kTnslIDfl9Zyudi7ymRNscNZIE/r3CbekFiXzV+Rhl6MreW4HDO9t+grXWpBWJH5X3tygp4D3xTueJDN8r2QX6JF8oJtQfRrkrX1nVtp7N5KDcn2JLRXhrFaj+QoYCWlqcLD1x0y8umf+rpwzjQkMN4My/LQ+LKRwuw9UkJGprle/BHzOz+szUVIU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1cc709d-137d-49f3-4b7f-08d6d36fd70e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2019 04:44:22.1683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4001 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2019 04:44:23 -0000 Tuesday, May 7, 2019 4:42 PM, Ori Kam: > Subject: [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules >=20 > When Direct Rules API is not supported we don't set the errno. > this results in failing the function but with errno equals to zero. > The result of this is that a function that failed, is considered as a fun= ction that > worked correctly. >=20 > This commit fixes this issue by setting the errno to ENOTSUP and returnin= g > this error when error value should be returned. >=20 > Since RDMA-CORE are returning positive errno we are also returning positi= ve > error values. >=20 > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") >=20 > Signed-off-by: Ori Kam Applied to next-net-mlx, thanks.=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0DA70A0096 for ; Wed, 8 May 2019 06:44:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 704D64CA0; Wed, 8 May 2019 06:44:24 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20063.outbound.protection.outlook.com [40.107.2.63]) by dpdk.org (Postfix) with ESMTP id 53F764CA0 for ; Wed, 8 May 2019 06:44:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q92Tp/Wx+bqqSHUIjVMRO8sVifa0Z5/+GldhMU/rlYc=; b=mUTShr0gl9PNImREeykUqL7Zmj3zVHPzeMoui4u8EinwX7NBBZkDzKfbasQL1ZsrDwviwg7+3fZunzMvMbG6E/TTzABXoaU6NVkmrEyOABxxsQ5bZMxZazqQSYXbE6sW2wsIJWGlSi9ybXS3KyKsvtiejseeRARarLyHfnkz9dY= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Wed, 8 May 2019 04:44:22 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d%7]) with mapi id 15.20.1856.012; Wed, 8 May 2019 04:44:22 +0000 From: Shahaf Shuler To: Ori Kam , Yongseok Koh , Matan Azrad CC: "dev@dpdk.org" , Ori Kam Thread-Topic: [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules Thread-Index: AQHVBNqqzokYTeKBFkCA8oLYw6fvlqZgoqHg Date: Wed, 8 May 2019 04:44:22 +0000 Message-ID: References: <1557236494-4808-1-git-send-email-orika@mellanox.com> In-Reply-To: <1557236494-4808-1-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1cc709d-137d-49f3-4b7f-08d6d36fd70e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4001; x-ms-traffictypediagnostic: AM0PR0502MB4001: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 0031A0FFAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(396003)(39860400002)(136003)(199004)(189003)(305945005)(26005)(55016002)(66946007)(2906002)(73956011)(76116006)(25786009)(110136005)(7736002)(316002)(54906003)(33656002)(7696005)(4326008)(64756008)(66556008)(6116002)(186003)(9686003)(68736007)(256004)(99286004)(3846002)(6436002)(66446008)(5660300002)(66066001)(81166006)(81156014)(8936002)(6246003)(107886003)(66476007)(14454004)(446003)(8676002)(52536014)(6636002)(74316002)(4744005)(11346002)(53936002)(486006)(76176011)(71200400001)(71190400001)(86362001)(102836004)(476003)(478600001)(229853002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: y/xTR1WlK0NHv0UrC4Vts0S/xx6z1JfsCv0uKOHiIA871uKce+pPywbP5NVqeBJyy+Kr5T00+e4/RPxufelSxJzpq1yBdSrDGUFirY7N2kes8OwfWth31mXuTepBuOYylDnRfa6HGs9pE8oIabCBgmf6w8+vhaO2jwETjV1arV2eYhjEI7ZPt0YJkS52n9/MzG6cBM5yriisH+a0rEIXnufVSUiSMUfAAOdWBYCHRkk1G5TTt0kTnslIDfl9Zyudi7ymRNscNZIE/r3CbekFiXzV+Rhl6MreW4HDO9t+grXWpBWJH5X3tygp4D3xTueJDN8r2QX6JF8oJtQfRrkrX1nVtp7N5KDcn2JLRXhrFaj+QoYCWlqcLD1x0y8umf+rpwzjQkMN4My/LQ+LKRwuw9UkJGprle/BHzOz+szUVIU= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1cc709d-137d-49f3-4b7f-08d6d36fd70e X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2019 04:44:22.1683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4001 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190508044422.8oSwnplwFMRl_PJsRU82cepoZuCb2XAoX6jV8556QfM@z> Tuesday, May 7, 2019 4:42 PM, Ori Kam: > Subject: [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules >=20 > When Direct Rules API is not supported we don't set the errno. > this results in failing the function but with errno equals to zero. > The result of this is that a function that failed, is considered as a fun= ction that > worked correctly. >=20 > This commit fixes this issue by setting the errno to ENOTSUP and returnin= g > this error when error value should be returned. >=20 > Since RDMA-CORE are returning positive errno we are also returning positi= ve > error values. >=20 > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") >=20 > Signed-off-by: Ori Kam Applied to next-net-mlx, thanks.=20