From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140041.outbound.protection.outlook.com [40.107.14.41]) by dpdk.org (Postfix) with ESMTP id 795101B1EA for ; Mon, 29 Apr 2019 10:54:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SrpkqcPp2Z/a8nJuRHg0pZYH3Qv6HKZBMCTvUd4gXos=; b=wcqcDluy2t/I7mYS+UtnHfeFCZuMDvtggJLZkgTS5vNESZNP5VGvRJkYFXJ89ZufG8HMIBVh7Epq38ScKLsMuCJ5RhRYDspmbYvMrdoLnRn/K8pz/hfgC5/LUaIMldrqou7CxVZUkHA5TLcsGqtRlRj+9WSIXTTOa4eqR2pOBS4= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3602.eurprd05.prod.outlook.com (52.133.43.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.12; Mon, 29 Apr 2019 08:54:37 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1835.018; Mon, 29 Apr 2019 08:54:37 +0000 From: Shahaf Shuler To: Adrien Mazarguil , Matan Azrad CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx4: add support for multicast address list interface Thread-Index: AQHU9egdsKQ7DJzeoUGutweBSJwFHaZS4CRA Date: Mon, 29 Apr 2019 08:54:36 +0000 Message-ID: References: <20190418130245.25618-1-adrien.mazarguil@6wind.com> In-Reply-To: <20190418130245.25618-1-adrien.mazarguil@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82b32a3e-f4d6-4574-e2e6-08d6cc804eea x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3602; x-ms-traffictypediagnostic: AM0PR0502MB3602: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0022134A87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(136003)(39860400002)(396003)(199004)(189003)(478600001)(71200400001)(54075001)(71190400001)(68736007)(2906002)(86362001)(6116002)(3846002)(33656002)(14454004)(186003)(4326008)(102836004)(66446008)(446003)(66066001)(7696005)(99286004)(11346002)(52536014)(8936002)(66946007)(66476007)(76176011)(110136005)(81166006)(81156014)(8676002)(6506007)(53936002)(256004)(6246003)(316002)(26005)(74316002)(486006)(476003)(6636002)(55016002)(66556008)(25786009)(97736004)(76116006)(73956011)(229853002)(305945005)(7736002)(64756008)(6436002)(5660300002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3602; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: tlOJik3jlCDPFKig4gypeBFaG3+cS2q2vlkJMyFT69UG/G+HjFfPgIt3gwZAT8vQRZCwt63SkJORWJEK78Q6DZx5lwUuOjmbn80pl5ANsnaEHWGnrMVUzWGoGCCRuRSjxSmYkFIyYk9DNgx77rAh/dFPOvueyLheziJLflV9w1QPqw6TfQOzVIJBD5N2tROYBm/02iXOK/qvgxmUZ1of/SgmuqI7M12+lj8pjAwL9TiaGfUE4WZ0pJMXfTGY/w+CntlSqIMD/z9WfWCU7/za7G/Ul4T4LSBIve5YcML1z0yUA8/ane6wYervSUDsSs65+c1jBHpfkB6k+GJ8tFV2AsfHUPIq/77/TeVwTc5xIX6X9lwYzTQ7EHRS+cxoonyDgk+2l/h0m3WjuBgatLLFA0TsA2jI+GlDlMNkeJiOb1E= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82b32a3e-f4d6-4574-e2e6-08d6cc804eea X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2019 08:54:37.0239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3602 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: add support for multicast address list interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Apr 2019 08:54:39 -0000 Thursday, April 18, 2019 4:11 PM, Adrien Mazarguil: > Subject: [PATCH] net/mlx4: add support for multicast address list interfa= ce >=20 > Since this driver does not distinguish unicast/multicast addresses, > applications could always rely on the standard MAC add/remove/set > interface to configure both types. >=20 > As a result, the multicast address list interface never got implemented > (rte_eth_dev_set_mc_addr_list()) however PMD-agnostic applications still > rely on it for compatibility reasons; a wrapper is therefore required. >=20 > Signed-off-by: Adrien Mazarguil Applied to next-net-mlx with a small change (see below).=20 > --- > drivers/net/mlx4/mlx4.c | 1 + > drivers/net/mlx4/mlx4.h | 3 ++ > drivers/net/mlx4/mlx4_ethdev.c | 61 [...] > @@ -488,6 +488,63 @@ mlx4_mac_addr_add(struct rte_eth_dev *dev, > struct ether_addr *mac_addr, } >=20 > /** > + * DPDK callback to configure multicast addresses. > + * > + * @param dev > + * Pointer to Ethernet device structure. > + * @param list > + * List of MAC addresses to register. > + * @param num > + * Number of entries in list. > + * > + * @return > + * 0 on success, negative errno value otherwise and rte_errno is set. > + */ > +int > +mlx4_set_mc_addr_list(struct rte_eth_dev *dev, struct ether_addr *list, > + uint32_t num) > +{ > + struct priv *priv =3D dev->data->dev_private; I have modified it to struct mlx4_priv. please shout if you disagree. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AA062A0679 for ; Mon, 29 Apr 2019 10:54:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C35411B1FD; Mon, 29 Apr 2019 10:54:43 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140041.outbound.protection.outlook.com [40.107.14.41]) by dpdk.org (Postfix) with ESMTP id 795101B1EA for ; Mon, 29 Apr 2019 10:54:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SrpkqcPp2Z/a8nJuRHg0pZYH3Qv6HKZBMCTvUd4gXos=; b=wcqcDluy2t/I7mYS+UtnHfeFCZuMDvtggJLZkgTS5vNESZNP5VGvRJkYFXJ89ZufG8HMIBVh7Epq38ScKLsMuCJ5RhRYDspmbYvMrdoLnRn/K8pz/hfgC5/LUaIMldrqou7CxVZUkHA5TLcsGqtRlRj+9WSIXTTOa4eqR2pOBS4= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3602.eurprd05.prod.outlook.com (52.133.43.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.12; Mon, 29 Apr 2019 08:54:37 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1835.018; Mon, 29 Apr 2019 08:54:37 +0000 From: Shahaf Shuler To: Adrien Mazarguil , Matan Azrad CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx4: add support for multicast address list interface Thread-Index: AQHU9egdsKQ7DJzeoUGutweBSJwFHaZS4CRA Date: Mon, 29 Apr 2019 08:54:36 +0000 Message-ID: References: <20190418130245.25618-1-adrien.mazarguil@6wind.com> In-Reply-To: <20190418130245.25618-1-adrien.mazarguil@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82b32a3e-f4d6-4574-e2e6-08d6cc804eea x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3602; x-ms-traffictypediagnostic: AM0PR0502MB3602: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0022134A87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(136003)(39860400002)(396003)(199004)(189003)(478600001)(71200400001)(54075001)(71190400001)(68736007)(2906002)(86362001)(6116002)(3846002)(33656002)(14454004)(186003)(4326008)(102836004)(66446008)(446003)(66066001)(7696005)(99286004)(11346002)(52536014)(8936002)(66946007)(66476007)(76176011)(110136005)(81166006)(81156014)(8676002)(6506007)(53936002)(256004)(6246003)(316002)(26005)(74316002)(486006)(476003)(6636002)(55016002)(66556008)(25786009)(97736004)(76116006)(73956011)(229853002)(305945005)(7736002)(64756008)(6436002)(5660300002)(9686003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3602; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: tlOJik3jlCDPFKig4gypeBFaG3+cS2q2vlkJMyFT69UG/G+HjFfPgIt3gwZAT8vQRZCwt63SkJORWJEK78Q6DZx5lwUuOjmbn80pl5ANsnaEHWGnrMVUzWGoGCCRuRSjxSmYkFIyYk9DNgx77rAh/dFPOvueyLheziJLflV9w1QPqw6TfQOzVIJBD5N2tROYBm/02iXOK/qvgxmUZ1of/SgmuqI7M12+lj8pjAwL9TiaGfUE4WZ0pJMXfTGY/w+CntlSqIMD/z9WfWCU7/za7G/Ul4T4LSBIve5YcML1z0yUA8/ane6wYervSUDsSs65+c1jBHpfkB6k+GJ8tFV2AsfHUPIq/77/TeVwTc5xIX6X9lwYzTQ7EHRS+cxoonyDgk+2l/h0m3WjuBgatLLFA0TsA2jI+GlDlMNkeJiOb1E= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82b32a3e-f4d6-4574-e2e6-08d6cc804eea X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2019 08:54:37.0239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3602 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: add support for multicast address list interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190429085436.k_nsrZOdWvBgDHDNSEo9M8Sc5iLCFgetjfdeBzExpMQ@z> Thursday, April 18, 2019 4:11 PM, Adrien Mazarguil: > Subject: [PATCH] net/mlx4: add support for multicast address list interfa= ce >=20 > Since this driver does not distinguish unicast/multicast addresses, > applications could always rely on the standard MAC add/remove/set > interface to configure both types. >=20 > As a result, the multicast address list interface never got implemented > (rte_eth_dev_set_mc_addr_list()) however PMD-agnostic applications still > rely on it for compatibility reasons; a wrapper is therefore required. >=20 > Signed-off-by: Adrien Mazarguil Applied to next-net-mlx with a small change (see below).=20 > --- > drivers/net/mlx4/mlx4.c | 1 + > drivers/net/mlx4/mlx4.h | 3 ++ > drivers/net/mlx4/mlx4_ethdev.c | 61 [...] > @@ -488,6 +488,63 @@ mlx4_mac_addr_add(struct rte_eth_dev *dev, > struct ether_addr *mac_addr, } >=20 > /** > + * DPDK callback to configure multicast addresses. > + * > + * @param dev > + * Pointer to Ethernet device structure. > + * @param list > + * List of MAC addresses to register. > + * @param num > + * Number of entries in list. > + * > + * @return > + * 0 on success, negative errno value otherwise and rte_errno is set. > + */ > +int > +mlx4_set_mc_addr_list(struct rte_eth_dev *dev, struct ether_addr *list, > + uint32_t num) > +{ > + struct priv *priv =3D dev->data->dev_private; I have modified it to struct mlx4_priv. please shout if you disagree.