From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10065.outbound.protection.outlook.com [40.107.1.65]) by dpdk.org (Postfix) with ESMTP id E68A6343C; Mon, 1 Apr 2019 12:57:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=25+NpjAe79v6C2lUMQ1DISXYQJQX//6N+5r+U80oA9g=; b=kIjsoLeD2ZLFflPmk9TTT6uCUyFJOkf92viy6OmfEC74a7gn5VOq8XmVXj/RhUjlegIvNHOIpi/VSyoqtHIKsC9/0cj71lvoWeNS614VdfZDkuk81zcrLZxQdYxI5E5UbZ60zJp8uc0pjJlpP35tpBcHJqtWoTyO8FkKCjBUZMU= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3668.eurprd05.prod.outlook.com (52.133.44.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.19; Mon, 1 Apr 2019 10:57:02 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1750.014; Mon, 1 Apr 2019 10:57:02 +0000 From: Shahaf Shuler To: Yongseok Koh CC: dev , dpdk stable , Kevin Traynor Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: revert mbuf address calculation for x86 Thread-Index: AQHU4z7Qd63naiadokesAASS6vavdaYfYFcAgACv+ICABxxBwA== Date: Mon, 1 Apr 2019 10:57:02 +0000 Message-ID: References: <20190325191310.20594-1-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b464d71a-6c37-4768-5951-08d6b690c59b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM0PR0502MB3668; x-ms-traffictypediagnostic: AM0PR0502MB3668: x-microsoft-antispam-prvs: x-forefront-prvs: 0994F5E0C5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(366004)(39860400002)(136003)(346002)(199004)(78124002)(189003)(7696005)(97736004)(6862004)(11346002)(6506007)(102836004)(52536014)(6246003)(6436002)(54906003)(53936002)(316002)(8676002)(2906002)(81156014)(81166006)(446003)(33656002)(256004)(3846002)(229853002)(476003)(478600001)(9686003)(5660300002)(8936002)(6116002)(76176011)(86362001)(55016002)(486006)(186003)(74316002)(53546011)(66066001)(14454004)(305945005)(106356001)(25786009)(26005)(68736007)(99286004)(7736002)(6636002)(105586002)(71200400001)(71190400001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3668; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 4sN0s7RF1I6scycREKk04G1NeRl3WJ8aF0dGYx76oHS06mlSG6Jb4Q8cxQcgKXd7PcwGiGUsJJF8euyEUsr+/44bAktcq730t0/UMfRWb6O1S3L3GxPC734CfDXNAgGt/1FcYXDLGD5iXF8GwA56Z0gb2u65kSGjFp8rr5rx1/FJ/4NlwRIDwW0NpjcQXzZfTB6rIupHYH17Llgjz2lPuRoyNdWbAP7/0eoti8rlqQ4dHfvo2BOnzseWxbjhtr+jlS71VwSlXzTbIjCEMDwazpYmFRLpKFtaL5AAC3Kb+NhPtVLqtUMGorlHlBOZhOw0llIXreGRGuvSjNtZw8l/Ymb/UEzqS+sAgvwFVz5/QebCCG4ulywCUrn9CTVymtfdXJpZ/F3YD6rE4bxRjdlG8aqPXrFLXN3W0n2aeWneWxA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b464d71a-6c37-4768-5951-08d6b690c59b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2019 10:57:02.5741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3668 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: revert mbuf address calculation for x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 10:57:04 -0000 Thursday, March 28, 2019 12:21 AM, Yongseok Koh: > > Cc: dev ; dpdk stable ; Kevin Traynor > > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: revert mbuf address calculation > for x86 >=20 >=20 > > On Mar 27, 2019, at 4:51 AM, Kevin Traynor > wrote: > > > > On 25/03/2019 19:13, Yongseok Koh wrote: > >> When replenishing mbufs on Rx, buffer address (mbuf->buf_addr) should > >> be loaded. non-x86 processors (mostly RISC such as ARM and Power) are > >> more vulnerable to load stall. For x86, reducing the number of > >> instructions seems to matter most. > >> > >> For x86, this is simply a load but for other architectures, it is > >> calculated from the address of mbuf structure by rte_mbuf_buf_addr() > >> without having to load the first cacheline of the mbuf. > >> > > > > Hi Yongseok, > > > >> Fixes: 12d468a62bc1 ("net/mlx5: fix instruction hotspot on > >> replenishing Rx buffer") > > > > A similar backport was just added into 18.11.1-RC2, should it be > > reverted? I'm not keen to put another fix for it in for 18.11.1 at > > this stage, I think it can be part of 18.11.2. WDYT? >=20 > I spoke with Kevin and we decided to drop the old fix. > I have also dropped it from 17.11.6-rc1. >=20 > This new fix will be merged to 18.11.2. > I'll merge it to 17.11.6 (or 17.11.7) if it is merged in the master. Applied to next-net-mlx, thanks.=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 45158A0679 for ; Mon, 1 Apr 2019 12:57:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 109064C8D; Mon, 1 Apr 2019 12:57:06 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10065.outbound.protection.outlook.com [40.107.1.65]) by dpdk.org (Postfix) with ESMTP id E68A6343C; Mon, 1 Apr 2019 12:57:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=25+NpjAe79v6C2lUMQ1DISXYQJQX//6N+5r+U80oA9g=; b=kIjsoLeD2ZLFflPmk9TTT6uCUyFJOkf92viy6OmfEC74a7gn5VOq8XmVXj/RhUjlegIvNHOIpi/VSyoqtHIKsC9/0cj71lvoWeNS614VdfZDkuk81zcrLZxQdYxI5E5UbZ60zJp8uc0pjJlpP35tpBcHJqtWoTyO8FkKCjBUZMU= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3668.eurprd05.prod.outlook.com (52.133.44.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.19; Mon, 1 Apr 2019 10:57:02 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1750.014; Mon, 1 Apr 2019 10:57:02 +0000 From: Shahaf Shuler To: Yongseok Koh CC: dev , dpdk stable , Kevin Traynor Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: revert mbuf address calculation for x86 Thread-Index: AQHU4z7Qd63naiadokesAASS6vavdaYfYFcAgACv+ICABxxBwA== Date: Mon, 1 Apr 2019 10:57:02 +0000 Message-ID: References: <20190325191310.20594-1-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b464d71a-6c37-4768-5951-08d6b690c59b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM0PR0502MB3668; x-ms-traffictypediagnostic: AM0PR0502MB3668: x-microsoft-antispam-prvs: x-forefront-prvs: 0994F5E0C5 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(366004)(39860400002)(136003)(346002)(199004)(78124002)(189003)(7696005)(97736004)(6862004)(11346002)(6506007)(102836004)(52536014)(6246003)(6436002)(54906003)(53936002)(316002)(8676002)(2906002)(81156014)(81166006)(446003)(33656002)(256004)(3846002)(229853002)(476003)(478600001)(9686003)(5660300002)(8936002)(6116002)(76176011)(86362001)(55016002)(486006)(186003)(74316002)(53546011)(66066001)(14454004)(305945005)(106356001)(25786009)(26005)(68736007)(99286004)(7736002)(6636002)(105586002)(71200400001)(71190400001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3668; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 4sN0s7RF1I6scycREKk04G1NeRl3WJ8aF0dGYx76oHS06mlSG6Jb4Q8cxQcgKXd7PcwGiGUsJJF8euyEUsr+/44bAktcq730t0/UMfRWb6O1S3L3GxPC734CfDXNAgGt/1FcYXDLGD5iXF8GwA56Z0gb2u65kSGjFp8rr5rx1/FJ/4NlwRIDwW0NpjcQXzZfTB6rIupHYH17Llgjz2lPuRoyNdWbAP7/0eoti8rlqQ4dHfvo2BOnzseWxbjhtr+jlS71VwSlXzTbIjCEMDwazpYmFRLpKFtaL5AAC3Kb+NhPtVLqtUMGorlHlBOZhOw0llIXreGRGuvSjNtZw8l/Ymb/UEzqS+sAgvwFVz5/QebCCG4ulywCUrn9CTVymtfdXJpZ/F3YD6rE4bxRjdlG8aqPXrFLXN3W0n2aeWneWxA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b464d71a-6c37-4768-5951-08d6b690c59b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2019 10:57:02.5741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3668 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: revert mbuf address calculation for x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401105702.FhUHqmjGFX265qRvFBnW0neXdTWz9xs1QKGDMXueIzg@z> Thursday, March 28, 2019 12:21 AM, Yongseok Koh: > > Cc: dev ; dpdk stable ; Kevin Traynor > > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: revert mbuf address calculation > for x86 >=20 >=20 > > On Mar 27, 2019, at 4:51 AM, Kevin Traynor > wrote: > > > > On 25/03/2019 19:13, Yongseok Koh wrote: > >> When replenishing mbufs on Rx, buffer address (mbuf->buf_addr) should > >> be loaded. non-x86 processors (mostly RISC such as ARM and Power) are > >> more vulnerable to load stall. For x86, reducing the number of > >> instructions seems to matter most. > >> > >> For x86, this is simply a load but for other architectures, it is > >> calculated from the address of mbuf structure by rte_mbuf_buf_addr() > >> without having to load the first cacheline of the mbuf. > >> > > > > Hi Yongseok, > > > >> Fixes: 12d468a62bc1 ("net/mlx5: fix instruction hotspot on > >> replenishing Rx buffer") > > > > A similar backport was just added into 18.11.1-RC2, should it be > > reverted? I'm not keen to put another fix for it in for 18.11.1 at > > this stage, I think it can be part of 18.11.2. WDYT? >=20 > I spoke with Kevin and we decided to drop the old fix. > I have also dropped it from 17.11.6-rc1. >=20 > This new fix will be merged to 18.11.2. > I'll merge it to 17.11.6 (or 17.11.7) if it is merged in the master. Applied to next-net-mlx, thanks.=20