From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150059.outbound.protection.outlook.com [40.107.15.59]) by dpdk.org (Postfix) with ESMTP id 8B91C4F91 for ; Wed, 1 May 2019 08:10:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NB7FzaxrwMqwgL666lIsRvjBFpp7mnr11YLqUUFS2y4=; b=VrXGF3kaEKZlzyjxawHMcr1Ue6Y8G2rAQ9luJrio7I0oPXv0QGrst1Z6wPEHftJrcnk1+p3MgQrUo/6E8IXdYc9Yy56qgElT3OkAY6TqRG8lKqLr8WzONi6vb2eu5SXs7s4dRjlA1gfut+hhYpN2abUVGpMoC8nVHehsi7lxDkQ= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3969.eurprd05.prod.outlook.com (52.133.36.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13; Wed, 1 May 2019 06:10:38 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1856.008; Wed, 1 May 2019 06:10:38 +0000 From: Shahaf Shuler To: Yongseok Koh CC: "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [PATCH v2] net/mlx5: check Tx queue size overflow Thread-Index: AQHU/7tjRaLI1NatYkykuDTikbz/qKZVyZjA Date: Wed, 1 May 2019 06:10:38 +0000 Message-ID: References: <20190430190426.44018-1-yskoh@mellanox.com> <20190501010143.611-1-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb508e7f-7497-4296-fdbd-08d6cdfbbbab x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3969; x-ms-traffictypediagnostic: AM0PR0502MB3969: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 00246AB517 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(366004)(39860400002)(136003)(199004)(189003)(33656002)(8676002)(446003)(81156014)(5660300002)(71200400001)(486006)(14444005)(256004)(81166006)(76176011)(11346002)(316002)(53936002)(6506007)(86362001)(8936002)(53546011)(229853002)(6436002)(68736007)(4744005)(476003)(55016002)(2906002)(25786009)(26005)(66066001)(66556008)(71190400001)(478600001)(102836004)(6246003)(3846002)(4326008)(6116002)(66476007)(186003)(6636002)(64756008)(9686003)(66946007)(66446008)(52536014)(76116006)(73956011)(74316002)(7736002)(6862004)(54906003)(305945005)(14454004)(99286004)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3969; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gEDEPn4ue/xRigfvBK9EZ2Lln+DkeSLb9JUAmKCTaeY7n+uGQxWUMtuuEutoGlf9XwEI4GOFGL3lLKnme3UnSWSHg6/xPVOt6cYxHED1iC/5wg1iWn28fzwXQVqOYz6ZPyDqJ6N4Uj5JVcbBNktq7aQCTsTKLapXkWwT7mA6Kzfow/uoBiNZxh5CJ1dCDFoG0IOAX0fYxOIoqd9tuVEI+NaBbR1bRHW09VZC8TWrB5XeNK9ZE/Gv5dxv9zYnycE/aVvC8CbLszJZclnVsDnVx1y5CrWUqoVkPkH8A38UvuC3yLt8T6RCfPj/jkP40GwSTbuWpmnN4oVenbqKnhyUPTcemGEZBpBN/QHKP/doXM424J7hIVRcrA584cbSeIDcchRfbR0WUfH5ixhdvJsYLgbVLvE4ojDAJk9A3PmR1ok= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb508e7f-7497-4296-fdbd-08d6cdfbbbab X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2019 06:10:38.7279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3969 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: check Tx queue size overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2019 06:10:39 -0000 Wednesday, May 1, 2019 4:16 AM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: check Tx queue size overflow >=20 >=20 > > On Apr 30, 2019, at 6:01 PM, Yongseok Koh wrote: > > > > If Tx packet inlining is enabled, rdma-core library should allocate > > large Tx WQ enough to support it. It is better for PMD to calculate > > the size of WQ based on the parameters and return error with > > appropriate message if it exceeds the device capability. > > > > Cc:stable@dpdk.org >=20 > Shahaf, > There's a checkpatch warning. Please put a space after ':' if you merge i= t. Changed and applied to next-net-mlx, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 67515A0ACC for ; Wed, 1 May 2019 08:10:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 327F74F91; Wed, 1 May 2019 08:10:41 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150059.outbound.protection.outlook.com [40.107.15.59]) by dpdk.org (Postfix) with ESMTP id 8B91C4F91 for ; Wed, 1 May 2019 08:10:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NB7FzaxrwMqwgL666lIsRvjBFpp7mnr11YLqUUFS2y4=; b=VrXGF3kaEKZlzyjxawHMcr1Ue6Y8G2rAQ9luJrio7I0oPXv0QGrst1Z6wPEHftJrcnk1+p3MgQrUo/6E8IXdYc9Yy56qgElT3OkAY6TqRG8lKqLr8WzONi6vb2eu5SXs7s4dRjlA1gfut+hhYpN2abUVGpMoC8nVHehsi7lxDkQ= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3969.eurprd05.prod.outlook.com (52.133.36.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13; Wed, 1 May 2019 06:10:38 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1856.008; Wed, 1 May 2019 06:10:38 +0000 From: Shahaf Shuler To: Yongseok Koh CC: "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [PATCH v2] net/mlx5: check Tx queue size overflow Thread-Index: AQHU/7tjRaLI1NatYkykuDTikbz/qKZVyZjA Date: Wed, 1 May 2019 06:10:38 +0000 Message-ID: References: <20190430190426.44018-1-yskoh@mellanox.com> <20190501010143.611-1-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb508e7f-7497-4296-fdbd-08d6cdfbbbab x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3969; x-ms-traffictypediagnostic: AM0PR0502MB3969: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 00246AB517 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(366004)(39860400002)(136003)(199004)(189003)(33656002)(8676002)(446003)(81156014)(5660300002)(71200400001)(486006)(14444005)(256004)(81166006)(76176011)(11346002)(316002)(53936002)(6506007)(86362001)(8936002)(53546011)(229853002)(6436002)(68736007)(4744005)(476003)(55016002)(2906002)(25786009)(26005)(66066001)(66556008)(71190400001)(478600001)(102836004)(6246003)(3846002)(4326008)(6116002)(66476007)(186003)(6636002)(64756008)(9686003)(66946007)(66446008)(52536014)(76116006)(73956011)(74316002)(7736002)(6862004)(54906003)(305945005)(14454004)(99286004)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3969; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gEDEPn4ue/xRigfvBK9EZ2Lln+DkeSLb9JUAmKCTaeY7n+uGQxWUMtuuEutoGlf9XwEI4GOFGL3lLKnme3UnSWSHg6/xPVOt6cYxHED1iC/5wg1iWn28fzwXQVqOYz6ZPyDqJ6N4Uj5JVcbBNktq7aQCTsTKLapXkWwT7mA6Kzfow/uoBiNZxh5CJ1dCDFoG0IOAX0fYxOIoqd9tuVEI+NaBbR1bRHW09VZC8TWrB5XeNK9ZE/Gv5dxv9zYnycE/aVvC8CbLszJZclnVsDnVx1y5CrWUqoVkPkH8A38UvuC3yLt8T6RCfPj/jkP40GwSTbuWpmnN4oVenbqKnhyUPTcemGEZBpBN/QHKP/doXM424J7hIVRcrA584cbSeIDcchRfbR0WUfH5ixhdvJsYLgbVLvE4ojDAJk9A3PmR1ok= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb508e7f-7497-4296-fdbd-08d6cdfbbbab X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2019 06:10:38.7279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3969 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: check Tx queue size overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190501061038.TGUrldD3Q_qUbfHGz2509yIfwqoeJ9fJFR1iB75gGwo@z> Wednesday, May 1, 2019 4:16 AM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: check Tx queue size overflow >=20 >=20 > > On Apr 30, 2019, at 6:01 PM, Yongseok Koh wrote: > > > > If Tx packet inlining is enabled, rdma-core library should allocate > > large Tx WQ enough to support it. It is better for PMD to calculate > > the size of WQ based on the parameters and return error with > > appropriate message if it exceeds the device capability. > > > > Cc:stable@dpdk.org >=20 > Shahaf, > There's a checkpatch warning. Please put a space after ':' if you merge i= t. Changed and applied to next-net-mlx, thanks.