From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0CD0A10DA for ; Wed, 31 Jul 2019 15:43:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2A8FC1BEE8; Wed, 31 Jul 2019 15:43:38 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80071.outbound.protection.outlook.com [40.107.8.71]) by dpdk.org (Postfix) with ESMTP id 24CE21BEAF for ; Wed, 31 Jul 2019 15:43:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AEHiKkkpzXi5IKUfUy+eJvse9XLvow/WlGabQy3GfsrLx5kuNFOtXXVhIflFmfIQSfMaWEf9YR6oeezVMe+muN9GCW+dWAb2xF8J9yBpFQe5RksBp+zU21uzb2E8OFCPyw8L8f39Vz+Gc4bE84/y2jF7B6S4iwvbTxIj3OS4eKh8mLNM1mzpHQaHkR7f5dN45CY5Dfn5d50LI14CdASqyltPDxtq5gWRw+pcsVaWG3F1jjW7Hrn1T9DEMlqi7ubCOMrHuJDm+uFmuVQqXVs8e3vy8mNFucwNZBWsYuhpmgyb9PwapjKzYjIZwwV3RT/1XzY0+M75xYNN7jJD1YIVNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GagaZHXtlEZ9czatmdZrJTpaf3nLuJUnVvWCB9l9Q0o=; b=KjZh9h8LnSOdfFeJPqhUMyLDEXFO7QTx0TqBm2XEM9vTfkVkce8B27jctwuyq9G1tS6qJh78YMXzrSO7yIsLXGmIdZSHtfhcoEmGdTDFD1RGkg39If2tYnNphyrbHdznds4oLl4JgRdpg9oGN5yxEo+UMlTBGE8vpQm6oQ0O/68oHrcOJwrcy7ltBWIWq9e1Vlz+xAuAlMXrbnKaEKdJMvCX3hmLDsx/7FAaMxkxNptGCW5mfBGpHYFSKEoZ9niUn+QrA4yyUuD4lty6Xe++VS1NtQoDs0EZrfZLulOksqD0S6a/P0C52ko2RWd+Qe8nAqsv3cLEVAKBwJtG9GdnGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GagaZHXtlEZ9czatmdZrJTpaf3nLuJUnVvWCB9l9Q0o=; b=jHsU+Kvt2Vj6H06IZPHjzIugS7CrTHWXXXWD62R+QFaxF1OkUhbESCbJLo9h0DcLp1CkmwFd5cjcwINll6Fp/ZAeQrg0Xh9uuWEHGgNcJuQqBEW2clNWWKTk+RCxfjkOtioHYaogCBC9AoWJRLowL3n8m35CSQF06utJoW7dSQ8= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3921.eurprd05.prod.outlook.com (52.133.43.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.16; Wed, 31 Jul 2019 13:43:34 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::5d2f:4ed:6a8d:e7ff]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::5d2f:4ed:6a8d:e7ff%3]) with mapi id 15.20.2115.005; Wed, 31 Jul 2019 13:43:34 +0000 From: Shahaf Shuler To: Adrien Mazarguil , Andrew Rybchenko CC: simei , "qi.z.zhang@intel.com" , "jingjing.wu@intel.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support Thread-Index: AQHVQqt6JGpc0p3oyUCBfXYtjaZA0Kbkq/GAgAAGPgCAABA/MA== Date: Wed, 31 Jul 2019 13:43:34 +0000 Message-ID: References: <1564030646-73951-1-git-send-email-simei.su@intel.com> <1564030646-73951-2-git-send-email-simei.su@intel.com> <291f410f-fc71-191b-8595-4c3d9e970041@solarflare.com> <20190731123040.GG4512@6wind.com> In-Reply-To: <20190731123040.GG4512@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e0ff7a3a-b5a1-4f14-86ac-08d715bd1530 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3921; x-ms-traffictypediagnostic: AM0PR0502MB3921: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 011579F31F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(376002)(39860400002)(136003)(396003)(366004)(189003)(199004)(76116006)(102836004)(66476007)(66556008)(76176011)(66946007)(6506007)(53546011)(66066001)(25786009)(186003)(26005)(64756008)(66446008)(99286004)(11346002)(486006)(476003)(4326008)(7696005)(86362001)(53936002)(55016002)(6246003)(478600001)(8936002)(81166006)(446003)(9686003)(229853002)(52536014)(14444005)(256004)(7736002)(54906003)(305945005)(316002)(81156014)(14454004)(8676002)(6436002)(110136005)(74316002)(2906002)(33656002)(5660300002)(3846002)(68736007)(71200400001)(71190400001)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3921; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: shocxrLzcYkr89zO3naybIC38QGVzAoGxy8gLRBsKmNnmpAaq6A8m7EcVnljwBvRDuFih4fkIHL2i4XdyUwVe+El9iCPAD3vPjVf5WHKiHpCVEZMOHlfL4RhrBh0GmDyXrwCDnVwveQbxlk8ZzXOzw0x71bfdySRa3VwtCoHBwWmrxxT6u2s7en7sCpV0Hb25ASKf69NVmw182txJbuygE4rwunPN2gItPe8Ru4oT6oh7rTonp0c8v8dynG3ub648h1yOnmzpr8T4X2FzW9gSleN42naR8zozj+l0t0OdMYZHNhQNoXZDpnKlYihAMfdaT5a1Bm7GeduRAv9haKEygLB4OPjWcNejg5zuEDNdW8An6RC43ePJXisSrp6pPHGgCeBDBvM4fhHK4jjBMQCjwMJ9Ivl+NS0fMUC6hk5Ssg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0ff7a3a-b5a1-4f14-86ac-08d715bd1530 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2019 13:43:34.3351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shahafs@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3921 Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Wednesday, July 31, 2019 3:31 PM, Adrien Mazarguil: > Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: add symmetric toeplitz hash > support >=20 > On Wed, Jul 31, 2019 at 03:08:19PM +0300, Andrew Rybchenko wrote: > > On 7/25/19 7:57 AM, simei wrote: > > > From: Simei Su > > > > > > Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash funtion. > > > To support symmetric hash by rte_flow RSS action, this patch adds > > > new hash function "Symmetric Toeplitz" which is supported by some > hardware. > > > > Isn't it a question of key to achieve symmetry? > > I.e. hash algorithm (function) is still the same - Toeplitz, but hash > > key makes the result symmetric (i.e. equal for flows in both > > directions - swap transport ports and IPv4/6 addresses). >=20 > This is only an option when src/dst are known in advance. >=20 > When doing RSS, HW implementations (such as Mellanox's) implement a > modified Toeplitz XOR'ing src with dst resulting in the same hash both wa= ys > regardless of the key. Just to stand correct it was a bug on Mellanox kernel driver that was fixed= . Now the RSS is spec complaint (non-symmetric).=20 Andrew is correct one can have a special key that will make the RSS symmetr= ic, however it is good to have this option for the user to explicitly reque= st symmetric function (w/o any restriction on the key). >=20 > -- > Adrien Mazarguil > 6WIND