From: Shahaf Shuler <shahafs@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@mellanox.com>,
Dekel Peled <dekelp@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix hex dump of error CQE
Date: Thu, 7 Mar 2019 08:37:59 +0000 [thread overview]
Message-ID: <AM0PR0502MB3795F1E467220A0FB4BFDCE2C34C0@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1551367125-37928-1-git-send-email-dekelp@mellanox.com>
Thursday, February 28, 2019 5:19 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix hex dump of error CQE
>
> struct mlx5_cqe is defined in MLX5 PMD code (mlx5_prm.h).
> It includes 64 bytes padding in case of (RTE_CACHE_LINE_SIZE == 128).
>
> struct mlx5_err_cqe is defined in kernel, and doesn't include padding.
>
> When running in debug mode, in case an error CQE is detected it is printed
> using rte_hexdump().
>
> The size of data to print should be sizeof(*cqe) instead of sizeof(*err_cqe),
> to handle the case of (RTE_CACHE_LINE_SIZE == 128), and print the full data
> in any case.
>
> Fixes: c7714992092f ("net/mlx5: extend debug logs verbosity")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Applied to next-net-mlx, thanks.
prev parent reply other threads:[~2019-03-07 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 15:18 Dekel Peled
2019-03-07 8:37 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB3795F1E467220A0FB4BFDCE2C34C0@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).