DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>, Ori Kam <orika@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group
Date: Mon, 22 Apr 2019 17:45:59 +0000	[thread overview]
Message-ID: <AM0PR0502MB3795F88224E1835AA6202381C3220@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20190416230742.GB21044@mtidpdk.mti.labs.mlnx>

Wednesday, April 17, 2019 2:08 AM, Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: fix missing init for flow group
> 
> On Sun, Apr 14, 2019 at 08:18:55PM +0000, Ori Kam wrote:
> > the flow group should be initialized.
> > For example selecting if the encapsulation is for root or private
> > tables is based on the flow->group value.
> >
> > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
> >
> > Signed-off-by: Ori Kam <orika@mellanox.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

Applied to next-net-mlx, thanks. 

> 
> >  drivers/net/mlx5/mlx5_flow_dv.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> > b/drivers/net/mlx5/mlx5_flow_dv.c index 3862b26..82e8749 100644
> > --- a/drivers/net/mlx5/mlx5_flow_dv.c
> > +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> > @@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] = {
> >  	union flow_dv_attr flow_attr = { .attr = 0 };
> >  	struct mlx5_flow_dv_tag_resource tag_resource;
> >
> > +	flow->group = attr->group;
> >  	if (priority == MLX5_FLOW_PRIO_RSVD)
> >  		priority = priv->config.flow_prio - 1;
> >  	for (; !actions_end ; actions++) {
> > --
> > 1.8.3.1
> >

  parent reply	other threads:[~2019-04-22 17:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-14 20:18 Ori Kam
2019-04-14 20:18 ` Ori Kam
2019-04-16 23:07 ` Yongseok Koh
2019-04-16 23:07   ` Yongseok Koh
2019-04-22 17:45   ` Shahaf Shuler [this message]
2019-04-22 17:45     ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0502MB3795F88224E1835AA6202381C3220@AM0PR0502MB3795.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=orika@mellanox.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).