From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40058.outbound.protection.outlook.com [40.107.4.58]) by dpdk.org (Postfix) with ESMTP id 10D381B443 for ; Mon, 22 Apr 2019 19:46:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W2uu6SNXxkh5lbmCfgiVclVVehRkJEUnxywr5GqF4OI=; b=PumriXKDJWsTpRf2tNhecCBD20aunHPHJtnmFUy3m4s0iezdQCVQ88nTKiAYL3o8jF7IBiUlc/0pc1jLPT31h3oo3Tkly+vtNn1JGzgjHEh4XJFC0a67OOgpMXE73BixxAH8+HIfhamuE4iXP5N3OixNpc3MhxAaCuMQLHNaAS0= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3604.eurprd05.prod.outlook.com (52.133.46.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 17:46:00 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1813.017; Mon, 22 Apr 2019 17:46:00 +0000 From: Shahaf Shuler To: Yongseok Koh , Ori Kam CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix missing init for flow group Thread-Index: AQHU9Kk5cnf8SbO9Zkyvxh0QDpmZbaZIejUw Date: Mon, 22 Apr 2019 17:45:59 +0000 Message-ID: References: <1555273135-1773-1-git-send-email-orika@mellanox.com> <20190416230742.GB21044@mtidpdk.mti.labs.mlnx> In-Reply-To: <20190416230742.GB21044@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 93e5bde2-82e3-42b7-ff60-08d6c74a61b9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3604; x-ms-traffictypediagnostic: AM0PR0502MB3604: x-microsoft-antispam-prvs: x-forefront-prvs: 00159D1518 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(136003)(376002)(346002)(199004)(189003)(8676002)(6246003)(81166006)(81156014)(229853002)(316002)(14454004)(66066001)(6636002)(33656002)(4326008)(5660300002)(2906002)(53936002)(8936002)(110136005)(97736004)(256004)(478600001)(55016002)(486006)(25786009)(446003)(476003)(68736007)(102836004)(99286004)(6506007)(76176011)(6116002)(3846002)(7696005)(74316002)(9686003)(71190400001)(73956011)(186003)(26005)(52536014)(7736002)(305945005)(66446008)(64756008)(66556008)(66476007)(6436002)(66946007)(76116006)(71200400001)(86362001)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3604; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: GkPaKq57f6i4yFOo9Il+LK6BdRTg/D/ufIBMJS+1xq/tOsr5SqNVTxfT1CG5F+dw/D4z8msuyjnt04le5RErXzMQ3zVhMR1IAC/2XlnY9Wag/AMsPr4TdKWkTEr9gxg6JapDdA+DdOH/8YXovks8FaFajH+uh9f2Tn+y6A45R7R8RjB2NGTArVCBMS6yTn5udZqUsRMMO5pbEDDYlug4TuksLMvf8y3VwAuWF2IV+97U1QqNtzEjCzDbrpalANS1e2h50zkUiB/J3sftmNIXiBtOaIYtgoAO3cy8yEGCRUYzj7gwjleORiMzBWDiUHR8ITUm2CRfFQ0QXaFqy1w4sWgyHHMN+ABR5+sOXn6MUYhdWm9YnDlTWdcaHyD6ByWU6KJDoan39dFFDjQ8IP69buvElrydH2FJAX0kNhFWaig= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93e5bde2-82e3-42b7-ff60-08d6c74a61b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2019 17:45:59.9409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3604 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 17:46:02 -0000 Wednesday, April 17, 2019 2:08 AM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix missing init for flow group >=20 > On Sun, Apr 14, 2019 at 08:18:55PM +0000, Ori Kam wrote: > > the flow group should be initialized. > > For example selecting if the encapsulation is for root or private > > tables is based on the flow->group value. > > > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > > > > Signed-off-by: Ori Kam > > --- > Acked-by: Yongseok Koh Applied to next-net-mlx, thanks.=20 >=20 > > drivers/net/mlx5/mlx5_flow_dv.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > b/drivers/net/mlx5/mlx5_flow_dv.c index 3862b26..82e8749 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] =3D { > > union flow_dv_attr flow_attr =3D { .attr =3D 0 }; > > struct mlx5_flow_dv_tag_resource tag_resource; > > > > + flow->group =3D attr->group; > > if (priority =3D=3D MLX5_FLOW_PRIO_RSVD) > > priority =3D priv->config.flow_prio - 1; > > for (; !actions_end ; actions++) { > > -- > > 1.8.3.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BECB3A05D3 for ; Mon, 22 Apr 2019 19:46:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86DC71B446; Mon, 22 Apr 2019 19:46:03 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40058.outbound.protection.outlook.com [40.107.4.58]) by dpdk.org (Postfix) with ESMTP id 10D381B443 for ; Mon, 22 Apr 2019 19:46:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W2uu6SNXxkh5lbmCfgiVclVVehRkJEUnxywr5GqF4OI=; b=PumriXKDJWsTpRf2tNhecCBD20aunHPHJtnmFUy3m4s0iezdQCVQ88nTKiAYL3o8jF7IBiUlc/0pc1jLPT31h3oo3Tkly+vtNn1JGzgjHEh4XJFC0a67OOgpMXE73BixxAH8+HIfhamuE4iXP5N3OixNpc3MhxAaCuMQLHNaAS0= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3604.eurprd05.prod.outlook.com (52.133.46.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Mon, 22 Apr 2019 17:46:00 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1813.017; Mon, 22 Apr 2019 17:46:00 +0000 From: Shahaf Shuler To: Yongseok Koh , Ori Kam CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix missing init for flow group Thread-Index: AQHU9Kk5cnf8SbO9Zkyvxh0QDpmZbaZIejUw Date: Mon, 22 Apr 2019 17:45:59 +0000 Message-ID: References: <1555273135-1773-1-git-send-email-orika@mellanox.com> <20190416230742.GB21044@mtidpdk.mti.labs.mlnx> In-Reply-To: <20190416230742.GB21044@mtidpdk.mti.labs.mlnx> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 93e5bde2-82e3-42b7-ff60-08d6c74a61b9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3604; x-ms-traffictypediagnostic: AM0PR0502MB3604: x-microsoft-antispam-prvs: x-forefront-prvs: 00159D1518 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(136003)(376002)(346002)(199004)(189003)(8676002)(6246003)(81166006)(81156014)(229853002)(316002)(14454004)(66066001)(6636002)(33656002)(4326008)(5660300002)(2906002)(53936002)(8936002)(110136005)(97736004)(256004)(478600001)(55016002)(486006)(25786009)(446003)(476003)(68736007)(102836004)(99286004)(6506007)(76176011)(6116002)(3846002)(7696005)(74316002)(9686003)(71190400001)(73956011)(186003)(26005)(52536014)(7736002)(305945005)(66446008)(64756008)(66556008)(66476007)(6436002)(66946007)(76116006)(71200400001)(86362001)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3604; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: GkPaKq57f6i4yFOo9Il+LK6BdRTg/D/ufIBMJS+1xq/tOsr5SqNVTxfT1CG5F+dw/D4z8msuyjnt04le5RErXzMQ3zVhMR1IAC/2XlnY9Wag/AMsPr4TdKWkTEr9gxg6JapDdA+DdOH/8YXovks8FaFajH+uh9f2Tn+y6A45R7R8RjB2NGTArVCBMS6yTn5udZqUsRMMO5pbEDDYlug4TuksLMvf8y3VwAuWF2IV+97U1QqNtzEjCzDbrpalANS1e2h50zkUiB/J3sftmNIXiBtOaIYtgoAO3cy8yEGCRUYzj7gwjleORiMzBWDiUHR8ITUm2CRfFQ0QXaFqy1w4sWgyHHMN+ABR5+sOXn6MUYhdWm9YnDlTWdcaHyD6ByWU6KJDoan39dFFDjQ8IP69buvElrydH2FJAX0kNhFWaig= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93e5bde2-82e3-42b7-ff60-08d6c74a61b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2019 17:45:59.9409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3604 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422174559.ZfsQ2zHVDrlleQWyc_OfbrUoGnLH2_qQX2_TUK6OhaE@z> Wednesday, April 17, 2019 2:08 AM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix missing init for flow group >=20 > On Sun, Apr 14, 2019 at 08:18:55PM +0000, Ori Kam wrote: > > the flow group should be initialized. > > For example selecting if the encapsulation is for root or private > > tables is based on the flow->group value. > > > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > > > > Signed-off-by: Ori Kam > > --- > Acked-by: Yongseok Koh Applied to next-net-mlx, thanks.=20 >=20 > > drivers/net/mlx5/mlx5_flow_dv.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > b/drivers/net/mlx5/mlx5_flow_dv.c index 3862b26..82e8749 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -3236,6 +3236,7 @@ struct field_modify_info modify_tcp[] =3D { > > union flow_dv_attr flow_attr =3D { .attr =3D 0 }; > > struct mlx5_flow_dv_tag_resource tag_resource; > > > > + flow->group =3D attr->group; > > if (priority =3D=3D MLX5_FLOW_PRIO_RSVD) > > priority =3D priv->config.flow_prio - 1; > > for (; !actions_end ; actions++) { > > -- > > 1.8.3.1 > >