From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FC03A0540; Tue, 14 Jul 2020 07:02:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 271771D42A; Tue, 14 Jul 2020 07:02:10 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40049.outbound.protection.outlook.com [40.107.4.49]) by dpdk.org (Postfix) with ESMTP id 005461D423 for ; Tue, 14 Jul 2020 07:02:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oItwGXvZ7GcCgUyJtSjS77+EP2+lIohScfBNyKlcI4ickr0epUje5XfNTEOEqMPz97kQhLETIKEOR3uiTikLIYeI1hb5EEFNvZJ5EWzHdEzHMuKc7stxDZage/9LHiUERsFvZam+5PAga6xlB5izb9c65tnWRlXS+9kSR/j0S4WVmbYKMdNx5f+GXApoqODrIwRVkiIc8ExJ+Wq7siXr76MttbyeJ9pCzOeOvCGpJbUS1AyIUIoktoF8QrsQX+bgkoNXLv2T2xTKzQY/VfsYruQpdQ+alU/wHUO55Wz1LvMSsW/FMEbPNMesrj18W4rK7MLdZpEUyeEaEo4FJITkJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qBvAUTrkgkssSE9iQMea/mQV+PYOh0E+HU4vqVmVIOM=; b=apYu3hJkzCrKcw03PH9/70om2aDgR4esGqlq+lpYW1wRzVfNdgFogTHeWYdL53NMXCaPaONdESK8UtTzhvk6Pdh/cgG/Zj04Vukyo7Zrl2Zw/xv9kRkXtnn09C0IHFuCDiGRY/gvVRyWUBCCPXUwWGWQ7i6zicoDiZkGknd7PfhrMrn2ixNDtrFdfVh3gwXoW5eE8TcOqasC71BFG4hFSTAblMj7zIyTZf3/RwgB6ef17yOpdbPLfSRmWYDLl/p81O5PgJUt08bWXkqUQdRZGmc7W5q7O9q8dNOoyfIEBBVfBfNk/UkUccXHNwgTFAYiTTmiPMZVvJ4oBYJqCcaGXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qBvAUTrkgkssSE9iQMea/mQV+PYOh0E+HU4vqVmVIOM=; b=shY71zJl24iknWa9AiD4LZWM1dMdcVtEACMB0gEMMymYFE5yQzc3bsj7kxgG8OUpsJtAiqLI0sTjDHrlOWrClX5bjgUI/Zz6juVTayoa+O1r4LHh0/gaX+Tvg9EhRh56tBqChA08Nnu+LwYvwocZWHdSJpzWseTMET7HUERojSY= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (2603:10a6:208:f::11) by AM0PR05MB5939.eurprd05.prod.outlook.com (2603:10a6:208:128::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Tue, 14 Jul 2020 05:02:07 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998%7]) with mapi id 15.20.3174.025; Tue, 14 Jul 2020 05:02:07 +0000 From: Matan Azrad To: Thomas Monjalon , "dev@dpdk.org" CC: Raslan Darawsheh , Ophir Munk , Shahaf Shuler , Slava Ovsiienko Thread-Topic: [PATCH] common/mlx5: fix link with ibverbs glue dlopen option Thread-Index: AQHWWSuPU34eCIsUzE2lSoo7ZYsDDKkGhVNA Date: Tue, 14 Jul 2020 05:02:07 +0000 Message-ID: References: <20200713153710.807451-1-thomas@monjalon.net> In-Reply-To: <20200713153710.807451-1-thomas@monjalon.net> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [87.70.223.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4f1de0d4-31cc-4ff9-5c02-08d827b30ed7 x-ms-traffictypediagnostic: AM0PR05MB5939: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i58LtgK0G6/p/HHAVNXpPWXZ27gBSS3gej/Rb1h6Y8TABOvDky3DaGx1h0R/naFB4dqs/exMd9Wt5xQxJdn4GuFY9JhjzKS0bX7gMC1/T968I/sRQIh2W9ago0hOFM9thpBLEctudaYFr7xz8k/lRvjht8od90bHPd3RW5/munRs46f1r0NW90fYS6KbjcYlKiIKM0nLu6r9rhHJn5ItTAeW8y/VKFz64nB/CYUoaiY7llA148bxD0FqOOXl+iU9Eq382QCn4zDbujlLaF0lQ4Xi0IYqMXB2P5txEt/IPJFgvxTUbNpxmrvHWJvPZ9q8ZgPUHGEGlfkhS2ZwCQEBwQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(86362001)(55016002)(52536014)(110136005)(316002)(83380400001)(8936002)(478600001)(8676002)(26005)(33656002)(4326008)(186003)(71200400001)(107886003)(66556008)(66476007)(9686003)(66946007)(7696005)(6506007)(76116006)(54906003)(5660300002)(2906002)(66446008)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: dbCHjdIobSZDJVoevw6gbaJAjGsi2jpopJFAM8Cb/OzuLjbL2FpwDze9qRf2n5nzH/sHLFTEhSGAmJCic/PxXNXxwMmdTK//6GoV4ZeJAmGX5VG6jn72w0V73wtvM6sgqOA0R8XnUTGqWX65KGaFd/xSj+m7YPTScRs+tblsgavTQnwUuC2hcZ1A3C6q34iQiuz1bsZLYg77cvKkk18UWV0SiVfdfwJArQPToq0pkV9myweqtpTsSYVxA5TwZI4cwaD/+maKdB4O460mtFTf1sG1caFVSYMVzkS54B8QGaRK5e6OlF+DLX+aejskOgNBo2waHmC5wuxEYm/gdu0KPSJk3cDpZLapGanAK9qKHU4ilmwADg5eXia3Or6L6XMkLhP1MsWo68p9KoOEazWsMTCwdXWaUN8GIVxTaQSElWxfke4UELyAAucfKQkmCkcj6ZqSYZNJhZqZf28vDTkcGsb3pNcfx7o8wQrxtgDkdqI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR0502MB4019.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f1de0d4-31cc-4ff9-5c02-08d827b30ed7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 05:02:07.2920 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OQ53p8EN+a1uzWmqRGA88xUqJPg1H7cTYdJKUW98zg3IEPmvL1QyhMK8Y0Zc1u610UDf00SJLA34WODH91HH+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5939 Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix link with ibverbs glue dlopen option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon > In case the ibverbs glue is a separate library to dlopen, the PMD library= must > allocate a glue structure to be filled by dlopen. >=20 > The glue management was in mlx5_common.c and moved to > mlx5_common_os.c, but the variable allocation was not removed from the > original file. > The consequence was a link failure, if ibverbs dlopen option is enabled, > because of the redefinition of the variable (with GCC 10): > multiple definition of 'mlx5_glue' >=20 > The original definition is removed to keep only the one moved in the Linu= x > sub-directory. >=20 > Fixes: 79aa430721b1 ("common/mlx5: split common file under Linux > directory") > Cc: ophirmu@mellanox.com >=20 > Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad > --- > drivers/common/mlx5/mlx5_common.c | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_common.c > b/drivers/common/mlx5/mlx5_common.c > index 693e2c68c8..341239d164 100644 > --- a/drivers/common/mlx5/mlx5_common.c > +++ b/drivers/common/mlx5/mlx5_common.c > @@ -16,10 +16,6 @@ >=20 > int mlx5_common_logtype; >=20 > -#ifdef MLX5_GLUE > -const struct mlx5_glue *mlx5_glue; > -#endif > - > uint8_t haswell_broadwell_cpu; >=20 > static int > -- > 2.27.0