DPDK patches and discussions
 help / color / mirror / Atom feed
From: Matan Azrad <matan@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Raslan Darawsheh <rasland@mellanox.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX
Date: Fri, 21 Feb 2020 07:37:31 +0000	[thread overview]
Message-ID: <AM0PR0502MB401925B79F43616BE651DEE6D2120@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1582233513-3372-1-git-send-email-viacheslavo@mellanox.com>



From: Viacheslav Ovsiienko
> This patch does extra inline packet size check to tune the ConnectX-4LX
> performance in the legacy Multi-Packet Write mode.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>

Slava, Don't you think we want it for stable releases?

Besides it:
Acked-by: Matan Azrad <matan@mellanox.com>

>  drivers/net/mlx5/mlx5_rxtx.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index b55db4f..0df811b 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code {
>  			    loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE)
>  				goto pointer_empw;
>  			if (MLX5_TXOFF_CONFIG(MPW)) {
> +				if (dlen > txq->inlen_send)
> +					goto pointer_empw;
>  				tlen = dlen;
>  				if (part == room) {
>  					/* Open new inline MPW session. */
> --
> 1.8.3.1


  reply	other threads:[~2020-02-21  7:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 21:18 Viacheslav Ovsiienko
2020-02-21  7:37 ` Matan Azrad [this message]
2020-02-21  7:39   ` Slava Ovsiienko
2020-02-21  9:44     ` Ferruh Yigit
2020-02-21  9:51       ` Slava Ovsiienko
2020-02-21 10:07   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0502MB401925B79F43616BE651DEE6D2120@AM0PR0502MB4019.eurprd05.prod.outlook.com \
    --to=matan@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=rasland@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).