From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 200CFA0525; Fri, 21 Feb 2020 08:37:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BA071BF9A; Fri, 21 Feb 2020 08:37:36 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by dpdk.org (Postfix) with ESMTP id E5C6223D for ; Fri, 21 Feb 2020 08:37:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eA1mH3Tp7XdcYWNgRM6pYzP7A/Dzf9P52hNrki33i1XpNpTHcmO0lajRuGSE6oidRoXE+MzJY5yo/L5FY99/57IcoS634l2KIVaOGSzRsEFZEITOumreT+om+MeT+W/ESnRzVstBPb38VINJHss1YRcIIxLEbouvQcDj6Z/d/60UHqcaclbdfUbIH9EiBt8wuTurSOF/A7TBIVkSnGNFqwxl55PAWJpZi5lYfE7uFb6mhoQFbI3vNNgiEQXQi4SlWZlSdfpG5xCKat/otrlyWv5NYtNep0nkfL/JgNNoNQ6hMXH4B3hvVf/hAcze0sEvvt4c9+sQ83vZU7MaxVkFrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MocxUwCRHVBVdXABYhq9Pne5NIDNAp82Db25kZ/7igU=; b=FNmz5/OfzbNxPs52PdeiO7TAG09nj888rXwSNInToPMco0kdTbLt+aqV2pi9RVzz90OviWcH7dJwEvsSCDv8t32pN884tXU6D9u4Qw6uy22uPNV9RVr5SGrB/dG2bIPmAyNvnAd/UvO8IJp6rdFDfzCb6PDwNSGB+6Fi529gPWY1t7/BPBjB6UbkOkImVdihJmhmO2Ew2stdUU32NKrkjce+QEeBVpJPRFj66iJ7cIHfRtosD02iRjGRPvvqZYWIAbdkYyVDewmwqRYKuHwxof/mC+qbQzGz9b0DQdJYfMc8yTNVZ4NTlFR/+ExnO8F/bLoKX269NAwVZnPkp+SrrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MocxUwCRHVBVdXABYhq9Pne5NIDNAp82Db25kZ/7igU=; b=p/r4CaskQhBsu1DzFxlZoNj0qC77pIyM9FN1UFHSlWlbFG2kUQNBMJwnC79nhuUO8FsMnxqRGXdQIJFVuKv/WBCcqyp3iYCfyC0FrOyX2d2rImMWlk/dNN6+MpizX8AczfOiUKiQFOKRdkKc2OUnE+sGyORkBjFU2N3+K/2ASXk= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB4035.eurprd05.prod.outlook.com (52.133.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.31; Fri, 21 Feb 2020 07:37:32 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::e495:9258:db09:1de8]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::e495:9258:db09:1de8%7]) with mapi id 15.20.2729.032; Fri, 21 Feb 2020 07:37:32 +0000 From: Matan Azrad To: Slava Ovsiienko , "dev@dpdk.org" CC: Raslan Darawsheh , Thomas Monjalon , "ferruh.yigit@intel.com" Thread-Topic: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX Thread-Index: AQHV6DNbBpXHsyw4x02lvgLUfWJPfqglQliA Date: Fri, 21 Feb 2020 07:37:31 +0000 Message-ID: References: <1582233513-3372-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1582233513-3372-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.124.105.116] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b508910f-7de6-4bcf-2acf-08d7b6a0e963 x-ms-traffictypediagnostic: AM0PR0502MB4035:|AM0PR0502MB4035: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-forefront-prvs: 0320B28BE1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(39860400002)(346002)(136003)(366004)(189003)(199004)(55016002)(478600001)(66476007)(52536014)(81166006)(81156014)(4744005)(110136005)(66556008)(66446008)(186003)(8676002)(26005)(54906003)(64756008)(5660300002)(76116006)(6506007)(66946007)(9686003)(71200400001)(316002)(33656002)(86362001)(2906002)(4326008)(7696005)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4035; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q3/DzX5UCP6WDb6027r72PZNTGMOWj3n0Yhkb1xAwn8Lq0cvpUSRp5HqxKHCHiQ55h4Q54hAtCcGD+u3HJ6fHAS8oev51sDLXTL5W3cDco5kTTSg+CU3HOFg1Pmk3scZzxJSoHOuVzLqyACaqJDTy+H8p0luwMGnFrMGy0g4y1cFn8pwIfLdB9a6PYYn9S60x/6D2AK/AgwA276keHu1RQsksjHC9I/ZuALPBCq5zoAghEUFRUl5RLcJ6rbo54fj05ooi4hq0+yn1aOjl2wmU5hjnT80/DzL9oi7xad2hmSIyCmPLzlwPAJmF+g0/qbfIcP+9bQ/xT0Cy/DkpBP+Q8OctTdC15aHr+kA20lWvRDRhqzgt2B70fI+A7ghRjOoyliXjTWIsXFNcnh7tzGBo6bXCDZF0veYs3hsCpP9FXX4stikMp35RBEuSrghQKMz x-ms-exchange-antispam-messagedata: NqHJNdn9aTdWl9uqPcbRmOttp/lde1Wwcwm45Ga1SwPuzHhBE92A9GoONECDt+RYLUBjv1KAaGilNWU67e3DZherBkAgysuiFrPXD9PrUitr8b+AU3rQ/62lZXCUC2ka6RjbuyfKNoVDDgqS3eOJHg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b508910f-7de6-4bcf-2acf-08d7b6a0e963 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2020 07:37:32.0628 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j5nIWj3hfVxmpwBOo2ZgI6ScQTyV9kAw7K++wsooFiX/ExQBUYVmGw30pRkpxLuofTeDkRO4mfPGdedP+JN/NA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4035 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Viacheslav Ovsiienko > This patch does extra inline packet size check to tune the ConnectX-4LX > performance in the legacy Multi-Packet Write mode. >=20 > Signed-off-by: Viacheslav Ovsiienko Slava, Don't you think we want it for stable releases? Besides it: Acked-by: Matan Azrad > drivers/net/mlx5/mlx5_rxtx.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index b55db4f..0df811b 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code { > loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE) > goto pointer_empw; > if (MLX5_TXOFF_CONFIG(MPW)) { > + if (dlen > txq->inlen_send) > + goto pointer_empw; > tlen =3D dlen; > if (part =3D=3D room) { > /* Open new inline MPW session. */ > -- > 1.8.3.1