From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57BFFA0487 for ; Tue, 30 Jul 2019 11:00:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 032AA1BFE3; Tue, 30 Jul 2019 11:00:38 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150071.outbound.protection.outlook.com [40.107.15.71]) by dpdk.org (Postfix) with ESMTP id 939B91BFD1; Tue, 30 Jul 2019 11:00:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVc9TV5cWzE8iLDwf+l5sJ6G8pII1qCNGCjDPiH1hp3rJ8ZlS0Ncd5HCHmj8WUy0WxxMFNtfH53aAkA/NRn0SvojDuiUtVloWS239bOulitfSb1LfU1rdhYHlIXe+mdEifOlN5/6QLusJtRSjdvFM4uuhQ7mh7jFhxDstNMzEHhCaQhbBdqoRJ3vGhzTsKKwNQx5Rr9cgiQGs9qof8fpxjBUdipj2OVDY5y+XhBH6Q+W78divbSqE3xXe/7BLaRhbu4p7/8/7J/y/PKAnjTDdjZy9XMtwgO97iI8STS79su3yW8OpXgOt588kIkIg3OKGCtUJUdfrFSOs9klY9N4rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ChSCfgxplckZsCU4Wy7nuQIIjpQLJROO8RO4RQni0k=; b=fzyLpF3Z1VdDGc9nLczWPJmyIuGhCOmyv8KFVPp1MkXQzhnQwuLvbaEOaG/2xXlbmY7dtwI3bULnf23GAw1k1QOy6uwZccCNIBWvI0on0CHeZn8x7oW97qXUHmq28VNeWKlI1aHKU6Rk/IvJAQRWKiXtv6Pob4/i5I4aHOJebN2USKl2Hf28uIkmhUDO5Jbzi7/Glflt8j2dkbTM/wXLWmuYNnxOHteiFfZ/sP/GvrQ8ylQIyw99uWGBuEWVdF9aK2ucsTdqrXkviEAg37v+5Jw6fvJ6lo2YG9DzU9vta1cqjQMe6RA6+4UJJakilGmBda73+KsgUYmQ2ZfD/ZrmrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5ChSCfgxplckZsCU4Wy7nuQIIjpQLJROO8RO4RQni0k=; b=kcnSCSmpc+M9cwDnOfont+w9D8LSlnGLK0Ck2614x8WUofTCpl3ctk0gh8Cp7c3vZ5QRCGB2vp7JGqP6cAS8CRnhtbGOo5vaX/+lHBUlQJSAN0j0JkjZ6iYk7A36H/VWqrLQ0wfdGodLD039eTVFOytisJPY7JjJxOeRvfUGCCU= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB4002.eurprd05.prod.outlook.com (52.133.40.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Tue, 30 Jul 2019 09:00:35 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639%3]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 09:00:35 +0000 From: Matan Azrad To: Matan Azrad , Wenzhuo Lu , Jingjing Wu , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration Thread-Index: AQHVRgpa+9ZRSAK5Lk6rbcAcDUnetKbi3dBA Date: Tue, 30 Jul 2019 09:00:35 +0000 Message-ID: References: <1564403817-13438-1-git-send-email-matan@mellanox.com> In-Reply-To: <1564403817-13438-1-git-send-email-matan@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1ce7dd98-b8b4-4818-9d8b-08d714cc6290 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4002; x-ms-traffictypediagnostic: AM0PR0502MB4002: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(199004)(189003)(13464003)(53754006)(81156014)(86362001)(99286004)(14454004)(81166006)(6436002)(2501003)(76116006)(110136005)(6506007)(74316002)(66446008)(66946007)(66556008)(64756008)(66476007)(6116002)(68736007)(5660300002)(229853002)(8936002)(52536014)(102836004)(53546011)(7696005)(76176011)(478600001)(476003)(2906002)(71200400001)(71190400001)(11346002)(9686003)(66066001)(53936002)(305945005)(7736002)(33656002)(3846002)(6246003)(256004)(14444005)(316002)(186003)(25786009)(446003)(486006)(26005)(55016002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4002; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ZL574wLvHfAEDJhXSl2GFpm3+t9biP+c7DmN41EvYypylHCrmlnnAXiY3EIvpevq247jAO7OtlARbLy8mzHfMWysMMzJ1Jw14X5/kwQo3ybyuPev+0Rsivq6fbAtrIWqYtNvTbh1lVj8CJsb6bzVTAWRsLKJZK/Njj8QQtH3uG/jLb2CuecyoMxn/n4Po14DrZcxC9DH+wutWJzMVDlBQPbSxuJF8y9rO+eDby4z/suR5mxXhoWgKB2MD/IiQ5afoLpnM8VdealM4SBzOoKUJodkiEtlximtMfcVUOmxWFQIJHGU6RhdqFujlw1JF10zlObVo3NF9sth4833tPZ1yXoz0zjtR73YhnX0ZSB3a1AUSOAv3z325yFuNoQpt6xFpUbM3/1sSw6fZpEuKO4Vx+/xJOGPgsP2zHKsJeVMYKg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ce7dd98-b8b4-4818-9d8b-08d714cc6290 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 09:00:35.5393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4002 Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi all Any review? > -----Original Message----- > From: dev On Behalf Of Matan Azrad > Sent: Monday, July 29, 2019 3:37 PM > To: Wenzhuo Lu ; Jingjing Wu > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: fix scatter offload > configuration >=20 > When the mbuf data size cannot contain the maximum Rx packet length with > the mbuf headroom, a packet should be scattered in more than one mbuf. >=20 > The application did not configure scatter offload in the above case. >=20 > Enable the Rx scatter offload in the above case. >=20 > Fixes: 33f9630fc23d ("app/testpmd: create mbuf based on max supported > segments") > Cc: stable@dpdk.org >=20 > Signed-off-by: Matan Azrad > --- > app/test-pmd/testpmd.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 518865a..4ae70ef 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1191,6 +1191,17 @@ struct extmem_param { > warning =3D 1; > } > } > + if (rx_mode.max_rx_pkt_len + RTE_PKTMBUF_HEADROOM > > > + mbuf_data_size) { > + if (port->dev_info.rx_queue_offload_capa & > + DEV_RX_OFFLOAD_SCATTER) > + port->dev_conf.rxmode.offloads |=3D > + DEV_RX_OFFLOAD_SCATTER; > + else > + TESTPMD_LOG(WARNING, "Configure > scatter is" > + " needed and cannot be > configured" > + " in the port %u\n", pid); > + } > } >=20 > if (warning) > -- > 1.8.3.1