From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 627CDA00E6 for ; Wed, 7 Aug 2019 07:38:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 939FF4C88; Wed, 7 Aug 2019 07:38:45 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40089.outbound.protection.outlook.com [40.107.4.89]) by dpdk.org (Postfix) with ESMTP id 7227937A8 for ; Wed, 7 Aug 2019 07:38:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NoH643NpfTucLJSHby+jotJ6iJeAC0uC8HOUBGv9LIARK4kq40T4Xa4sKjvisHdqt9xj2GFKttO61zM+bv9UJeK/2ltjr1WORkkZqUDKAOJtwD1KxBdtcvoLucyfK5nsKZthZ4dVq0Wn4OA+UCv93jjrTcQNtEJ67vrY1zXbQ2Q1z0TS58peOmgfyo3NAMoGszywvAgACjC2RUEpXELw0qdxW5TerGXa1oz2J/jfMn2XFNMPopktSdqj0Sos5emS1jp+cnIV70rwYGakhnABGRt3K+zNbnvJhvllEUuNkYX2Cm2Y+d3ZbfTaSBLHrWYAhS0gzqgpAmwM403xW4CdwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=puA8vAzchqcIRG8D0mJAo/8cpirwXYSVJjPyUm/xV28=; b=KVYkupOYuwxbsVx//mLQsPUWxp6Sr18TuGjPkBOvz5Ed05xfGUUKlJHbwdj602l7SBhbVX3JIzkdoWlMw9CNnMLHxqmY9NevSP3dMn+PBda7U2Q49smhe+MeIv2xLausbuAqCMA3JAuQemBGbwDQuPUcALfpsHzP4zcpgxog9v7aBTeg6kTYv08tzusZ8h/nIOzH+OhtBoKSnzPJq8GaJkL1hPZQp6coSmugyIaDuKTPpQT8tTcz4IpNE+8/eepmLzuPZLazPE9iXKBS2tU8049g2vYlD/GE/CRlwFKEnsFNU2JskdNV+Cb+QNvsnTGoi5ky0FjEjkFdPf1/zobhAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=puA8vAzchqcIRG8D0mJAo/8cpirwXYSVJjPyUm/xV28=; b=sU/g5HYM9W60s/aXrdlr8KpLVOvDG/0BJTzsslWBSaPRb6AT3WrgQ9KbBVIcQ0Lk/s5GHIOvoDQ1MoaCPDH4jBq0YAcrOBCVBdtrbStSYG+3AMwURIGi25Zk0FHaxiTqEE9w9r69xuX9+iVV6wjvRbUYThjjHhQE3OROa6i05rM= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3713.eurprd05.prod.outlook.com (52.133.43.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.14; Wed, 7 Aug 2019 05:38:43 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639%3]) with mapi id 15.20.2136.010; Wed, 7 Aug 2019 05:38:43 +0000 From: Matan Azrad To: Stephen Hemminger CC: "dev@dpdk.org" , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity Thread-Index: AQHVSUphxp1Q426sqUeRhaSMjaIUiKbqqieggAIRMACAAQvgMIAAgJiAgABICsCAADV+gIAAa2JA Date: Wed, 7 Aug 2019 05:38:42 +0000 Message-ID: References: <20190726165054.24078-1-stephen@networkplumber.org> <20190802025826.1174-1-stephen@networkplumber.org> <20190802025826.1174-2-stephen@networkplumber.org> <20190802085301.02ab5b55@hermes.lan> <20190805090054.1511b033@hermes.lan> <20190806083955.59124799@hermes.lan> <20190806160913.62e0d15d@hermes.lan> In-Reply-To: <20190806160913.62e0d15d@hermes.lan> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b801332-c862-4908-8c1d-08d71af98247 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3713; x-ms-traffictypediagnostic: AM0PR0502MB3713: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 01221E3973 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(189003)(199004)(66476007)(86362001)(186003)(6116002)(3846002)(66446008)(2906002)(64756008)(81166006)(81156014)(102836004)(26005)(6916009)(229853002)(6436002)(33656002)(9686003)(76116006)(74316002)(14454004)(8936002)(53936002)(76176011)(7736002)(8676002)(66946007)(305945005)(66556008)(52536014)(53546011)(6506007)(14444005)(256004)(316002)(99286004)(6246003)(486006)(54906003)(25786009)(55016002)(4326008)(5660300002)(478600001)(71200400001)(7696005)(446003)(68736007)(476003)(11346002)(71190400001)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3713; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dCLPRTKo8q+VgXJrG9nV8SuEyEMwASL8RH1b6Ee82J6bjduMHCqhD0EO+gN5AF5zKVBqZCCS9H4jS9zzm88eWGxCoRu5U6U7kLCmYjtKYoiL7xplPuJCW+x6eL52Jh40Ko7Fpw+6y5ewCbkNOn7ZfJoF/+8EQeEE1/rfvrXXkgc7bp3bS2DnL8d19QiVjfBo2KYfbO43nLjNrt8quI6LO9E8NZbNfn7G7k1dHiK9soDeRIIZAM6qpn9iraJ09p+w+oRKj58ILoWnnoeCi616gkDaMRTzLcscBtKCRmhYad9XGduVUsXUytbDi6LHCn0XM7MAk2nLshrhibjunGzYZh5H2SuNzXSeOXcxABRhchxZwET29gvcUQo9jmI31PYEqvndfd0qNTdq4iNj1JD62v0thfVMon9oY1C8fyECuKQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b801332-c862-4908-8c1d-08d71af98247 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2019 05:38:42.9731 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3713 Subject: Re: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger=20 > Sent: Wednesday, August 7, 2019 2:09 AM > To: Matan Azrad > Cc: dev@dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH v5 1/4] > examples/multi_process/client_server_mp: check port validity >=20 > On Tue, 6 Aug 2019 20:03:22 +0000 > Matan Azrad wrote: >=20 > > > > > > The DPDK has lots of hard coded assumptions of all ports fitting in 6= 4 bits. > > > Examples include testpmd/parameters.c etc. > > > > Yes, I understand, but the user should know not to change the default > > value of RTE_MAX_ETHPORTS, at least it should be documented. > > > > > The original concept of a small set of assigned values for portid is > > > not going to scale. It really should have been more like ifindex; > > > something that is not used by common API's much larger range; and > assigned purely sequentially. > > > > > > The API's should all be using names, but the DPDK port naming is > > > also a mess... > > > > Port ID is OK, user can run port info, then to find the wanted port ID = and > configure it by port id list\bitmap. > > >=20 >=20 > The examples are toy programs. If user changes RTE_MAX_ETHPORTS it will > break lots of other places. Why put more checks in the examples. Sorry, i= t > really would not help to pretend that fixing the example is going to help= this. Agree that it is not needed to fix all the places now. It is better just to update the example documentation that RTE_MAX_ETHPORTS= must not be changed when running this application. I will ack your series(v7) , Consider to update the doc if you want to be c= ompletely perfect here. =20