From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5226FA0093; Sun, 17 May 2020 14:02:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C1391D516; Sun, 17 May 2020 14:02:37 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140079.outbound.protection.outlook.com [40.107.14.79]) by dpdk.org (Postfix) with ESMTP id DC50B1D16A; Sun, 17 May 2020 14:02:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ifA2o2YIOFkgNgr3jLZidkYvS4KjB5A5dMmlzMwbsG1mpGNJFcuvJOZNP3hY/RznyB/p8bcy8uS60kKsq+7IhkyNbFGDns83oRtvNiL2i+iawBJtUAWWCoxFBnUXW1U3/TS7m2yI1P/dSU3N924zAgxG4j9sPDjt8OuF8RPyv2AVyAhQfnaiP546VnvtU0VSVG/OSMo7IFAf9iOZz5SNfSbFd50UOjlLHkms2nhsweNE8dwSbKe1FZH77sKkoPkfLHTmn9pfVMT+j7qjAaerz/Rr/J9+uuBc4N0v9zqxUVO4umGtIXn66iccF4BwPbOam6u7bWyPadIayei7pL7xoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5CjFnWrfm6dAEwQT2ibvZ9EIyXE/8mTVtLUTR6gJhdY=; b=DnYif7WxhUKf91PraaPS1c5pMcYvtwH5YqMW3ARyLdHPxDZxNg8GpgTZ0QXHD9RjMrcsuvy8tpbq5mi1TpFAquyKCWI1p1hv7LOqvM9d6ueYBzLJC45vCWCVpDKs++DOblQOjYUyuFQNV4P0BaZPf17ZkvB7gN4CyuRDniJwkCSfGURJ15azT3cALkOMF6n5giHhV2fTdnLWGlMe05wPdQucDHu7jjhX+o9xS7iZW2xF+VWa7OH0whzTqoPDcgysbOUOqfU5zTVKdxyPh7AMsCcBsy7z3nA/wHYrr5LA+Sf4SnTfVuRTmgTsKdZlLKc9j2SFjfuaXzW7bg/cNgUZZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5CjFnWrfm6dAEwQT2ibvZ9EIyXE/8mTVtLUTR6gJhdY=; b=R6zgRyErmRKvVnUFKLiUxKiUf1RhVJTuxu0cb8ZP+Qgww6Yc43eYZp2/r6a4fi/iigVfIwjIWKtt4sl4Y7U1WRtfdua6grxjQlGM/b2ndHbIJKGAMsjppgbsZj4QFzfqfsQ68o26IoYiogyCvL6Yj7ud+5Xeer3lXcXwUSjqg30= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (2603:10a6:208:f::11) by AM0PR0502MB3634.eurprd05.prod.outlook.com (2603:10a6:208:18::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Sun, 17 May 2020 12:02:33 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998%7]) with mapi id 15.20.3000.022; Sun, 17 May 2020 12:02:33 +0000 From: Matan Azrad To: Slava Ovsiienko , "dev@dpdk.org" CC: Raslan Darawsheh , "stephen@networkplumber.org" , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "stable@dpdk.org" Thread-Topic: [PATCH v2] common/mlx5: fix netlink buffer allocation from stack Thread-Index: AQHWKb7sGHJeRc+YCU69lTIYlZYpvKisMn2A Date: Sun, 17 May 2020 12:02:33 +0000 Message-ID: References: <20200422223000.16602-1-stephen@networkplumber.org> <1589440272-8058-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1589440272-8058-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [77.126.88.104] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fe7ef84f-a405-4526-f16c-08d7fa5a2eda x-ms-traffictypediagnostic: AM0PR0502MB3634: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 040655413E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TQ/3P+5PdJnIyDzezm8ecScmD8+2Qx8D/ox4r5s8BL86xlyteB2Wrd3vA/70/uHoZJk9WMSQFEoKhWlEHWnP0bpBuHScq2+7jdgf3AXa6xUIXzCdv2pF/aByGCB7gkLh+XCziG3V10iLts4clPsTDTh5ofs0Hh4hLp9nv+q5VtvNH4WIypeIpiBxG8ik6VnnYjrjvJSqF9DCPI4jD3kosrNkk1vIkJBRObjY1IA6c9RKQ7IkXIIjFT3bB6y8HrUpSoikjjByglaJ1R/BwMDmc/gxUwXmu9azcm8+9iluC5ZGrCf2u3xRKalAr+5GZC7/xRZ5A6J62kE7Q4cRzzVJDAlC+a/xnO9cEiAL67kxfUJ/nnxjL1UI/vFLJtAN4EQO+/tBWAOBRYQ4GSaAXNk/5+/AgBsSW1r+K1ckj2lkg+BEJYo7wZY8iKuIafkMgLBQ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(396003)(39860400002)(366004)(346002)(136003)(7696005)(6506007)(8676002)(478600001)(26005)(186003)(316002)(66556008)(33656002)(66476007)(64756008)(4326008)(66446008)(66946007)(110136005)(5660300002)(54906003)(2906002)(71200400001)(9686003)(55016002)(76116006)(8936002)(52536014)(4744005)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: A0QLz7AziT6KF03rea4TnMLyH3pljB8HBc8h1P/VWSsl5hZZbINSkkgxc9DCx0HXiZJpcy0GLamaPPij06r9fwBFXNvn9qIQbGoGzgUxxEWaUyPSvaGqc/e4H4XdRVZNKWRbApq4upuEZfRIkbp3kelFUpQRf9LDvnHeTGYQSL9RXbbO5x9+CNY69FqSeTwtWg4JjukCNqbqhzy79ZpcGhzKz0vHgvlj7POCfFU1Vpgut+4pjuFH7L78EoXsG5+2fyXbfBt30Oba4/kLJcZf8xZ/NeeqXm/vudX1kCZdvhUg8cGoC94qgDNMeGJr/qTbTiQuxES0gGqNywZZYiUKxs88S/3YMoYxbd0MbXUbMnSYcNBihubAMWCsfCPoFvruKZIDBDyek1rO0vKd2qjrxJfZea7GfrCMW959X6z0TKQZpyCPoOZ9qRU3hlmPOs3Tg139y3EtJDf0p9/Xxr7zY0DfRqhpMWvWT7LH039W2jOPdBKXe2fO9ziEh7bRN/Tx Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe7ef84f-a405-4526-f16c-08d7fa5a2eda X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2020 12:02:33.5326 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Vze6VRRueOCzwlZnSXA1ee3bGJuMCDX+R359mxuKn6iC80koWFsNg/1K/a9XP3l6qITwWTZKwfGwsEt0J2lZ0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3634 Subject: Re: [dpdk-dev] [PATCH v2] common/mlx5: fix netlink buffer allocation from stack X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Viacheslav Ovsiienko > The buffer size to receive netlink reply messages is relatively large (32= K), and > it is allocated on the stack and it might break in application is using s= maller > per-thread stacks. > This patch allocates temporary buffer from heap. >=20 > Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") > Cc: nelio.laranjeiro@6wind.com > Cc: stable@dpdk.org >=20 > Reported-by: Stephen Hemminger > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad