From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3315FA00E6 for ; Mon, 5 Aug 2019 08:41:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CC6231FC; Mon, 5 Aug 2019 08:41:02 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55]) by dpdk.org (Postfix) with ESMTP id D22212BFA for ; Mon, 5 Aug 2019 08:41:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UNr1ta35bQiy0uH+sf/fVlNNdwXv1nyDXBGZxMIKxbKv7xtam1pn9RdLQAvZEzC1A7zGXo2fbyG1shyF4Dtm8eWqG5c2kIEFaIGfwcm/coPUWAcZjd0Gwz06JfcRj6XaJsEXWO/SJDyPbrfPQ1X3b5ds/PMfZS5BZ+oW3E8S2oXVplJBpIaK00S/UpfPh4xU0cWra22dwSLZfGtf8udGppmX9SIZqk1YKyrmQVS+doPMU37PWN0YDVjKdVoOfnyRqPc9DA+6wBtYDW8sH20YuUB22FgMQ6z42eywsZwkSYBsAw/9Z4XnzvketOjhvo6LURar4oAzMNn7AZCGpWHFAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hP0Exh4pJx3s9CCBEAHduq//EdSelcu4mN6vmJkaBb4=; b=Vc+bZRTUwPoA08HEvdJSirZmaqvzULmwt1pXgxQtJmpWo7y7YWUYKZ5oXsDuQdTk05t7mJi7TYyRNAuPabEBD1nqWnG9soI7VBlrLuR1cL0a5etvNkxEbU5zacqYjvgmg1SsPMCKl9UqX2wPyp8YTps6E+dAKpcMVCFRPh/91GHq0gySk/kwOf3YPu0Vp/sx4iPnfeHTwf3v+kXHojZ6w6x+pZbhSJTWqbmCcIFjCPyJohVBw1sEOif2WJIhm3ehq39XfZVr3+sfUxD59yvdpAl2RyhNY2w7AShHyDzs7NPWYRUzxtCePe74IgGta25abe0Jn4eG33P4TDHmipQpwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hP0Exh4pJx3s9CCBEAHduq//EdSelcu4mN6vmJkaBb4=; b=TxMPMTXRmy/2yf9Mg8ZGSOUXiNOU0Uh9BzwpfBwhXN+IVTGjyG256jhsqwAAOLOef/iw0orWhbnOZQ+RgYNdGvaDhG2TPKzWRBqmf/bgHIMFxWzyXdxw2PbQL9KTlBEfaGwoc9aqDSIqLj9c7uCsdCYMFNwAe+vp8a0QMt+KlXk= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3826.eurprd05.prod.outlook.com (52.133.45.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.16; Mon, 5 Aug 2019 06:40:59 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639%3]) with mapi id 15.20.2136.010; Mon, 5 Aug 2019 06:40:59 +0000 From: Matan Azrad To: Slava Ovsiienko , "dev@dpdk.org" CC: Yongseok Koh , Shahaf Shuler Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix completion request for inline packets Thread-Index: AQHVSsxpR/U5VkNJ8UuUjL0+c1NHmqbsG8iQ Date: Mon, 5 Aug 2019 06:40:59 +0000 Message-ID: References: <1564926975-31571-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1564926975-31571-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4048ec64-74e2-47a1-31cf-08d7196fe0ad x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3826; x-ms-traffictypediagnostic: AM0PR0502MB3826: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1079; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(396003)(39860400002)(346002)(376002)(189003)(199004)(66066001)(68736007)(107886003)(6246003)(14454004)(110136005)(54906003)(81166006)(81156014)(4326008)(33656002)(2906002)(316002)(478600001)(3846002)(229853002)(66946007)(64756008)(25786009)(8936002)(66476007)(6116002)(14444005)(305945005)(7736002)(446003)(11346002)(476003)(486006)(99286004)(66556008)(74316002)(76116006)(52536014)(76176011)(4744005)(256004)(71190400001)(71200400001)(66446008)(186003)(26005)(102836004)(5660300002)(6506007)(9686003)(86362001)(53936002)(6436002)(55016002)(7696005)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3826; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 08zFZNbkAhV2qaBYA7vUSHMlfz097I5+lRm4c2E7+M4lZo8EXDDMAFy/wUEjXVKTGaDujkx5i0LCm3e/EzI7RWvne9ayW5JfAJQN2DeEOcWxeHYglbjeKnrPCAvZ3s/ubt7KXJa2WbtLZfcu5M+4qfWMswJO9nqfBt7FnMGYkh4hZNTxil+xL18Tx7yGxnZwgLDmPiBLBexyv1erPOS2P2yrriiGrRoZC/WphiXRP7JnvlQFCf0opsKEWZ1xWs2sSs/xf8jO61DQcuQ1kZ5gcg9zc5XxQx5y7RT4RyFaocg/nGmBHiAt8aa6zubbc4/e8OJcDk/qJ4/UJTeLbsPVIoClm7EWhteTkMikmhjqYjXp5NnEx024znFP8GtbG8FwMZBbQYVm28yQ207UA0jaat+0SB5mTvRQNpOanOLm2Ck= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4048ec64-74e2-47a1-31cf-08d7196fe0ad X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 06:40:59.5746 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3826 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix completion request for inline packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Viacheslav Ovsiienko > If packets are completely inline the mbuf is freed immediately after data > copying and no pointer is stored into elts array to be free on completion= . This > leads the elts_head is not updated and completion request buffer counter > works incorrect. > This patch decrements the base value elts_comp used to calculate counter > threshold and completion requests flags are set more correctly on the bas= e > of MLX5_TX_COMP_THRESH value. >=20 > Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") >=20 > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad