From: Matan Azrad <matan@mellanox.com>
To: Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Ophir Munk <ophirmu@mellanox.com>,
Raslan Darawsheh <rasland@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix resetting verbs hash fields
Date: Tue, 5 May 2020 09:08:38 +0000 [thread overview]
Message-ID: <AM0PR0502MB401982A55234F793739C8E9ED2A70@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200505061607.15978-1-ophirmu@mellanox.com>
> -----Original Message-----
> From: Ophir Munk <ophirmu@mellanox.com>
> Sent: Tuesday, May 5, 2020 9:16 AM
> To: dev@dpdk.org
> Cc: Ophir Munk <ophirmu@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Matan Azrad <matan@mellanox.com>
> Subject: [PATCH v2] net/mlx5: fix resetting verbs hash fields
>
> The flow_verbs_translate() function accumulates hash fields while iterating
> through the flow items (SRC_IPV4, DST_IPV4, SRC_IPV6, DST_IPV6,
> SRC_PORT_TCP, DST_PORT_TCP, SRC_PORT_UDP, DST_PORT_UDP).
> Before this commit the dev_flow handle structure was reused in each new
> flow_verbs_translate() call, however the dev_flow->hash_fields variable
> was not reset before each call. As a result hash_fields from previous calls
> remained present in the current flow which lead to invalid combinations (e.g.
> simultaneous IPv4 and IPv6 specs). This scenario happens for example in the
> next flows sequence, when running in verbs mode (dv_flow_en=0).
>
> flow create 0 ingress group 0 pattern eth / ipv4 / end <rss actions> flow
> create 0 ingress group 0 pattern eth / ipv6 / end <rss actions>
>
> The fix is to reset dev_flow->hash_fields in flow_verbs_prepare().
>
> Fixes: e7bfa3596a0a ("net/mlx5: separate the flow handle resource")
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
next prev parent reply other threads:[~2020-05-05 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 6:38 [dpdk-dev] [PATCH v1] " Ophir Munk
2020-05-05 6:16 ` [dpdk-dev] [PATCH v2] " Ophir Munk
2020-05-05 9:08 ` Matan Azrad [this message]
2020-05-05 10:40 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB401982A55234F793739C8E9ED2A70@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=ophirmu@mellanox.com \
--cc=rasland@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).