From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 64260A04B3;
	Mon, 10 Feb 2020 10:57:22 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id CC3811BF7B;
	Mon, 10 Feb 2020 10:57:21 +0100 (CET)
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr140078.outbound.protection.outlook.com [40.107.14.78])
 by dpdk.org (Postfix) with ESMTP id AD0651B9BF
 for <dev@dpdk.org>; Mon, 10 Feb 2020 10:57:20 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=BAxOEB5Gxbp0W1y8SoB2Xny1FJcpW0jlcvnBH3/5DYvyyo8pyf0ovA2HxwbGEqdeVwGL4HdS7SRrTsfYNEdO39gReYMiRaYauMOqgJddxAdZJjB0gMyvadWmQDbgyEOZOMwVSc16LsP496Si4aRkm1odB4HPVDAU93G3GzA1Sj4pinyBzVguyEbH56H46VzJBvb1imF9bzSfGYG8/6YgYhUef0EU/ELNxuUKDZ0PelZZK+rroGt0xbo1jIs0ullZ3rP7Rm0fhw+46cVuMK3NibL+jgqvtpoahYshvbFZtIFfxuZtO0ZQfl3bxc0qfYPVjxKoIkQhSGLmY8QEhMztJw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uMhvyKtdulo99gyiwcTIJAQKvAP7KCn8fuUtPhnPk58=;
 b=BJyjwvseZR5aINDv9wyzQkcLTdrtud0XZDii1VPn7UQtVPjJJX3E2kydmEG+8qZzZFHajPQstkajlaqDqncXXKa+p/AnHKzb7VS0lc5QA4kbImlbBNP27NYBlM/M6sBfNXCm0LzCRdUXvqpJpM/MUnHjrCNkFRCHQB96wLm8G5UqGRtdzF8S+oFhYHPDX2L+YrE12Zel0yJIV6cylfyU9htbEs8FrcFv9ZSETcaYaTTZbQTB+EXnRvTJF2hHu7Iih+baSGj1P9b8GwS2Xor2XkfFZmc4Ufw2wSHEMtTPL16mvfPF1X0b0tcsyg5BFj7juej9dDfJhN3Adh4HYR1tWg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;
 dkim=pass header.d=mellanox.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=uMhvyKtdulo99gyiwcTIJAQKvAP7KCn8fuUtPhnPk58=;
 b=CdvcS1Beibs20fDxVpHzJGyd/oSfU7q4LdpueL1U8kvuppZ5F/HnsNx3TSN/tbk6+Ky/THPbhTFWK6TKtfStEj1sPEnJSGkl1HzQuhkV1TVNUjSdV3ukphTJULdky5FwL/tCCOs7v56vCSHK54l/n7bbX412pM7PtjPgoTgYJK4=
Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by
 AM0PR0502MB3922.eurprd05.prod.outlook.com (52.133.45.33) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.2707.29; Mon, 10 Feb 2020 09:57:19 +0000
Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com
 ([fe80::e495:9258:db09:1de8]) by AM0PR0502MB4019.eurprd05.prod.outlook.com
 ([fe80::e495:9258:db09:1de8%7]) with mapi id 15.20.2707.028; Mon, 10 Feb 2020
 09:57:19 +0000
From: Matan Azrad <matan@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: Shahaf Shuler <shahafs@mellanox.com>, Slava Ovsiienko
 <viacheslavo@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH] net/mlx: replace hardcoded value with macro
Thread-Index: AQHV345fbqVxYUBB4EWCwcbSzXsYLqgT965wgAAn8YCAABD+AIAAAQxg
Date: Mon, 10 Feb 2020 09:57:19 +0000
Message-ID: <AM0PR0502MB401984ADC71E33F643700282D2190@AM0PR0502MB4019.eurprd05.prod.outlook.com>
References: <20200209211725.197237-1-thomas@monjalon.net>
 <AM0PR0502MB401939E67BAD663E63371869D2190@AM0PR0502MB4019.eurprd05.prod.outlook.com>
 <7829300.5OynTdThKG@xps> <10685611.F0gNSz5aLb@xps>
In-Reply-To: <10685611.F0gNSz5aLb@xps>
Accept-Language: en-US, he-IL
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=matan@mellanox.com; 
x-originating-ip: [193.47.165.251]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 1da72cd5-dd73-4460-7186-08d7ae0f9dfc
x-ms-traffictypediagnostic: AM0PR0502MB3922:|AM0PR0502MB3922:
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM0PR0502MB39225C9ACF6284ED7897F894D2190@AM0PR0502MB3922.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2958;
x-forefront-prvs: 03094A4065
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(4636009)(39860400002)(376002)(396003)(346002)(136003)(366004)(199004)(189003)(478600001)(54906003)(6916009)(4326008)(4744005)(5660300002)(26005)(186003)(6506007)(316002)(52536014)(81166006)(33656002)(71200400001)(9686003)(66446008)(66556008)(64756008)(81156014)(66476007)(8676002)(7696005)(66946007)(86362001)(55016002)(8936002)(76116006)(2906002);
 DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3922;
 H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; A:1; MX:1; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: w/Y73qWH+NHJMAVQoAQH5O0EJYDbXmRjqno7cFVFPTGrjAkFwboVN6CjlGx1AIMxRUe/ChPGpkVCOt0x2+V9GNaMuxbXECe4m1LHL1EbtdzGHpAbr8Nd0haIldKIGibnrXN/vt1lkt//aEL7DSbA4dH8T6HzDkyFCHjnERCb99Z6SUX7B91uAhBF4+fsJDuxAi5l6JTEcNLzYHtAHAIYqNMe+Vqm5bef+KX1u+nHf/yaYsNvYhu6bAItK09VrkLqqXSCbme5M/Ib1jbUKLgGTty3pqi3wBPirt9HLJ60/f5JzyEYQOIegkXh9e9jZTdwU+xErN413zc0/JvXQrEq8XVActsk0B9RpiwaBEDsXSpN79MbYBiKeD3VRxM2eIhuQSuPREEmgGj8Q+KAYPGhBOA941n7etAeF/iJ1V4IE2hq/41FtLB6B1q2ezQoFUuI
x-ms-exchange-antispam-messagedata: GA/0thgl6WoSajEhVCJSG2cH7JNFuDsfvnX2O0ecsW/4QIcKf9a7/TPZG/Dnla1UyvxXMLiY1T9rAlzPTQgpdqO3AuE9u0yPAnP5A5x4MhBkmpSE3sBy4QTkNdoxJ0rjXI95PRV9sTPIKwe5NQxAog==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1da72cd5-dd73-4460-7186-08d7ae0f9dfc
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2020 09:57:19.2705 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yeuDkS02Tr6udD8gwLkD1BKqHRNvqU1LHgIoSOC/27hOGynHOLU9Tx9APcr1FSUBYGfLoUwiC0Kh2Epubck2pA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3922
Subject: Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



From: Thomas Monjalon
> 10/02/2020 09:52, Thomas Monjalon:
> > 10/02/2020 07:32, Matan Azrad:
> > > From: Thomas Monjalon
> > >
> > > > Replace checking against 65535 limit, with a simpler form using
> > > > RTE_MIN and UINT16_MAX macros.
> > > >
> > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > > ---
> > >
> > > No more misusing of *_MAX \ RTE_MIN\RTE_MAX in the mlx PMDs?
> >
> > Sorry I don't understand your question.
>=20
> If you are asking if there are more hardcoded constants, the answer is ye=
s
> but they are masks.
> I think the masks can remain hardcoded.

Agree.
Acked-by: Matan Azrad <matan@mellanox.com>