From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB951A046B for ; Wed, 24 Jul 2019 22:23:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0B771C24F; Wed, 24 Jul 2019 22:23:13 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00063.outbound.protection.outlook.com [40.107.0.63]) by dpdk.org (Postfix) with ESMTP id 8DDD91C239 for ; Wed, 24 Jul 2019 22:23:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D6R1xUPncuWeUcITfpGl7Jx681Nbj4GhkL5V9jGCk4iey9oSOxaG6qooL5d54BX+2E+8s8hny56PCqr9Jw6En5Qs1ZjF6Eq6+VBEQMuv5Houz5Z2mjKe/72JBjOuR/pNmJoPawSQgt4a6dCH0KYz8hqR3naV9vxjqTajnDrlONnRqzhLbou0ITwV4BmbtbqNB6TGHJN3H39dfgjLcUA4AsCiT8PeOwMKFjWe/BebnxRyDERPZ68ITxqAGc0dVE6TfbeEudIRIEKb9A69KL9ltBwyJpCzNWRVBLBmyiWXOA5Fp9JNtwhZUO3a0zJk8F8X7wDUJUuv3mjr5zLmX/Je0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JMvbHKDllWs4fkrXNM+STn6LZ5gi+wCpRo1egKSdFXU=; b=DKjILHKhhUWFt/cF2RdYeTmKdfjgngNYLydSSGMSD13pQr8aY3Et9epUMsjc34Nav3uIlZzh2VnYP6Re1kJ1iQUATfpdH+jPc3PDUJF55LC6UlJ7SKB/+QFwYatxir76xJE45UfM1310o1idXQT0PiT76qfjbm60r+nlxLXSOjsdKxe0DVhWiu57H3zFNtwbF8JBdc57b1PXpgy5mCxuWc4v8J733JAW5bb5eQ9OmbQ0a8rXSCTUvqriOlREgPxSibWha/qm5n2Z2ge33Ai8d0ntczREzUcL48WySzDTwk1VxcYlGzYBgluwRCLi8rspEvk1oYIRkX04gwhuT4qXnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JMvbHKDllWs4fkrXNM+STn6LZ5gi+wCpRo1egKSdFXU=; b=eOkXvlIT/T82M8ZDfndW7PRyddFSxRaTpHg9r2WeIkukHeQM+EDtkisJbJ+NhBbdlDOXgTDPF6o5OSda/zENJ0OTfNWWyDjKdwl5VSI0084+wjRdyXjWMvkQ5QnRkaQGYcV9K8mfgQIVXP137YtFfutqoDewKtcDzu0ercZW2/g= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB4018.eurprd05.prod.outlook.com (52.133.37.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.12; Wed, 24 Jul 2019 20:23:10 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639%3]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 20:23:10 +0000 From: Matan Azrad To: Dekel Peled , Yongseok Koh , Slava Ovsiienko , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queue release Thread-Index: AQHVQf73MMFrUKVopUOqLXfosz9Qk6baNsIb Date: Wed, 24 Jul 2019 20:23:10 +0000 Message-ID: References: <47295025fefa62288f5c59919c7f4a17b9cd4e7f.1563958186.git.dekelp@mellanox.com>, In-Reply-To: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.127.47.140] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9d98d23a-fa38-4e23-ad98-08d71074bf4c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4018; x-ms-traffictypediagnostic: AM0PR0502MB4018: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(346002)(366004)(39860400002)(136003)(376002)(189003)(199004)(8936002)(76176011)(102836004)(256004)(7696005)(54906003)(186003)(68736007)(76116006)(7736002)(25786009)(33656002)(81156014)(6506007)(6436002)(91956017)(606006)(86362001)(26005)(478600001)(74316002)(476003)(14454004)(45080400002)(81166006)(6636002)(54896002)(486006)(5660300002)(55016002)(2906002)(53936002)(9686003)(6306002)(316002)(6116002)(6246003)(236005)(4326008)(3846002)(64756008)(99286004)(446003)(66946007)(66446008)(110136005)(66556008)(71190400001)(71200400001)(66476007)(52536014)(229853002)(11346002)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4018; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: wmLeKcwT3FhDl1+m9RDzqVAoTk1+bNmzof4VR1CGgSf/AWOiTjP9oOm2cGbivdqncMdL3TFvGf6D4yLAPz8wEOmJ8oC1UgklBtdswjqfegwtprwWBC64aCuSS9F4J6tRpvEUO3neelOzzIHeQGz/Lk336GxPm2aAWmZmEKAKDgtl5lXXSGBvFhAajxzfMaigB+1fDZc2BegXk8ZjUARZRV82+GgjO2ZNw9yeHGApySQnjsGVyZDQlkFd9IxgL0eRuxFJJlZh/qaLhdMq23Tu/cA55/poDw1OrPqiNj236VLxWkcT8ILlIyrCvw2JBH6YEqVGIRouRTPuNkTMvlSRkvCNrFm3SMpOa+1n2G8uIXijVILbF5hhe3qTlgbEj48QgK36eLqgqKvTUYZ3sq0bglJwg8/qm/2/TQG+iEN/rso= MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d98d23a-fa38-4e23-ad98-08d71074bf4c X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 20:23:10.5989 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4018 Content-Type: text/plain; charset="iso-8859-8-i" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx queue release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" =E4=F9=E2 =E0=FA Outlook =F2=E1=E5=F8 Android =EE=E0=FA: Dekel Peled =F0=F9=EC=E7: =E9=E5=ED =F8=E1=E9=F2=E9, 24 =E1=E9=E5=EC=E9, 12:05 =F0=E5=F9=E0: [dpdk-dev] [PATCH v3] net/mlx5: fix doorbell release on Rx qu= euerelease =E0=EC: Yongseok Koh, Slava Ovsiienko, Shahaf Shuler =F2=E5=FA=F7: Ori Kam, dev@dpdk.org Function mlx5_rxq_release() calls mlx5_release_dbr() to release the doorbell allocated for this Rx queue. This call is relevant only for Rx queue objects created using DevX API. This patch adds the required check, to call mlx5_release_dbr() only when relevant. It also updates mlx5_release_dbr() to use the input offset correctly. Fixes: 13f4e1b32137 ("net/mlx5: create advanced RxQ using new API") --- v3: Use adequate 'Fixes' reference. --- Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5_rxq.c | 6 ++++-- drivers/net/mlx5/mlx5_rxtx.h | 1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 617f5ee..ad0883d 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -1460,6 +1460,7 @@ struct mlx5_dev_spawn_data { rte_free(page); } else { /* Mark in bitmap that this door-bell is not in use. */ + offset /=3D MLX5_DBR_SIZE; int i =3D offset / 64; int j =3D offset % 64; diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index b225055..c9df8b0 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -1242,6 +1242,7 @@ struct mlx5_rxq_obj * goto error; rxq_ctrl->dbr_offset =3D dbr_offset; rxq_ctrl->dbr_umem_id =3D dbr_page->umem->umem_id; + rxq_ctrl->dbr_umem_id_valid =3D 1; rxq_data->rq_db =3D (uint32_t *)((uintptr_t)dbr_page->dbrs= + (uintptr_t)rxq_ctrl->dbr_of= fset); } @@ -1829,8 +1830,9 @@ struct mlx5_rxq_ctrl * if (rxq_ctrl->obj && !mlx5_rxq_obj_release(rxq_ctrl->obj)) rxq_ctrl->obj =3D NULL; if (rte_atomic32_dec_and_test(&rxq_ctrl->refcnt)) { - claim_zero(mlx5_release_dbr(dev, rxq_ctrl->dbr_umem_id, - rxq_ctrl->dbr_offset)); + if (rxq_ctrl->dbr_umem_id_valid) + claim_zero(mlx5_release_dbr(dev, rxq_ctrl->dbr_umem= _id, + rxq_ctrl->dbr_offset)); mlx5_mr_btree_free(&rxq_ctrl->rxq.mr_ctrl.cache_bh); LIST_REMOVE(rxq_ctrl, next); rte_free(rxq_ctrl); diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h index 928d6c3..60d871c 100644 --- a/drivers/net/mlx5/mlx5_rxtx.h +++ b/drivers/net/mlx5/mlx5_rxtx.h @@ -184,6 +184,7 @@ struct mlx5_rxq_ctrl { struct mlx5_priv *priv; /* Back pointer to private data. */ unsigned int socket; /* CPU socket ID for allocations. */ unsigned int irq:1; /* Whether IRQ is enabled. */ + unsigned int dbr_umem_id_valid:1; /* dbr_umem_id holds a valid valu= e. */ uint32_t flow_mark_n; /* Number of Mark/Flag flows using this Queu= e. */ uint32_t flow_tunnels_n[MLX5_FLOW_TUNNEL]; /* Tunnels counters. */ uint32_t wqn; /* WQ number. */ -- 1.8.3.1