From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCFAFA00E6 for ; Tue, 6 Aug 2019 20:50:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB3964C96; Tue, 6 Aug 2019 20:50:14 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70073.outbound.protection.outlook.com [40.107.7.73]) by dpdk.org (Postfix) with ESMTP id CDA0C4C8F for ; Tue, 6 Aug 2019 20:50:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HFRu7GZkZPVuw+qKlsEjDZtZqAEkhW0zsCmsE+IuR3JHqgRJaqaikrdqjMH9HUYFhms5/kMBE1V9lQBJMFfW4yEQ2ZFyKqU8JsFFBrOPAkAjSB1Pc93UBW/MhJ2xe57nnwm5Yey6Ty87IW606S6f/ld96cejnVVA57fQLYqz56Oq9tJLv4GK3UhuJXnr/EJrV3FRx1zgQCeD86z6Qs6LwOtJ7hTecYVM+t55bwcnNz1Gon46x915qfhJyPqeb85bjA0LMxOQ0vH65co0kWoDvpuLwC1BAg3ew58MLbMBG/fRJfrpYc2PP7lEyX/mQokbevz4VHL/ErAgQk56NR0pxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=69KrNmq1oac4mUH2/ZwPrLKpBO/bcJWiSDbrJfSKrKU=; b=VlEN8KBNZr4Q+8RwcmyFdOSbwKs9Tryd96uiz/vyJd1YGvtj/WXzNKnhRlu2jWUdqH1yuv8cehQV04+hGTJ6BJ2N+aN8WRV8n+ysS0AjCUQDOT/hDVjQV9b2+rJuXf0VgDNUkKc0lsO6/kTPO0x4hjfSui3m37LNoOIRRgDCvETsHhJ8wUTLdcCD68JMMOQmbUILJcyxj582Be/Nm88VvYgcGsajJdN7rGPGh0QvF5ifq0Em8XpFmJ0JXbBeQbIyFuQQYCPwwdXduCXKEddSo8YnY3x/vz7b13l0pNNoXkdkgZrWhSMkiU9uWQKchkug1jjlhJSCusbBuOm5p/e84A== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=69KrNmq1oac4mUH2/ZwPrLKpBO/bcJWiSDbrJfSKrKU=; b=eVNkw4r+6dUTbtRTS3r0+t6x4ISool369GPL6uINIBi0u7cTJqe810wCJRu+sw9jpAavKg80eUUipXSN3NBXHJOWMHo440bZ7Po+xWqy4imhmjRETRtcrIoa7n9ivKBft0K5ukYeRqV6Oe1AJY23PEHDkG5UbD/1gp3yBms35+U= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB4003.eurprd05.prod.outlook.com (52.133.33.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.16; Tue, 6 Aug 2019 18:50:10 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639%3]) with mapi id 15.20.2136.010; Tue, 6 Aug 2019 18:50:10 +0000 From: Matan Azrad To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , Olivier Matz Thread-Topic: [PATCH 2/2] doc: announce new mbuf field for LRO Thread-Index: AQHVTHA1m/9TJlXicUS/FSlQ1Ewcz6buck4g Date: Tue, 6 Aug 2019 18:50:10 +0000 Message-ID: References: <1565103383-23864-1-git-send-email-matan@mellanox.com> <1565103383-23864-2-git-send-email-matan@mellanox.com> <2601191342CEEE43887BDE71AB9772580168A62AC0@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580168A62AC0@irsmsx105.ger.corp.intel.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.126.64.114] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bf650ed2-eb9f-4e88-41cb-08d71a9ee8c3 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4003; x-ms-traffictypediagnostic: AM0PR0502MB4003: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0121F24F22 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(189003)(199004)(13464003)(74316002)(110136005)(6506007)(66066001)(86362001)(478600001)(4326008)(7696005)(53936002)(14454004)(54906003)(55016002)(53546011)(305945005)(316002)(256004)(9686003)(186003)(6116002)(3846002)(6436002)(76176011)(6246003)(7736002)(25786009)(102836004)(446003)(486006)(8936002)(99286004)(76116006)(66946007)(71190400001)(476003)(11346002)(71200400001)(8676002)(229853002)(81156014)(68736007)(2906002)(66556008)(64756008)(66476007)(66446008)(81166006)(5660300002)(33656002)(2501003)(52536014)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4003; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BIzoJZv1gsUqr2LN9OuyXJKc+6zuSG8zjxqXE7zyI0B0SEjncXiiOruKvInvugKKqVMfC1XsxvwmlY+lybEevBxhloCsRc5OzZaPqwyE6gsuCA+QsDme2zNnqhIj9g66aWk2SohlIt2FCDjQRq6lsSsZgg/SYAhENYg7FfYnq/sFPzxSzI6WxLKAHtbGj2Edz/GWJ+sWA7uELX3emRy3Nbtd6PVx+h6dQBcwpmuRvkxEUw/dWUlDN8R6XAGre3Tof3Sv2tpFmRmk3mC4G21Zq3JIgN1mQTvQCVOBSiF1zxsTGvaC5umsdKiwWgdw0Crrs6ZoGlCNaYY1vwHI9u0SfVmnLo3J5l6Qv5WFmjYcCNWF3LuhPeK5EW9XIu+Bi0gui7l/o5mC8s3bmplgorPaqmIaF0261Csh3GgObAYzhwk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf650ed2-eb9f-4e88-41cb-08d71a9ee8c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2019 18:50:10.7560 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4003 Subject: Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi From: Ananyev, Konstantin > > -----Original Message----- > > From: Matan Azrad [mailto:matan@mellanox.com] > > Sent: Tuesday, August 6, 2019 3:56 PM > > To: dev@dpdk.org > > Cc: Thomas Monjalon ; Yigit, Ferruh > > ; Andrew Rybchenko > > ; Ananyev, Konstantin > > ; Olivier Matz > > Subject: [PATCH 2/2] doc: announce new mbuf field for LRO > > > > The API breakage is because the ``tso_segsz`` field was documented for > > LRO. > > > > The ``tso_segsz`` field in mbuf indicates the size of each segment in > > the LRO packet in Rx path and should be provided by the LRO packet > > port. > > > > While the generic LRO packet may aggregate different segments sizes in > > one packet, it is impossible to expose this information for each > > segment by one field and it doesn't make sense to expose all the > > segments sizes in the mbuf. > > > > A new field may be added as union with the above field to expose the > > number of segments aggregated in the LRO packet. > > > > Signed-off-by: Matan Azrad > > --- > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index c0cd9bc..e826b69 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -45,6 +45,10 @@ Deprecation Notices > > - ``eal_parse_pci_DomBDF`` replaced by ``rte_pci_addr_parse`` > > - ``rte_eal_compare_pci_addr`` replaced by ``rte_pci_addr_cmp`` > > > > +* mbuf: Remove ``tso_segsz`` mbuf field providing for LRO support. > > +Use union > > + block for the field memory to be shared with a new field > > +``lro_segs_n`` > > + indicates the number of segments aggregated in the LRO packet. > > + >=20 > Wonder how the upper layer will use that information (except for stats)? > Could you guys provide any examples? 1. Stats, allow to calc accurate PPS.=20 2. Supply accurate information unlike the seg size which cannot be accurate= . 2. Let the user all the information (segs num allow an average seg size cal= culation) > Also what PMD should do if HW does supports LRO, but doesn't provide that > information? If the PMD knows all the segments size he can calculate it, no? 0 means PMD doesn't support it.=20 =20 > > * dpaa2: removal of ``rte_dpaa2_memsegs`` structure which has been > replaced > > by a pa-va search library. This structure was earlier being used for= holding > > memory segments used by dpaa2 driver for faster pa->va translation. > > This > > -- > > 1.8.3.1