From: Matan Azrad <matan@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Yongseok Koh <yskoh@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix inline data len assert condition
Date: Thu, 1 Aug 2019 21:18:19 +0000 [thread overview]
Message-ID: <AM0PR0502MB4019D490F12B96319C90D494D2DE0@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1564645437-13264-1-git-send-email-viacheslavo@mellanox.com>
From: Viacheslav Ovsiienko
> The debug assert wrongly triggers on the inline data 18B, this should be
> passed successfully.
>
> Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 7a2e153..7110946 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -2626,7 +2626,7 @@ enum mlx5_txcmp_code {
> sizeof(struct rte_vlan_hdr) +
> 2 * RTE_ETHER_ADDR_LEN),
> "invalid Ethernet Segment data size");
> - assert(inlen > MLX5_ESEG_MIN_INLINE_SIZE);
> + assert(inlen >= MLX5_ESEG_MIN_INLINE_SIZE);
> es->inline_hdr_sz = rte_cpu_to_be_16(inlen);
> pdst = (uint8_t *)&es->inline_data;
> if (MLX5_TXOFF_CONFIG(VLAN) && vlan) {
> --
> 1.8.3.1
prev parent reply other threads:[~2019-08-01 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 7:43 Viacheslav Ovsiienko
2019-08-01 21:18 ` Matan Azrad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4019D490F12B96319C90D494D2DE0@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).