From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3906AA10DA for ; Thu, 1 Aug 2019 23:18:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 83FB21C1C7; Thu, 1 Aug 2019 23:18:28 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10050.outbound.protection.outlook.com [40.107.1.50]) by dpdk.org (Postfix) with ESMTP id 1ECA51C1BD for ; Thu, 1 Aug 2019 23:18:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FM+AxumeQOKpzYW1j74a8rL9HcXE6ZLBkpIGXftKAHuRnZEGpvGHqX+OAPD07dKJMwrbwX5PeCpF/GrZbDLwR35p0KeE/O/Nf/UjqmRGwlOyFSltPm2DO5a8OpJFuPtBqCMf7Av8lk9FYa2/EIQzPE2BwWWAIu017PPd7g9GlwxwuhNs8gk14Xl55fC7YOQznTFKZ8DPjiLbM08bY+qCv0RNUxMQYlNtyGSdSTDfja8v6AF0OL/5T2E3Bbhu9AkgHXEX1nz17JC/plqIyUeRMoQBEv1edwNr4etPB+4BATWSKce25ehZHjJDH0J6G8E0rgmUdRgyxbKYlS73jpD52Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vsiD2uDe4OKSi8R1mM9YQabHEi9AMXR8Ie+POMrDdXk=; b=nfFuU7oyFs9AV6hQnvmaWGyUpMv5VgqAjLW1/bV2Dzy91q+FabAD0IUK99W9qvAy4a6hpw0CXXQXfLlK72hyGBhVP6+ClHMMcIgUns32wpZ/tbTzyxsPcnSzFB5u89u6GxZxugR7w/oLlMycqBsh0pohTfNvEg0vI+vg/qzlxEVl3pn9ELbPo7ZWZiexh0FHg8/sEahHMas6sfRltxiek3wgzn9CUHOVuPvlfWWThdjE/qAab3Z42DiUr4tnjQIzyfEwrHDVgqOvUsdlpsQyjlBuMsNfIzOZRuWCJOzLu/V23wRe/FhQjM45u2Wk3kdqhPICMC9TqdJzoYWdXswNrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vsiD2uDe4OKSi8R1mM9YQabHEi9AMXR8Ie+POMrDdXk=; b=D8qog5WrRghZq3JlVlJaQM28JqkFt/BZkD6YB59MCkgEZITBxZ83yeys3jsbqIvETPGX86XCvxV+6NeXuAyeHYiPL3LxyCQx6v8kPvuImeQv/fQ4VbU2gOyim5GF8yXl/Z9w0pZCHMJAsLS0/UBXv/26mIM0Q+ijcY36q1Pl9rU= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3860.eurprd05.prod.outlook.com (52.133.51.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.15; Thu, 1 Aug 2019 21:18:20 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639%3]) with mapi id 15.20.2136.010; Thu, 1 Aug 2019 21:18:20 +0000 From: Matan Azrad To: Slava Ovsiienko , "dev@dpdk.org" CC: Yongseok Koh , Shahaf Shuler Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix inline data len assert condition Thread-Index: AQHVSDzlJHZ+a+2/G0WUmiXs74iHuqbmzI3A Date: Thu, 1 Aug 2019 21:18:19 +0000 Message-ID: References: <1564645437-13264-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1564645437-13264-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.126.64.114] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60d0fe78-3d14-47b6-9e1a-08d716c5c719 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3860; x-ms-traffictypediagnostic: AM0PR0502MB3860: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-forefront-prvs: 01165471DB x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(199004)(189003)(6436002)(107886003)(7736002)(186003)(110136005)(26005)(86362001)(81156014)(229853002)(81166006)(486006)(6246003)(11346002)(8676002)(33656002)(316002)(8936002)(476003)(4326008)(71200400001)(76176011)(71190400001)(25786009)(7696005)(55016002)(446003)(99286004)(102836004)(54906003)(9686003)(3846002)(53936002)(6116002)(6506007)(66946007)(478600001)(14454004)(14444005)(2906002)(2501003)(68736007)(66066001)(74316002)(305945005)(66476007)(76116006)(66446008)(66556008)(64756008)(4744005)(256004)(5660300002)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3860; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: eI0K4fr066Ck3pWJo1TsyUQHCEjUVRfFhezELwPb7mVv4B+/Xv3B38870ig64XSbGNgsX09iEv7F8DIl5YGeGthKNJFpVr232qAcK3T2M3iFEU5921djVgyQAlqI5l6GxftiYXi+HzFOHXPC5/TI4OAXSnjuHXc5n1sqEWZMeM2eO/pnHqCh2LKm3LVVgANMUdEX/qUFxXfTlw4cdT6xnTznLBgSRo2PheqPrCu5rgfSk/T6mCVRO1Z28SGzuZf7sIXqu6hKdGecIpzS7XiM+38Zmjy36Nmabg8c610CBSG2tSDP3o8i0Ryh4Jt7n3YRcKK+tzUMDEKOseMEoUWWrXvlAUpyp8zyqIZOOGF+umzJBUBx1WVghtNx842zmHCZt6rr31JvB0aPM6mP0EhtndU/2zBaCxSTbwTzClFewiw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60d0fe78-3d14-47b6-9e1a-08d716c5c719 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2019 21:18:19.9208 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3860 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix inline data len assert condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Viacheslav Ovsiienko > The debug assert wrongly triggers on the inline data 18B, this should be > passed successfully. >=20 > Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") >=20 > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 7a2e153..7110946 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -2626,7 +2626,7 @@ enum mlx5_txcmp_code { > sizeof(struct rte_vlan_hdr) + > 2 * RTE_ETHER_ADDR_LEN), > "invalid Ethernet Segment data size"); > - assert(inlen > MLX5_ESEG_MIN_INLINE_SIZE); > + assert(inlen >=3D MLX5_ESEG_MIN_INLINE_SIZE); > es->inline_hdr_sz =3D rte_cpu_to_be_16(inlen); > pdst =3D (uint8_t *)&es->inline_data; > if (MLX5_TXOFF_CONFIG(VLAN) && vlan) { > -- > 1.8.3.1