From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C12E8A00C2; Sun, 17 May 2020 07:51:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 243B61D59E; Sun, 17 May 2020 07:51:09 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40063.outbound.protection.outlook.com [40.107.4.63]) by dpdk.org (Postfix) with ESMTP id 64DC31D58E for ; Sun, 17 May 2020 07:51:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i603hzVkrDiWfw0/AylQ6YGguqOtzu9Sb4mLPlMMBnGh5sxtzQsEqXT/9aHhz56Y7OpsIFukEZQbsIM+3QdOqK0ojzUz6KbzTlpBSxp0BIe5LCxrORbLUlsGzbS3QvjCHl+SS8vScbwG8Rw6GLbBVnpSqBo5A+6PYsogTMIHYCGGPqIT5XV35psBMfcT6mXIAAZj6XPCuyossWvym3kncTYdnNyxpscJ51TJdTw/6ZeuHjLS5W65iuXDnaxDeupbRrbsflL2RNs+z4bomCej+iUUeon/do0MMZg4G27bSoCDgbX5BTMvjUdQTuCvBSX5SOwFS30k5+sTBpNhX0KY0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x6xh6wM942qtavDcTaxrOCQujz3r6j/58izjhMmTHr4=; b=fmwE5VS+I/t28OC5ORj7JFh5mToYrL8beRH3yntkvvxnYjqkroLurOjQvHiqHjjhfGo14F6N8Gj66Z4QN0LsWo9Y9YLAtd28b7jnZo7wYrwW4VUWuKJdo71b+P8RImzyMQoGlsvLJZSxBdBHZ+IvXHcA2rk4u9XoKY3KxZv8KCfV05/pkpaSK5reBc1gC/DNPg8ncLJQRz1XkGUQF/Q/8PbCrey8+wvXH8xS8FcyJY/fyF/a5cNU5W+xG2ilsaM/4iiWNhaDII+atWIIERe7CN6vC8Ir20Lp4CVlv6JS3qz4ciUe2HtlL5sAAqWlhl3gtkgwKlOtmmMdXg0aYKLU5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x6xh6wM942qtavDcTaxrOCQujz3r6j/58izjhMmTHr4=; b=bcsL79LQvoKE+WuHfhkM28GZAe0GwGtgIyd7IK1oHpSAcCRm5iks0ahEAQ5cFg6MUdakq+jVZhi0c/nrai8YNCfy6Zs/+nR2k2kx6NMb1iwPjBsrBc2aAw7zlJ0mvtwRKSN+/fehlVujUUMpqW0jYLrTk21ehHhFfNRvmOjWrio= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (2603:10a6:208:f::11) by AM0PR0502MB3683.eurprd05.prod.outlook.com (2603:10a6:208:25::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.27; Sun, 17 May 2020 05:51:07 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998%7]) with mapi id 15.20.3000.022; Sun, 17 May 2020 05:51:07 +0000 From: Matan Azrad To: Suanming Mou , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" , Raslan Darawsheh Thread-Topic: [PATCH] net/mlx5: fix shared counter search with nested index Thread-Index: AQHWKpPkYDswDbSVtkOedL5uZ6Dcr6iryBeA Date: Sun, 17 May 2020 05:51:06 +0000 Message-ID: References: <1589531763-320086-1-git-send-email-suanmingm@mellanox.com> In-Reply-To: <1589531763-320086-1-git-send-email-suanmingm@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [77.126.88.104] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c5c8939d-7014-4ba6-d4ae-08d7fa264b0f x-ms-traffictypediagnostic: AM0PR0502MB3683: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-forefront-prvs: 040655413E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QMZisoNdLptueNer6s11meLcXbeHYwI443Zsmy5Taa8bjsXkLBATMArWUHZTMvdYsc8Hcz0Fdlr/ShDEXAoad93dCNWJj9nkyYEOdPU3sVwmU7s/LxSY3P4oe+8kg9Bw4UiQh2rjKYpLr2GW08SxlFdEs+Y86ZzbgSoAJU5H5QlA8vOUg81vGkFzABUVFLHM4I4dVPwErRf0FxD/fr+4nuQmni+mkk7zgGOU38HMZvT7ixSUn6bQgjy/dx/f4uJwhoVL1HIx12//QkIgahdWaeyDRCu7OYkWyr6mlI5GozvoAHvD3iHAj96FDdMFGB62+LVAGr/arSKV45L7pGzAhGNRT6qX9MqtfGYwbIVdiSwsNwijTTm09vjhSvQBlKh5LicK9KzOiKWTzshYK7brdGF4RXEgmWd/Yscp4DedvsQ6aRZ9E6VDeIP1Gay5wToA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(39850400004)(396003)(376002)(346002)(366004)(66556008)(66476007)(66446008)(64756008)(66946007)(54906003)(86362001)(316002)(4326008)(5660300002)(478600001)(9686003)(55016002)(52536014)(76116006)(8676002)(8936002)(2906002)(26005)(107886003)(186003)(71200400001)(6636002)(33656002)(7696005)(6506007)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: m8vZ9It7iIfTpNuj2tQFSOoNF5IY/yYLxWs7QD0n4e/RI3yBLeUc4ipUi6tHtmcZIS0LpS/2NUmthdaTaY8PR9hRQbXYYilf+0nuUBkLcM6nR3LEjRBLeXNVLpnQAC7+vbNN49qyQPytOVUYCVHhNNfDY+2kgArFq7jbOd2xwmYck5EoHkB8puZNfmWIa0wyJ0Z9/GHyWfyNeWLCezGpic1nh2bTZumX8omIYJi5jcMB7oNbLGzEuumtuQLqCO3u3xKy6fNRCyxfXJNlGBeJfKRjjN1jdo/pdO28rTS0jxsGMgzGQSrlHQ/uum6mCUQgFy50wGlHhmqXGzIiEzTX2KRhexPjh+IPM/ch7oWDuA54Cej/UyJ1FykgIePhfCe3Lz5p8UPUTmWZASsT/LlIKrjHrqJRp2E+LzX6V1E+s9kYlBk1JtBQEm9EzcXYAdP07STUJlWSsEAewUBG7qtzVoa3kmGzTMByxgqeZMW3j+c= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5c8939d-7014-4ba6-d4ae-08d7fa264b0f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2020 05:51:06.9425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I0lyDnbPK0P36k1KVIGjvgr8mpT67fwJgChsC1mSkfHoD23ZO8BQcDrjvZQFJu8ANJ0DRfYm+VjB8999Hsg0dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3683 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix shared counter search with nested index X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Suanming Mou: > Currently, the shared counter search uses the wrong nested index which is > used by the pool index. The incorrect nested index using causes the searc= h > go to incorrect counter pool is not existed. >=20 > Add the counter index to fix the incorrect nested use case. >=20 > Fixes: 4001d7ad26d4 ("net/mlx5: change Direct Verbs counter to indexed") >=20 > Signed-off-by: Suanming Mou > Acked-by: Viacheslav Ovsiienko Suggested title: net/mlx5: fix shared counter lookup Other than that: Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow_dv.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 71da5fb..deb4469 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -4467,15 +4467,15 @@ struct field_modify_info modify_tcp[] =3D { > flow_dv_counter_shared_search(struct mlx5_pools_container *cont, > uint32_t id, > struct mlx5_flow_counter_pool **ppool) { > - static struct mlx5_flow_counter_ext *cnt; > + struct mlx5_flow_counter_ext *cnt; > struct mlx5_flow_counter_pool *pool; > - uint32_t i; > + uint32_t i, j; > uint32_t n_valid =3D rte_atomic16_read(&cont->n_valid); >=20 > for (i =3D 0; i < n_valid; i++) { > pool =3D cont->pools[i]; > - for (i =3D 0; i < MLX5_COUNTERS_PER_POOL; ++i) { > - cnt =3D MLX5_GET_POOL_CNT_EXT(pool, i); > + for (j =3D 0; j < MLX5_COUNTERS_PER_POOL; ++j) { > + cnt =3D MLX5_GET_POOL_CNT_EXT(pool, j); > if (cnt->ref_cnt && cnt->shared && cnt->id =3D=3D id) { > if (ppool) > *ppool =3D cont->pools[i]; > -- > 1.8.3.1