From: Matan Azrad <matan@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Shahaf Shuler <shahafs@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx: allow build only on Linux
Date: Mon, 8 Jul 2019 10:08:41 +0000 [thread overview]
Message-ID: <AM0PR0502MB4019E43425644ABFA0EB1D4CD2F60@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20190708071804.15167-1-thomas@monjalon.net>
From: Thomas Monjalon <thomas@monjalon.net>
> Currently mlx4/mlx5 support only Linux.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Matan Azrad <matan@mellanox.com>
> drivers/net/mlx4/meson.build | 11 +++++++++--
> drivers/net/mlx5/meson.build | 10 +++++++++-
> 2 files changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
> index 5de04b70b..028cd97fa 100644
> --- a/drivers/net/mlx4/meson.build
> +++ b/drivers/net/mlx4/meson.build
> @@ -2,6 +2,13 @@
> # Copyright 2018 6WIND S.A.
> # Copyright 2018 Mellanox Technologies, Ltd
>
> +if not is_linux
> + build = false
> + reason = 'only supported on Linux'
> + subdir_done()
> +endif
> +build = true
> +
> pmd_dlopen = (get_option('ibverbs_link') == 'dlopen') LIB_GLUE_BASE =
> 'librte_pmd_mlx4_glue.so'
> LIB_GLUE_VERSION = '18.02.0'
> @@ -13,9 +20,9 @@ if pmd_dlopen
> '-
> DMLX4_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
> ]
> endif
> +
> libnames = [ 'mnl', 'mlx4', 'ibverbs' ] libs = [] -build = true foreach
> libname:libnames
> lib = dependency('lib' + libname, required:false)
> if not lib.found()
> @@ -28,7 +35,7 @@ foreach libname:libnames
> reason = 'missing dependency, "' + libname + '"'
> endif
> endforeach
> -# Compile PMD
> +
> if build
> allow_experimental_apis = true
> ext_deps += libs
> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
> index 326d1a369..3eff22e4d 100644
> --- a/drivers/net/mlx5/meson.build
> +++ b/drivers/net/mlx5/meson.build
> @@ -2,6 +2,13 @@
> # Copyright 2018 6WIND S.A.
> # Copyright 2018 Mellanox Technologies, Ltd
>
> +if not is_linux
> + build = false
> + reason = 'only supported on Linux'
> + subdir_done()
> +endif
> +build = true
> +
> pmd_dlopen = (get_option('ibverbs_link') == 'dlopen') LIB_GLUE_BASE =
> 'librte_pmd_mlx5_glue.so'
> LIB_GLUE_VERSION = '19.05.0'
> @@ -13,9 +20,9 @@ if pmd_dlopen
> '-
> DMLX5_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
> ]
> endif
> +
> libnames = [ 'mlx5', 'ibverbs' ]
> libs = []
> -build = true
> foreach libname:libnames
> lib = dependency('lib' + libname, required:false)
> if not lib.found()
> @@ -28,6 +35,7 @@ foreach libname:libnames
> reason = 'missing dependency, "' + libname + '"'
> endif
> endforeach
> +
> if build
> allow_experimental_apis = true
> ext_deps += libs
> --
> 2.21.0
next prev parent reply other threads:[~2019-07-08 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 7:18 Thomas Monjalon
2019-07-08 9:16 ` Bruce Richardson
2019-07-08 10:08 ` Matan Azrad [this message]
2019-07-08 11:31 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4019E43425644ABFA0EB1D4CD2F60@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).