* [dpdk-dev] [PATCH] net/mlx: allow build only on Linux
@ 2019-07-08 7:18 Thomas Monjalon
2019-07-08 9:16 ` Bruce Richardson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-07-08 7:18 UTC (permalink / raw)
To: Matan Azrad, Shahaf Shuler, Yongseok Koh, Viacheslav Ovsiienko; +Cc: dev
Currently mlx4/mlx5 support only Linux.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/net/mlx4/meson.build | 11 +++++++++--
drivers/net/mlx5/meson.build | 10 +++++++++-
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
index 5de04b70b..028cd97fa 100644
--- a/drivers/net/mlx4/meson.build
+++ b/drivers/net/mlx4/meson.build
@@ -2,6 +2,13 @@
# Copyright 2018 6WIND S.A.
# Copyright 2018 Mellanox Technologies, Ltd
+if not is_linux
+ build = false
+ reason = 'only supported on Linux'
+ subdir_done()
+endif
+build = true
+
pmd_dlopen = (get_option('ibverbs_link') == 'dlopen')
LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
LIB_GLUE_VERSION = '18.02.0'
@@ -13,9 +20,9 @@ if pmd_dlopen
'-DMLX4_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
]
endif
+
libnames = [ 'mnl', 'mlx4', 'ibverbs' ]
libs = []
-build = true
foreach libname:libnames
lib = dependency('lib' + libname, required:false)
if not lib.found()
@@ -28,7 +35,7 @@ foreach libname:libnames
reason = 'missing dependency, "' + libname + '"'
endif
endforeach
-# Compile PMD
+
if build
allow_experimental_apis = true
ext_deps += libs
diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
index 326d1a369..3eff22e4d 100644
--- a/drivers/net/mlx5/meson.build
+++ b/drivers/net/mlx5/meson.build
@@ -2,6 +2,13 @@
# Copyright 2018 6WIND S.A.
# Copyright 2018 Mellanox Technologies, Ltd
+if not is_linux
+ build = false
+ reason = 'only supported on Linux'
+ subdir_done()
+endif
+build = true
+
pmd_dlopen = (get_option('ibverbs_link') == 'dlopen')
LIB_GLUE_BASE = 'librte_pmd_mlx5_glue.so'
LIB_GLUE_VERSION = '19.05.0'
@@ -13,9 +20,9 @@ if pmd_dlopen
'-DMLX5_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
]
endif
+
libnames = [ 'mlx5', 'ibverbs' ]
libs = []
-build = true
foreach libname:libnames
lib = dependency('lib' + libname, required:false)
if not lib.found()
@@ -28,6 +35,7 @@ foreach libname:libnames
reason = 'missing dependency, "' + libname + '"'
endif
endforeach
+
if build
allow_experimental_apis = true
ext_deps += libs
--
2.21.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx: allow build only on Linux
2019-07-08 7:18 [dpdk-dev] [PATCH] net/mlx: allow build only on Linux Thomas Monjalon
@ 2019-07-08 9:16 ` Bruce Richardson
2019-07-08 10:08 ` Matan Azrad
2019-07-08 11:31 ` Raslan Darawsheh
2 siblings, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2019-07-08 9:16 UTC (permalink / raw)
To: Thomas Monjalon
Cc: Matan Azrad, Shahaf Shuler, Yongseok Koh, Viacheslav Ovsiienko, dev
On Mon, Jul 08, 2019 at 09:18:04AM +0200, Thomas Monjalon wrote:
> Currently mlx4/mlx5 support only Linux.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> drivers/net/mlx4/meson.build | 11 +++++++++--
> drivers/net/mlx5/meson.build | 10 +++++++++-
> 2 files changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
> index 5de04b70b..028cd97fa 100644
> --- a/drivers/net/mlx4/meson.build
> +++ b/drivers/net/mlx4/meson.build
> @@ -2,6 +2,13 @@
> # Copyright 2018 6WIND S.A.
> # Copyright 2018 Mellanox Technologies, Ltd
>
> +if not is_linux
> + build = false
> + reason = 'only supported on Linux'
> + subdir_done()
> +endif
> +build = true
> +
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx: allow build only on Linux
2019-07-08 7:18 [dpdk-dev] [PATCH] net/mlx: allow build only on Linux Thomas Monjalon
2019-07-08 9:16 ` Bruce Richardson
@ 2019-07-08 10:08 ` Matan Azrad
2019-07-08 11:31 ` Raslan Darawsheh
2 siblings, 0 replies; 4+ messages in thread
From: Matan Azrad @ 2019-07-08 10:08 UTC (permalink / raw)
To: Thomas Monjalon, Shahaf Shuler, Yongseok Koh, Slava Ovsiienko; +Cc: dev
From: Thomas Monjalon <thomas@monjalon.net>
> Currently mlx4/mlx5 support only Linux.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Matan Azrad <matan@mellanox.com>
> drivers/net/mlx4/meson.build | 11 +++++++++--
> drivers/net/mlx5/meson.build | 10 +++++++++-
> 2 files changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
> index 5de04b70b..028cd97fa 100644
> --- a/drivers/net/mlx4/meson.build
> +++ b/drivers/net/mlx4/meson.build
> @@ -2,6 +2,13 @@
> # Copyright 2018 6WIND S.A.
> # Copyright 2018 Mellanox Technologies, Ltd
>
> +if not is_linux
> + build = false
> + reason = 'only supported on Linux'
> + subdir_done()
> +endif
> +build = true
> +
> pmd_dlopen = (get_option('ibverbs_link') == 'dlopen') LIB_GLUE_BASE =
> 'librte_pmd_mlx4_glue.so'
> LIB_GLUE_VERSION = '18.02.0'
> @@ -13,9 +20,9 @@ if pmd_dlopen
> '-
> DMLX4_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
> ]
> endif
> +
> libnames = [ 'mnl', 'mlx4', 'ibverbs' ] libs = [] -build = true foreach
> libname:libnames
> lib = dependency('lib' + libname, required:false)
> if not lib.found()
> @@ -28,7 +35,7 @@ foreach libname:libnames
> reason = 'missing dependency, "' + libname + '"'
> endif
> endforeach
> -# Compile PMD
> +
> if build
> allow_experimental_apis = true
> ext_deps += libs
> diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build
> index 326d1a369..3eff22e4d 100644
> --- a/drivers/net/mlx5/meson.build
> +++ b/drivers/net/mlx5/meson.build
> @@ -2,6 +2,13 @@
> # Copyright 2018 6WIND S.A.
> # Copyright 2018 Mellanox Technologies, Ltd
>
> +if not is_linux
> + build = false
> + reason = 'only supported on Linux'
> + subdir_done()
> +endif
> +build = true
> +
> pmd_dlopen = (get_option('ibverbs_link') == 'dlopen') LIB_GLUE_BASE =
> 'librte_pmd_mlx5_glue.so'
> LIB_GLUE_VERSION = '19.05.0'
> @@ -13,9 +20,9 @@ if pmd_dlopen
> '-
> DMLX5_GLUE_VERSION="@0@"'.format(LIB_GLUE_VERSION),
> ]
> endif
> +
> libnames = [ 'mlx5', 'ibverbs' ]
> libs = []
> -build = true
> foreach libname:libnames
> lib = dependency('lib' + libname, required:false)
> if not lib.found()
> @@ -28,6 +35,7 @@ foreach libname:libnames
> reason = 'missing dependency, "' + libname + '"'
> endif
> endforeach
> +
> if build
> allow_experimental_apis = true
> ext_deps += libs
> --
> 2.21.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx: allow build only on Linux
2019-07-08 7:18 [dpdk-dev] [PATCH] net/mlx: allow build only on Linux Thomas Monjalon
2019-07-08 9:16 ` Bruce Richardson
2019-07-08 10:08 ` Matan Azrad
@ 2019-07-08 11:31 ` Raslan Darawsheh
2 siblings, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2019-07-08 11:31 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, Richardson, Bruce, Matan Azrad, Shahaf Shuler, Yongseok Koh,
Slava Ovsiienko
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Monday, July 8, 2019 10:18 AM
> To: Matan Azrad <matan@mellanox.com>; Shahaf Shuler
> <shahafs@mellanox.com>; Yongseok Koh <yskoh@mellanox.com>; Slava
> Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx: allow build only on Linux
>
> Currently mlx4/mlx5 support only Linux.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> drivers/net/mlx4/meson.build | 11 +++++++++--
> drivers/net/mlx5/meson.build | 10 +++++++++-
> 2 files changed, 18 insertions(+), 3 deletions(-)
>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-08 11:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 7:18 [dpdk-dev] [PATCH] net/mlx: allow build only on Linux Thomas Monjalon
2019-07-08 9:16 ` Bruce Richardson
2019-07-08 10:08 ` Matan Azrad
2019-07-08 11:31 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).