From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09BAAA04C1; Tue, 12 Nov 2019 15:16:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40D8F2AB; Tue, 12 Nov 2019 15:16:18 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60083.outbound.protection.outlook.com [40.107.6.83]) by dpdk.org (Postfix) with ESMTP id D97EB91; Tue, 12 Nov 2019 15:16:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZXzEqr4fs36LUZl5kbJbTuTjmCYRE8KOLqsFhYtmgQYwHcBRqXOOrtRHiMHKFZ3QKpaU/ubxjMykM2TLci25PFlLR2sanNYHsQDCsAmnOkDwBjy2l88MWe4+OmQxLZqWDcy5cBF90wGRWzyf9oop2LeMyvDfYRJpi+Vlk/5f9uOneYGwsJ5NjWZZAKRNEDHTIBms/hm8w7+VbIzR+LB6pQ0YaqCTiSR4veXAf6rbH+RRF/KiSYySPcGcOiQqEiVJWvfVEyXDZ4zqtwHQReZdOLG9IFXCOnn5RI0RobsB3zpYehiq5S3IbzxgfKQFwnYfTltEbziuSTh28RaCHl8Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M7QJf7vyoDiGnJUXNDM/z1AKchcb2iafHaBabBz+piM=; b=OoMSTROkOnJOided1p6W7TUF+0UChodN/+qI60H5rPHSUS1XhCoCn+1Y30pK9r1o9DhwnGQMNghfJ1IT4dsCL+RQGctpljDM1A2l8hMVv/A1Dn1cFnQwLBeBbkqluRz7jEnpe05VUoeTyZVhAixVAy0TBIRxwC2WtGaoiWQ8AB6eaQgtykH0f9zuVfWDCYxwKObIqS6TBothb8v+91kZbyCkWeT1cnAC6vEWU51ndsL93ZSvgVZf/r7fXUqRTCo5rSxfzr8XERRVauyXn0ZGL1JGF6JUqKGHPX/B1DgHY8daJHezBn1nowZVUI892JobQu1QjAx4g1+Rclrb1E+E3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M7QJf7vyoDiGnJUXNDM/z1AKchcb2iafHaBabBz+piM=; b=T8ebpqchuuflfHdnSRQJQXJ2biGQPjrNwrfmUaH+0oeFmNRP8jUsK0NN8BPx2EkWxugZIZrFe9XDJ/RRgnN0xBQnjGNpA16lPBN2wZl941D1cNIKH2SemsEBUCvqyS2P7U1nhwJvulzXXJnYJrzV3Rv3ys8tZd2OcJfb/OarPFE= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3922.eurprd05.prod.outlook.com (52.133.45.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Tue, 12 Nov 2019 14:16:15 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::fd7a:e5a8:deec:c1b0]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::fd7a:e5a8:deec:c1b0%7]) with mapi id 15.20.2451.023; Tue, 12 Nov 2019 14:16:15 +0000 From: Matan Azrad To: Dekel Peled , Shahaf Shuler , Slava Ovsiienko CC: Ori Kam , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix RSS action validation of queue idx Thread-Index: AQHVmJznqAmIsFOBbUShc6jL/sb0KKeHliyA Date: Tue, 12 Nov 2019 14:16:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: bb481230-10f0-4b71-989c-08d7677ae0fb x-ms-traffictypediagnostic: AM0PR0502MB3922:|AM0PR0502MB3922: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 021975AE46 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(376002)(366004)(39860400002)(346002)(136003)(199004)(189003)(26005)(52536014)(476003)(486006)(74316002)(99286004)(54906003)(76116006)(86362001)(186003)(8936002)(4326008)(7736002)(5660300002)(6506007)(7696005)(446003)(66946007)(6246003)(11346002)(305945005)(110136005)(66476007)(33656002)(76176011)(102836004)(71200400001)(64756008)(66556008)(66446008)(71190400001)(450100002)(2906002)(66066001)(25786009)(4744005)(478600001)(229853002)(9686003)(8676002)(316002)(81156014)(55016002)(81166006)(6116002)(3846002)(6636002)(6436002)(14454004)(256004)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3922; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5GQ8cgaUmYqNOzuYXv/NwM/ZZcRKA2zb0dLPiICv5L2Q7hR1snciF8almTkAgnCk85g0BXi1YUyXFNb4PpMEKiugqNaBEglgfLJzpk+yCCTPNhvFSg1nfTcPdyQM2yfTtcSYWRiAdaAMk4JKx+CK3Gnt5hhNXK4215xcWdkWsBj+62+bEdeFgFWV64n2sfSy+bc/uYufvKVQOT7GMvcXbMQyoHt2EzoVHv/230W9UEsgvYpoS2ROgxMYLJhCMsJ9l47grOEb9n1jNj1ulrDRMxetj/XJDlZ7Itses9Rt73nuw+DQQqgmM8bCjSCAOAxOuaDfZ7ipz4goNqGoKDO90genyk4rTzje4npwd9+AoDGcJ/orKhJNsxduEzsQ2/UmFuohBn543PfuPsWvPX+6eRhRyWR0FG1YGkTZpM/uGM/0wljVvgUzq03hq6YSMTa6 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb481230-10f0-4b71-989c-08d7677ae0fb X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2019 14:16:15.3681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bocSWO/QdV70Mrp+dBHVF2AHD7HJzhyzAAeb2otT+LaAKjQUl+yVAFwuwx/E/eS+dKvz8Y6T1yj/R8Ash8Y3wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3922 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS action validation of queue idx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dekel Peled > RSS action validation function checks the queues included in RSS to make > sure they are valid. > A Queue is considered valid if the pointer to the queue (item at location > queue-index of RxQ array) is not a null value. > The queue indices are not checked. If a large value is entered as queue > index, using it as an index in RxQ array will result in a pointer to memo= ry out > of array bounds. If this memory contains a value which is not null, this = queue > will be wrongly considered valid. >=20 > This patch updates function mlx5_flow_validate_action_rss() with check of > the input queue indices, as done in function > mlx5_flow_validate_action_queue(). >=20 > Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated functi= on") > Cc: stable@dpdk.org Acked-by: Matan Azrad