From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BE4DA0350; Wed, 1 Jul 2020 20:02:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A33251C1CB; Wed, 1 Jul 2020 20:02:34 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80044.outbound.protection.outlook.com [40.107.8.44]) by dpdk.org (Postfix) with ESMTP id 4009D1C19C; Wed, 1 Jul 2020 20:02:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6oJBb7F/RvpWcXGBGLY7knYKm+MaWDjR4h0XYcOJrHQIYMBOkhesbnePXEH1g29UErwNHRU8CX0DUbINY4CzuTr+n+TjH5SD4smkHTfhRTMohQ3ve8CqpoLffHm7NqsPUTK3l4NW3pQO+ekJLSRWbpGDYivqISXDxid+2sEhuJ0zuNnSX5vJbB3E1WSksazmlQJmf9a8UXkjL60a3m3y7yACBI2m58m66nkVMiAKRlxu6IIPJg5rWedtBkIEe5B687W7dYwGK93KIfzjZQKzO9lIjEFfBqtPEWEfOy454L6nm/H2XMqJ/d5ggYFtmfLGdUNX+sDcdMkP/dFHJJ5yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ppx9xmjwaoZ7Oz9HkowHIsmfSEYL73mOL/LsSprzPlg=; b=ng25kyepa6boARG5DHGXAQOBXN/pmfUzOos8qVYgo18Fcm+ZTBXUKXg3trfPDCh5VhgYdX90hF5E/h8a4wrLIrYP0ztyeT7f/wGAt4GhDKK1ZAErVFv1L9x+lr62ItsXHtWBC6HJmoxRn9U00PBxLVg0waAR7WeXbnZV8dIXSVIcPiFni9PVVKAkisYfHKk8iW4WqPpq1uUccBAG6SEBX3IVvyli5riYIhC85HrbZqeOsbKho6/O3vWSMEE/1D+4y/0Wi2/SC/nEBKGsLYZKA6eoyVqY9eKfXlbIrY5mf0DJH7oWMxrSE+ZyuyjZxMni0M+XpZmBKVFufS5kFlS5Xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ppx9xmjwaoZ7Oz9HkowHIsmfSEYL73mOL/LsSprzPlg=; b=N9HXQYUcP5LkJD63WSrB/KurGbxF43fUjHzuui3IlXGsu8USm2YmCQdhPh9x23m5p1tagtW/0qxoKBngcb3Mzm5lt0GkZJyttPd9Ds4Qc/rC1xmYro3FwR/7zM/ijTpWFvRfMkNFkkYhkM+Zpqwi//cuhxAeKhmoophhxdxSXQ0= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (2603:10a6:208:f::11) by AM0PR0502MB4020.eurprd05.prod.outlook.com (2603:10a6:208:12::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3131.21; Wed, 1 Jul 2020 18:02:31 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998%7]) with mapi id 15.20.3131.028; Wed, 1 Jul 2020 18:02:31 +0000 From: Matan Azrad To: Shy Shyman , "dev@dpdk.org" CC: Slava Ovsiienko , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix flow META item validation Thread-Index: AQHWTS+hMp/y0mAcxUOs3tZAnVFbmajzCQAg Date: Wed, 1 Jul 2020 18:02:31 +0000 Message-ID: References: <20200628093631.56672-1-shys@mellanox.com> In-Reply-To: <20200628093631.56672-1-shys@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [87.70.223.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d33df154-20a1-405c-cc0f-08d81de8ecd4 x-ms-traffictypediagnostic: AM0PR0502MB4020: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 04519BA941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KrMqpSDjc2r21pDBwS7TTaxU+BWHLuuTeLGPgGkHv2TPpdcHRAirVIT5oJXN7uy2LX8Zwmfe3etoJdNOkeASiq4IJeh/kF0v9HaZWYMnDslzeXLbTmKsV1EJ6NZRQ2bsL0b3SEG6g4nYyd/S8nuDbJKJdyMa38HcfUxXo83OHPOiKxv7NvD4WCL2vmxMVqtU/jIgmlN6Q6eq0/HYV40BExCUt1wBXVPRUn+0Z8peZHE5bH6WtZLPK/xjDAvweFz7h+cBMFxKZgcVtnJ4i/sNvmDCsl5bbxi2IJxgXe47m+l2L3PC5yyvrXn8aaWvqSsdZOeATXkFbaohsYyrJo2V2Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(396003)(376002)(366004)(39860400002)(346002)(86362001)(33656002)(52536014)(8676002)(54906003)(4326008)(71200400001)(110136005)(316002)(5660300002)(450100002)(76116006)(66446008)(66476007)(8936002)(66946007)(66556008)(64756008)(55016002)(478600001)(2906002)(26005)(4744005)(9686003)(186003)(7696005)(83380400001)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: lvFVo3LnHVj9oYtzuauV03fNwZCxDlkJzo7JnXEyOsDqXMtWO3+/lnWNqSBD1la1UksXBpS1C/RwtJiVSN9cgFBjn8/iWy2Qn3184Uu39FXRDIV8tCBweaK5NDc3sms7L7NMC8PigeljimLpgnglngPwzinQQoTwkpjr3RALmL2b5jGPEBn3OLD/uIC7W3QWM6Ke66IiFEbHIZEBelQf18Nqh9xrYtFPzUVdZMtViAQb0uVSMCoUh14dzBfozc8xZHI0k04EscCPVtGawqJacvAcCgHgzJDAWpnix8TM779AQ9LrzHSsoG/NjNL8zJgJvTrintkMXF9Mg1IgK+LZvziSZu8wKMDdqZoFD52O62TqlQatPLnRvzgkfxXRd5fWcNeQAHNa0RnDiuw8/KJaszKdWs9GzadE13tqo4Hl14mYkuEb04m5wxJ0p+wM4iNNJX2lpjFGeKwq28E3o0qS63dvfZkcgSwN3bS4rZBxQTM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR0502MB4019.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d33df154-20a1-405c-cc0f-08d81de8ecd4 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2020 18:02:31.4413 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XMO0+/Wchsj+QxNndQ+X0i+x3tYC7c7J45Ooub4xX/7pqFneTAhs+3I5Ic2qkwkInhjUuXlP/NHobGs1ziCX2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4020 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix flow META item validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Shy Shyman > When flow is inserted with meta match item it requires a certain register > support. > As part of the flow validation of such flows, the validation function is = missing > a check that the mlx5 driver is not in legacy mode in terms of extended m= eta > data support (MLX5_XMETA_MODE_LEGACY flag). > If the driver is in legacy mode it will cause downstream function that al= locates > needed register for meta data. >=20 > The fix checks explicitly the conditions for support of meta data in FDB = mode. > if the conditions are not met an error message will be issued. >=20 > Fixes: 9bf26e1318 ("ethdev: move egress metadata to dynamic field") > Cc: viacheslavo@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Shy Shyman Acked-by: Matan Azrad