From: Fady Bader <fady@mellanox.com>
To: "dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>
Cc: Tal Shnaiderman <talshn@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Subject: [dpdk-dev] questions about Windows basic memory management patch
Date: Mon, 6 Apr 2020 11:44:29 +0000 [thread overview]
Message-ID: <AM0PR0502MB4034253D9FB173F686590D66BFC20@AM0PR0502MB4034.eurprd05.prod.outlook.com> (raw)
Hi,
I have a few questions regarding your memory management patch.
In the "eal/windows: fix rte_page_sizes with Clang on Windows" (http://patches.dpdk.org/patch/67390/) patch I didn't understand the work around that you did and what the problem was.
Regarding rte_mp functions I see you implemented a stub, i.e. empty functions. I don't know why it is needed.
Just to make sure, does the rte_mem_map function that you implemented replaces Linux's mmap function ?
Lastly, in the patch you implemented functions that were common for Linux and FreeBSD and in order to use them in Windows (e.g. eal_file_truncate that replaced ftruncate) and you got a duplicate code for Linux and FreeBSD, how can we solve this duplication ?
Thanks,
Fady
next reply other threads:[~2020-04-06 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 11:44 Fady Bader [this message]
2020-04-06 12:37 ` Dmitry Kozlyuk
2020-04-06 13:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB4034253D9FB173F686590D66BFC20@AM0PR0502MB4034.eurprd05.prod.outlook.com \
--to=fady@mellanox.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=talshn@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).