From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B080FA0577; Mon, 6 Apr 2020 13:44:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC2061BED9; Mon, 6 Apr 2020 13:44:31 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00048.outbound.protection.outlook.com [40.107.0.48]) by dpdk.org (Postfix) with ESMTP id E3CB5F12 for ; Mon, 6 Apr 2020 13:44:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gf8hTnD3XHgT7RXxPHx76KV4DP2h6U5y+1W+bWiKaU2ftFM6FNgxD1yLPxqNfZq25aOOE5VaVtIJeM5rkyuk6l43G1IjgwZzXUSf6iRY+SCsiGuhTqW+w+lzVtviGliLY0vMlCEfVhzJbVs6FN/d1CAKlA/xEuh7SQxtlUV73+aP2E8w/mwRWeHKzC60cj97wCxqwg401Gsx11KhwaFMXNDZnQrsRVAnab47A7n26bBer7d6hMfAG5LovvaQ/DJ01ImG5be3hAjYUuI1nlO1OK9FCgRe+M/0H9cdxj4felnwnoVa8wMcDPIiaAupVwrt7zV+pq6JUmwm4krCOIoySA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2bPvdJ2UCuXXQcXaxu6pYL3vz/+4FsjKXoePkN1rit0=; b=I1R5Ki6erhtjPlFobtBJMzJUJP86R+JazSzjAQLdqm2tKiVI2eN4QP5xTloYon9tEKvGxnZ5rxk4l0uBysAl4BfI8smkcAvijFZ8TgAGpH2tRS5waoHMGpYzYzZ5LFmXT5uCyw6d2IKZCxyymAb6R3mWi8G3w1Wb5JZSkWI1uR83xsQdKf+khrYCApU4gB1MFtUl1tKuUEf2/P8VEfc3po9ESl4vC5oxvvAtHc4qLaHIdCNwpA7DkEL1/SfFWphVNyzw6pO1TthnZ1Ew0eHn2plQpgBELbl/YsS63/dbRkWAkhwNW/xbJLQJrmLtcpm3K3IAlmc+frJGphOy+w/Qpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2bPvdJ2UCuXXQcXaxu6pYL3vz/+4FsjKXoePkN1rit0=; b=onCbFSuyvuE0lT8M7WCVrmCXeJvYXSBfmOObae5Qog50tFlRx3o7G1N+x9Q2zoNlPO5DYMW4BpCoHRaP5nvLD7yk5bnj7mICXtUPHJJWwYP3IEBZ99sFMB1dqLPhIX//7KOf3gIwApy7aBd+5NlofvSrdJacX8/njJB2glIQ3iU= Received: from AM0PR0502MB4034.eurprd05.prod.outlook.com (2603:10a6:208:12::14) by AM0PR0502MB3651.eurprd05.prod.outlook.com (2603:10a6:208:16::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Mon, 6 Apr 2020 11:44:29 +0000 Received: from AM0PR0502MB4034.eurprd05.prod.outlook.com ([fe80::991a:173f:5b51:78d]) by AM0PR0502MB4034.eurprd05.prod.outlook.com ([fe80::991a:173f:5b51:78d%6]) with mapi id 15.20.2878.018; Mon, 6 Apr 2020 11:44:29 +0000 From: Fady Bader To: "dmitry.kozliuk@gmail.com" CC: Tal Shnaiderman , "dev@dpdk.org" , Thomas Monjalon Thread-Topic: questions about Windows basic memory management patch Thread-Index: AdYMBqhuhZwoaxBcQI6C36NwjkKusg== Date: Mon, 6 Apr 2020 11:44:29 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=fady@mellanox.com; x-originating-ip: [109.67.125.34] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 00a78551-17a7-4888-d879-08d7da1fdd85 x-ms-traffictypediagnostic: AM0PR0502MB3651:|AM0PR0502MB3651: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0365C0E14B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4034.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(346002)(376002)(396003)(366004)(136003)(39860400002)(8936002)(8676002)(81156014)(81166006)(9326002)(76116006)(186003)(2906002)(86362001)(4326008)(26005)(9686003)(71200400001)(6916009)(4744005)(5660300002)(6506007)(55016002)(478600001)(316002)(54906003)(33656002)(66446008)(52536014)(7696005)(64756008)(66556008)(66946007)(66476007); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3Vok3HdVR2LMoHcMU3z8ZCWvBdJbEGd5mCVRs+5OSOZztxrwHTQ4gQMCpczF7wXnlvh08uuboxQWZ2DJ/XLCfwe0gEuqX1Y02hHqGMRG3iuMVJMiRKGOztm0iDY+m1gAUwf9i3fy38lrlKI2XwaqDv53bFWhe8hxbWKmze9w1XpdmbhR3tjnXdERhaxttCr755v2by+4Rqx0vr1n79255bIMgwmMS9KF1d3R2SRKEeDN08RKgFlxnQpC2EGzQVTiiCfPM80BZh0W265r2PXgcLQszbLx0v8MelgXiKs2ExPrCgYosWADk3/vhExu1va3cZHiojQePYEq2W8DRB5kC/PknjZGeBIeTeiAo8PUKLxLAw/E+L+I7fBns5vz/MwTcbLkuLVw0sqofDJZuC/LVigzBlDw8jOFJ729fwjoHH6OeJd8aBozDdumTFGx7Wqc/u6BDiNMGYOzoDX3e3rSodQNGrmlJiDJPKaEKb7lEP/o/4s2sv49O4nSGxw/2h/NftBOvKYuLh26n0OC5F0oDw== x-ms-exchange-antispam-messagedata: H5VdHRfyBUC12yTPUKlP+066QEb4WlqzrYTOLJ3uh96tYbgU3Z6mnQy3W/vnCAxYk1BLDpWQxDE2OmRWv8gSWAbVA9clViJxrba0xqXtaRDt2xAfrcU3B3E73VrmMCDcJlEvvrFnZsrBJ5P+ywvkeA== MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00a78551-17a7-4888-d879-08d7da1fdd85 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2020 11:44:29.0602 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0TXTp3ugIxKZeWxgTkyoG7tZ9v2S6lQmk1KaDsCFbvdm8F/maq1BZEk5aOYrIsW1WPzl5y3p9d0hSmTTjhnmRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3651 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] questions about Windows basic memory management patch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, I have a few questions regarding your memory management patch. In the "eal/windows: fix rte_page_sizes with Clang on Windows" (http://patc= hes.dpdk.org/patch/67390/) patch I didn't understand the work around that y= ou did and what the problem was. Regarding rte_mp functions I see you implemented a stub, i.e. empty functio= ns. I don't know why it is needed. Just to make sure, does the rte_mem_map function that you implemented repla= ces Linux's mmap function ? Lastly, in the patch you implemented functions that were common for Linux a= nd FreeBSD and in order to use them in Windows (e.g. eal_file_truncate that= replaced ftruncate) and you got a duplicate code for Linux and FreeBSD, ho= w can we solve this duplication ? Thanks, Fady