From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09C90A0350; Sun, 10 May 2020 10:14:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 912A51D54C; Sun, 10 May 2020 10:14:11 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60064.outbound.protection.outlook.com [40.107.6.64]) by dpdk.org (Postfix) with ESMTP id 1BEA41D164 for ; Sun, 10 May 2020 10:14:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lBDtVBxyvPUlrMPVQFNOUef+HdPVQtVMG67kAMS7P9w0xzs3EhwK+iQV6fJaqGV/mFxeI83RMShr/EivArsLY/STyyQ/iAu/8gFAyE/BryjB+/eDQQ4DS7BYAhhBi1PmZheBKuEHt9Yv/3nKizzmLv8sDVz/8XBN7ZeAt7qBoGOjAv49yE9PJRfwRyBDh2w3txR3hspn79X5OCZ+CUHk3db8s4OlFoWboOSVp3Nq3ath4e/G2qQ8piQa0fMocNmnglIXUnNIgR8c0/hgRmLxxE7AVMzXKWMRSmxOCv4GKYTnf7uMyAOEpJ1NVW1pBUSTuJvGIHL76Gkpi/XZKlMpEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3dMbor5sgkhN5bkOZEqRj+MHabC7WIERFm/R5PHuSEQ=; b=KiUMn8csDFwJFOzWdXTC2/YR8I3KYTRiDg08pwBjsWPtU+jefD4/S9FTHiU2/PRe8OseWZFUygFe1MuxtVRLE13Oh3/+iuDyPVlKDTYBnBtPVgJ59iCZr6q54c1GiAGoCh8W37LGAMP43YQt9+N6JlA0SU2EmpDaHllUYCurbEJEqLUoCFKGsoLPQwhSPqOgX5bjHoIEU0d2HN1Nq7BlrZ/3Rw1RZQYYsU6rqS9rPIgphh1zCj0NaV8mNxIQSes/2wQGoC8rLiIFxIdNfPU87MuUgMWY6GqVTsG64abU8d7RjtHHGnDZxtO9hYRL7I0KFyVZqBVCCweY7OyKqmDpEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3dMbor5sgkhN5bkOZEqRj+MHabC7WIERFm/R5PHuSEQ=; b=eXPucwQhdT+3LdvXljCb1eUztw2xFXMubla3TYyovdCAS2QT2Md/EFgDbUySOLugbLc0qWyZG/aEKzXnQXQ22wxKq5H/NxHlLP3dUSRyFwtQPtKKolyReu/m2sow+1Ik9VweobeP8h7L8676dXJ2bfkZqxR9HAQQwZox7YNgQSk= Received: from AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22) by AM0PR05MB4513.eurprd05.prod.outlook.com (2603:10a6:208:b4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Sun, 10 May 2020 08:14:08 +0000 Received: from AM0PR05MB4209.eurprd05.prod.outlook.com ([fe80::1068:89a9:41d3:b14a]) by AM0PR05MB4209.eurprd05.prod.outlook.com ([fe80::1068:89a9:41d3:b14a%3]) with mapi id 15.20.2979.033; Sun, 10 May 2020 08:14:08 +0000 From: Ophir Munk To: Thomas Monjalon CC: "dev@dpdk.org" , David Marchand , Ray Kinsella , Matan Azrad , Raslan Darawsheh Thread-Topic: [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison Thread-Index: AQHWJE1ttJedAbwtJUe/SmGcxEQrbKicamYAgAATokCAAI/MgIAD7yCg Date: Sun, 10 May 2020 08:14:08 +0000 Message-ID: References: <20200507073702.4047-2-ophirmu@mellanox.com> <2189631.BjyWNHgNrj@thomas> <5442514.zQ0Gbyo6oJ@thomas> In-Reply-To: <5442514.zQ0Gbyo6oJ@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.229.97.42] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4051bbca-5b66-4d86-08a8-08d7f4ba1d3b x-ms-traffictypediagnostic: AM0PR05MB4513:|AM0PR05MB4513: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 039975700A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /aIffFQY7b3Nd+un64oUfIdDh4XXXxBkjwJdWFHvomzac2d4tldAowCxaWdDO1c4WM0gq9TbHgWyaQp+2+yjLJJSpKSO905Nm5+3q1cpPFIcRsmDHsuz1y9HFi+ck8/o/RpKIjHXgY8bcMEF4bdlfzy/1+gI2UdylrIhfwaAA779eQBXFct7c8s6DdjIciCBaKE8xxST6wm6a+/4Je6VPFyOP68nUi+Q8UbPW6vcG+yK574bXMg5lOjViid5h99F59iB/m0LJ8TJ8MP+gebNbX2LWcXuu4I6yCGyEcMV2Wk/1JLa37cr4pobMlzdXZNvEAST/JFxUOYfG+1zbNV08mkX+uUgJL3oHQ2NEv9I2J7+k/72EGl+tFbIy5KDAOQKgOtDFg965bvTAcy91WHwI1VJ7tHHkGkJNgHNpx9STb1D0YXtyV47efDAAMQrYLp/zk/lIV0R9Eo7IsFS5fPBQZWrr35p/Tsx97oPmaNuiwSePHN5ed7k/598y5/r31oYDSn/fq5pZ3S8l/Mwln+0lQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4209.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(366004)(346002)(136003)(396003)(33430700001)(7696005)(5660300002)(26005)(66556008)(54906003)(2906002)(33440700001)(316002)(6916009)(66476007)(8936002)(64756008)(9686003)(8676002)(52536014)(66946007)(76116006)(66446008)(55016002)(33656002)(186003)(53546011)(6506007)(86362001)(71200400001)(478600001)(107886003)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: L1bB77FOFOW9rvrWsU+G06WKWvrduCxx/OidjZ5GB73Pwfa8NmYNW8Qph6/gUK8VmROqWHhJCMcGPwqdATJAX5W8r82ye1Pn7La4lvj23lqjocqq64G4KKqbzquiHkwvZdyPMpCmLUS/R2WVd6OcqnMgvhEeDMhMM9bxa8Cy3puDRvZZA2Cnyr5Iq/7DMaOBjACs+rS0sAl8rg9regLTG3+VSOl8cQ4lPUxZsR7R0s3UytWHBjyjbmARCt7/IyNm5dCsufLoJTbAAZEbUQqjaSOIvDvnIVShafTn4Y52HZUHZkmDyqOCpLv3QdKsvQpiPSnERJsJC7xGjRnTUxFyTdd+Ujv1dViPjhy/y+Jy9LuqDGxGhfzastOrUiILS4clXTi55qJu3YO0izh1JL95rV12Fh++1JMLRgAeMS9AyND6sSqiMEMzFmbKDy8ojx8SZjssfFYMFiHM81L44iNHHizXHcXT0miSJvra3H+MaCU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4051bbca-5b66-4d86-08a8-08d7f4ba1d3b X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2020 08:14:08.6847 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4paXJQG3RGXo3xMH1CXPRMX2NUwdlnufFX1vly0Y4RgV9aXGH0Uy3bFAy7mOpNpbk1JPuO6J2W/3lnQNTswXdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4513 Subject: Re: [dpdk-dev] [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for clarifying the INTERNAL/EXPERIMENTAL difference. > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, May 7, 2020 11:08 PM > To: Ophir Munk > Cc: dev@dpdk.org; David Marchand ; Ray > Kinsella ; Matan Azrad ; Raslan > Darawsheh > Subject: Re: [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid > comparison >=20 > 07/05/2020 13:41, Ophir Munk: > > From: Thomas Monjalon > > > 07/05/2020 10:56, Ophir Munk: > > > > Move mlx5 symbols in the map file to the INTERNAL section and add > > > > __internal tags to their definitions. > > > > Those symbols were exported in 20.02 and now (20.05) they are > removed. > > > [...] > > > > --- a/drivers/common/mlx5/rte_common_mlx5_version.map > > > > +++ b/drivers/common/mlx5/rte_common_mlx5_version.map > > > > @@ -1,8 +1,10 @@ > > > > -DPDK_21 { > > > > +INTERNAL { > > > > > > I think you forgot the EXPERIMENTAL section. > > > In my opinion, everything should be in INTERNAL and marked with > > > __rte_internal in source code. > > > > > > > I moved all EXPERIMENTAL to INTERNAL and sent V4. > > A general question: what is the difference between EXPERIMENTAL and > INTERNAL functionalities? > > In the end both indicate to skip ABI check. >=20 > Regarding ABI check, yes the result is the same. > Regarding API, it is different: > INTERNAL is forbidden to applications, > while EXPERIMENTAL is to be used with cautious as compatibility is not > guaranteed. >=20