From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43363A00C5; Thu, 7 May 2020 13:41:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C5471DB80; Thu, 7 May 2020 13:41:27 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60060.outbound.protection.outlook.com [40.107.6.60]) by dpdk.org (Postfix) with ESMTP id A51911DB5D for ; Thu, 7 May 2020 13:41:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=czur6NkM0Bn3Ie7jSb4XGO8C7l5kQCTmV/IS+1zM5hMyU6lHm9XJcAbdNKs+h5zuEr9DyoIiI2AM9V622qAqMj/lfOES4NmCJIfP8HV9idawtMGRS+q7Ush9KPnQccZaUjzkKFSwOBxmJaJJjzS0ML4gALHov0n06HeJNX9GyogryVFd+NFVvx7S2PLSvI8nhuu1mkJyXi3PXjErsrnLIXN5ueO0TN3CJhOyv301fiaJyR5PK8RJe4FKMeGf4rOCLFVDXC3Gam6vjneFeuf0lhOm3myqy1hzGuL3gMgggVZoWccqvy9TIDwQSllOFDC3AdVeeVoaEHJMOPQwP2tL3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iFuvki29atirOY1a2MhUVFI8cxjOqSGBHdLQzRAx9Vc=; b=V6Sxjg9mrQbpuR0NUWCtux7QZu6ZSraroQRrM5ile4lTvBJPFgWu216iBUC0bcL4VhDp7p2iWMS9kLzxbEWXT1mtQH2vqTsLkV6N/Z3KKVxpSL2PCtCY+CPJFqaWUtO7l+TctOrk9BuzI6SpeqtDVLiCtM40GHU5vpVPX1jW22I3LvPGZzV8/fC1ad7ZKup3VQ0HDMtHs66md10chhjRFY0Em0JcWFJ8sZuf9c4ASWBavBOynkZqCRKGzcilCvGaqy40MmSpbJt6+rOjKFB5jET/FcJ9GPLhvNtpWoDIVwNZIM/hqvl93ECMyyneSw6HJUIaxh2DIZPeHMeaRZoqyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iFuvki29atirOY1a2MhUVFI8cxjOqSGBHdLQzRAx9Vc=; b=nue2ae6p0CXCLRsN9MrwoIYD9nDqwzDCmymb0VCfBybS2UFa6wo/qDx11+tNdulxI7zffMhyhj4x9TmLxdgDcWmNIKtlY1m1i+/q5Og7dSw+u0eog8cbZxWpwhqwMYZWq+YLrqttnQjqt/mGsOBweXPcQH/1PmKTJaiJTRVy4a0= Received: from AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22) by AM0PR05MB5859.eurprd05.prod.outlook.com (2603:10a6:208:124::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27; Thu, 7 May 2020 11:41:22 +0000 Received: from AM0PR05MB4209.eurprd05.prod.outlook.com ([fe80::1068:89a9:41d3:b14a]) by AM0PR05MB4209.eurprd05.prod.outlook.com ([fe80::1068:89a9:41d3:b14a%3]) with mapi id 15.20.2958.034; Thu, 7 May 2020 11:41:22 +0000 From: Ophir Munk To: Thomas Monjalon CC: "dev@dpdk.org" , David Marchand , Ray Kinsella , Matan Azrad , Raslan Darawsheh Thread-Topic: [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison Thread-Index: AQHWJE1ttJedAbwtJUe/SmGcxEQrbKicamYAgAATokA= Date: Thu, 7 May 2020 11:41:22 +0000 Message-ID: References: <20200507073702.4047-2-ophirmu@mellanox.com> <20200507085634.9589-1-ophirmu@mellanox.com> <2189631.BjyWNHgNrj@thomas> In-Reply-To: <2189631.BjyWNHgNrj@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.229.97.42] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 41419918-edbe-4f2e-42fe-08d7f27b90e1 x-ms-traffictypediagnostic: AM0PR05MB5859:|AM0PR05MB5859: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 03965EFC76 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XTu1oC9C5Jqdvg62O5SqHCspbYwuRqwYlmUOAUh/MbDsexXu6XEshcZNExBDhXtgxDNmZDHgd8kWF4cE6g2o9N35PLUrxu6rJH3pi0pSV6U7tgtTbCdDNckA9KKZ8OaZ8nhugB35IO5XT252pZ9Jk1Bn02PDGdZNGwJIQh7buauzDjrkKVrSaqP+x2Tn1w9lP7ervjbG4kPGnCfUbo1aWFCC5/F91xjIMNTcZthLaX/d65jh76lOr55DzxqMiJ8lt2ciwOTo8tlda6YNUN3XAP7CJju0T+ATY2iGp9CbontrugfGECGKgnwcSg4lpxNM4XKqDsIP+g2Q46QDy05s/Lk0/NaHbpxDhcoRamb1TAi48n0Bpjld7boOwWFl2tfTNfe0jjPfNMfxKmqUY63g3VWu1NoLxxmL7pyEyV1NRdJzC9HgyjjogzOrIDk1izGCz3OoKpLzKi/gnIzdHrG751Jmg0TYiRyP/B5vDeF1JIZ/VyDQqR+bs8f3Wd9+DoqKsLtjmsUv26+/bG1MiS58WA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4209.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(396003)(376002)(39860400002)(346002)(33430700001)(66476007)(86362001)(54906003)(5660300002)(53546011)(33440700001)(6506007)(186003)(107886003)(9686003)(6916009)(26005)(4326008)(7696005)(55016002)(2906002)(478600001)(8676002)(71200400001)(8936002)(33656002)(66946007)(52536014)(66556008)(316002)(64756008)(66446008)(83320400001)(83280400001)(83310400001)(83290400001)(76116006)(83300400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: od6ufnIprOhPClQRb38JEwnXFM1g4X1sTwiJweaLr3AiLIfGELRu4ZIT+W+Rl6rrRx6d0PO+t/4DlZskLpaeZ1zZcvXAWLxZFiNAAQdRpn42eR1xUnET6l57Q/Z+oe5rXpx+jRYJKNSqmJQqe4MJ703j8lKigSDtpGfIr76LjH5bSq+7KmhJgmSvncWi4mpDQwua2k/qrsix2mTuAmREFKv897pXiocwQj+BVbibs3VBhFbjGJGdcbcX5JR1NyrZGxEF1Hs9lZhCjdNRm28EdnVZ9ovGyPg9wCCzD7pZTWHkMDFP3Nh9tFCtsX2FPt1SPabzMB0MWwFu5udRkI531EJW8hdYRGESZtBcd7iWO9PVynfOPgPRSTdeltot4ULK5yjxCGqP35LnUtrtJuyQyw82noeLVSI7z4GtnsFa3WUP5VArp7kR8VhwVoNQxoCQ6xTnButpc1frthgP2A22x57CDNi+ipvIfdw1+8EaX1LCkQMf2bmkLQGZOB40qvKG0nScKmCvlYRzg88KHmou+EzUEy3IriFsMp9Dnl58OBxck9W05uVuE89zys/favf9ZEQf0M7mn0RJlm1+0aVXr8TUb5lZsU4fQ8nS85/Z5HDUuL8i+ChEmlGouktO4W6CI4FvjmesltK9MvSNwdd6ojFAir98lAvLZol/fnCOhJq1JJxd9TGTU/hINzYsde/pdLlrP2jSCrGOAIHatQK+EPDE+0HmEHZ5185pOmJyzz2d8k3dCth9QWAkEKV790S4+By1+5bjN5UQgSYAsiEQo//Fc2SdhrrRrsI7DZijL4s= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41419918-edbe-4f2e-42fe-08d7f27b90e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2020 11:41:22.0596 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c+7WfdE6/mfFzQGEpVmX0VIkMweaD33bBiQM5mQErp+VbbqRfKOaH490FRBZZ45VMNhafb9tvRy3wDuCwavzJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5859 Subject: Re: [dpdk-dev] [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, May 7, 2020 1:23 PM > To: Ophir Munk > Cc: dev@dpdk.org; David Marchand ; Ray > Kinsella ; Matan Azrad ; Raslan > Darawsheh > Subject: Re: [PATCH v3 1/2] common/mlx5: add rte internal tag and avoid > comparison >=20 > 07/05/2020 10:56, Ophir Munk: > > Move mlx5 symbols in the map file to the INTERNAL section and add > > __internal tags to their definitions. > > Those symbols were exported in 20.02 and now (20.05) they are removed. > [...] > > --- a/drivers/common/mlx5/rte_common_mlx5_version.map > > +++ b/drivers/common/mlx5/rte_common_mlx5_version.map > > @@ -1,8 +1,10 @@ > > -DPDK_21 { > > +INTERNAL { >=20 > I think you forgot the EXPERIMENTAL section. > In my opinion, everything should be in INTERNAL and marked with > __rte_internal in source code. >=20 I moved all EXPERIMENTAL to INTERNAL and sent V4. A general question: what is the difference between EXPERIMENTAL and INTERNA= L functionalities? In the end both indicate to skip ABI check.=20