From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 953BEA00C5; Thu, 7 May 2020 09:48:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE1FB1DA99; Thu, 7 May 2020 09:48:06 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2045.outbound.protection.outlook.com [40.107.22.45]) by dpdk.org (Postfix) with ESMTP id 2B29F1D724 for ; Thu, 7 May 2020 09:48:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OBa4gUvZL+Ni75PiPS4hG25EXepGA+l6U9ITNSgIVjfhhenIOA5C+IKoXnLZsyVSn9bcFGCC1hHLuz8LgLTDwXRQsX2M+f+upF8bR2J51eXQTuO2V6U+/wXBuT0WN7SIS/MgNkDOgYG6+LE+Gkzx9S429yywHCQbRiMKYgoqm4RBjf6UkN+Yw45elE3k0RJiUFy1i9s5gmYqahU/9Ya8mNOTzWskpEm7Uu10lIOlQ8sxysWRCx2iCAF0oVAghmt/Z6BOjf5ti/AG08Ns3mL18wYwg8xC+YXZevqmORdNJ3p/2HYp5qk2M6dbrtMCBVNMeHXP+mFlptQJYbrI989EJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kFuGS27BOwy8eT6LmSG02XuLcrf7LZKlpTfO8oFtJMk=; b=JmSSrH4c3qAgutLU+91t6c1Lrc3ZIsR/KMYaeCHY9ck0O+ySp5tt0XCb+Olj5luFhD5sF2l/X6sW0jKqTI1Q3oQH/2v9ZTQZDHZJRLpwN5GCV0jTJQXewwfXbKw0kyrs3uv2vaTaktzhZxw8g7kwNTAzKDUCnG7z2dsQf064QvI0GwIXMWCgpztzQ4sJwIM28BwFOdT1UjtdO/YwIOizKwJZDF9A1M40xSa42+PQjG4L46PClwQRqAC0DbtkE9igGC+pytl/OdPTyq+Eojli4IMY1f5xfI0qDEZPv5p9edxCECUrI1ZoIXZffc+DqMoaeYaqhhddEJ9mfE3z8KdA0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kFuGS27BOwy8eT6LmSG02XuLcrf7LZKlpTfO8oFtJMk=; b=pDLe0TMREs9G7atMXcOf6cpYDr0hb92aoRa0wYwOsukTyx8WaGQLXJvkN/HXX7VqBqEjpFkO6PsusnCog+J8BaD4d8ybz02Lmop7GqdEoIJvAM+HwBDbWt4bvEykw37EJpDv5XqRWGhdGrAja/MCpPurE6Va9djG/zX/+padL8Q= Received: from AM0PR05MB4209.eurprd05.prod.outlook.com (2603:10a6:208:61::22) by AM0PR05MB5987.eurprd05.prod.outlook.com (2603:10a6:208:130::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.30; Thu, 7 May 2020 07:48:03 +0000 Received: from AM0PR05MB4209.eurprd05.prod.outlook.com ([fe80::1068:89a9:41d3:b14a]) by AM0PR05MB4209.eurprd05.prod.outlook.com ([fe80::1068:89a9:41d3:b14a%3]) with mapi id 15.20.2958.034; Thu, 7 May 2020 07:48:03 +0000 From: Ophir Munk To: Thomas Monjalon , David Marchand , Ray Kinsella CC: dev , Raslan Darawsheh , Matan Azrad , Neil Horman Thread-Topic: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail Thread-Index: AQHWIs9FxPpL2jqpPUGw2Z3R/3bOZKiZlE4AgAFpjwCAAAQOgIAAAsyAgAAXWYCAAAHrgIABI79w Date: Thu, 7 May 2020 07:48:03 +0000 Message-ID: References: <20200505112057.20901-1-ophirmu@mellanox.com> <2351387.Sgy9Pd6rRy@thomas> <2495289.KRxA6XjA2N@thomas> In-Reply-To: <2495289.KRxA6XjA2N@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [84.229.97.42] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d1157133-ae0f-4753-ba25-08d7f25af91f x-ms-traffictypediagnostic: AM0PR05MB5987:|AM0PR05MB5987: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03965EFC76 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xMbsJgL3OW/Yi3wDZbHWm7hdi9eQCQf769bRTDow3SiiRZPbhLjFf6nJm/0pBzDxUWCkr0cpBWM26NCwHXQ6yulSCHX2Z2oy5YHkTSN2ur/Bbya4B3rjTPOaL7JjMt7tQkQYfZluA28HxlsYOZ4aP6RxfSUj4v/4DV0CX6Txv2MVj8uDRlgsfYdDv2gU7o+QFO2PAHq3kIDtkn9ABxziq4YjcnnOHruAm4pOZvNoxBDXGm6czVGCEIUC2cRTqWMyirocfIVs3rzzfQgop111JQwVtwos4nedxcvzAPgzEyZrqrjIakhK8s8Yn/RIpukqae3eBdY45eBMWwuyNHj3Z747aAvdk17gi8LvalbJ9xvvgr3HLUfxGvBLTXy+3XJzEEzv+uoZzNM/4PpCIydJJ8fph3sBKoRFygAEfQVen/zBf2EremHkZHsCRJp1OamfkrKmwvWuIiSQPiNh6RxDdZaO3DfGocFPyQdfOdSYw8O/0W3Bx5+MWdSYYwAPHYwRQrwMDlJIIe6d0KZGioWQQA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4209.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(33430700001)(66476007)(33440700001)(66556008)(8676002)(64756008)(76116006)(5660300002)(66946007)(8936002)(478600001)(54906003)(66446008)(110136005)(316002)(2906002)(71200400001)(86362001)(186003)(7696005)(83280400001)(9686003)(55016002)(52536014)(26005)(4326008)(53546011)(33656002)(6506007)(83300400001)(83320400001)(83290400001)(83310400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: HP3UB0cVwp2pumw1HC+GBHx/eaIAyiNePycT+VeiYizKRD7rQQ7zYcQ072G0YWhIWnY9PseCmEfEwMIZTrjTFdrbG0IpF9AU2paYhYRbuC0H1NvTJE0xqthXNPCtmZ0Rk7kDuTjanFaxGWpz4U8DRPRiHy5XTrUxhNzN66ZVfCC8T0X80IwWD9Lkj7PmbnNRTasduj546HdfKpCCT8UafQuCc1ez7iDMrAiPEhnZvc2yD5ivBF7QPE23MwbNYAvqc/hj4Kh8NPDsnTyVfpkAnGly1PO0AWXKG3K0/k6nYyNaYs+WMahihLmDW1lyZ6LfoRw9/IlAEExtz4AAoNy1GSOjPAfZWkS7PslsV0M4Xk2nR3qHWVjoOG0pFkmFbU4bKw89/J5XddZjzU/0hgMqIUQ9/pJwldpwHlUL6XHw1yCG66KF/SETTB5LfrCRJBpjkE4+tfYzSNXs8zSa0uuvO3xwLaDE1KnIKHUr2qneL/Yw3hUXqqMOMbbK4J0hk40RkBz4kAaCxt6AOKoImuqQDIv1ENJGZBQ7/1CULuMxKunf8ViniAsai3Rz9OAvMe50PWUejVEP/UIqaTH5193wgXdGq/G2q7VnpGGlzPY8UjWsWo5UGDuPF0pnUT5kz73aR5N5xMF3KYTGsjGbC+S9KnrsqlXP29p9DsmCo4eq7XED0CFhAE//vU/igHbZrf00SviLL781+jqLBTo2btIW229ddaIKJ20zfMUArEzNHtM7JVkifDnrMXgu8Qc4JLVcjeZak1+F/u3KLNAoyANa0G9RJEGSO1RjhDIlZvqkFhU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1157133-ae0f-4753-ba25-08d7f25af91f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2020 07:48:03.5339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tjojpBqucEnB9PCCa4cXPEy7sePKtZpAdE8E0NviIx/rwQ2zC9P7Lw6w7LRH1Gyf08HcBmAUF9zsnTzEV/IZkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5987 Subject: Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks all for this discussion. I have sent v2 of this patchset. > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, May 6, 2020 5:23 PM > To: David Marchand ; Ophir Munk > ; Ray Kinsella > Cc: dev ; Raslan Darawsheh ; > Matan Azrad ; Neil Horman > > Subject: Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore f= ile > for libabigail >=20 > 06/05/2020 16:15, Ray Kinsella: > > > > On 06/05/2020 13:52, Thomas Monjalon wrote: > > > 06/05/2020 14:42, David Marchand: > > >> On Wed, May 6, 2020 at 2:27 PM Thomas Monjalon > wrote: > > >>> > > >>> 05/05/2020 16:53, David Marchand: > > >>>> On Tue, May 5, 2020 at 1:21 PM Ophir Munk > wrote: > > >>>>> +; These functions were moved from stable to internal. > > >>>>> +; This is a temporary exception till DPDK 20.11. > > >>>> > > >>>> This is not until 20.11 if we merge this patch now. > > >>>> It is only when comparing 20.02 to 20.05. > > >>>> After this, symbols will be marked INTERNAL and will be skipped > > >>>> by the generic rule, so we can remove this exception in 20.08-rc0. > > >>> > > >>> I think we need to keep this rule until 20.11, because we want to > > >>> ignore symbols which were in 19.11 and 20.02, and removed (as > > >>> internal) in 20.05. > > >> > > >> Those symbols were exported in 20.02. > > > > > > Right, no issue when comparing with 19.11. > > > > Right, which also makes it different to the Traffic Manager issue. > > As these symbols where never in v20 - 19.11, they won't be missed. > > We never had a commitment to maintain them. > > > > If there were in v20, the situation might be considered differently. > > > > > > > >> Before this, they were internal to mlx5 net driver. > > >> > > >> > > >>> > > >>> If we remove this rule in 20.08, and comparing with 19.11, the > > >>> tool will complain about removed symbols, isn't it? > > >> > > >> If we remove the rule in 20.08 and compare to _20.02_ then yes, we > > >> would get an issue. > > >> I was only thinking of comparing 20.08 with 20.05. > > >> > > >> We can keep this until 20.11 if you think it is safer. > > > > > > Yes I think we must make sure any comparison can be done during > > > compatibility lifetime. > > > > As David said, 20.08 _should_ be being compared to 20.05 by the CI. > > So it should be find to drop the rule then. >=20 > "should", but users "could" do something else ;-) >=20 > > However > > It might make easier though to let libabigail.ignore accumulate these > > kind of suppressions between major releases / lts (v20 -> v21), and > > the completely reset, and start over. >=20 > Yes it's simpler and safer. >=20