DPDK patches and discussions
 help / color / mirror / Atom feed
From: Asaf Penso <asafp@mellanox.com>
To: Wisam Monther <wisamm@mellanox.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Jack Min <jackmin@mellanox.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Wisam Monther <wisamm@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues	setup
Date: Sun, 5 Jul 2020 15:39:05 +0000	[thread overview]
Message-ID: <AM0PR05MB4289B6DB6C591754EFAEC3FBC0680@AM0PR05MB4289.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200630081028.21339-1-wisamm@mellanox.com>



Regards,
Asaf Penso

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wisam Jaddo
> Sent: Tuesday, June 30, 2020 11:10 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Jack Min
> <jackmin@mellanox.com>; david.marchand@redhat.com
> Cc: dev@dpdk.org; Wisam Monther <wisamm@mellanox.com>
> Subject: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues
> setup
> 
> The hairpin queue is the one that start from normal rxq,
> and will be less than nr_queues where nr_queues is the
> sum of normal and hairpin
> 
> Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation")
> Cc: wisamm@mellanox.com
> 
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>


Reviewed-by: Asaf Penso <asafp@mellanox.com>

> ---
>  app/test-flow-perf/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c
> index e155e49c37..2a04bfb8d5 100644
> --- a/app/test-flow-perf/main.c
> +++ b/app/test-flow-perf/main.c
> @@ -1013,7 +1013,7 @@ init_port(void)
> 
>  		if (hairpinq != 0) {
>  			for (hairpin_q = RXQ_NUM, std_queue = 0;
> -					std_queue < nr_queues;
> +					hairpin_q < nr_queues;
>  					hairpin_q++, std_queue++) {
>  				hairpin_conf.peers[0].port = port_id;
>  				hairpin_conf.peers[0].queue =
> @@ -1028,7 +1028,7 @@ init_port(void)
>  			}
> 
>  			for (hairpin_q = TXQ_NUM, std_queue = 0;
> -					std_queue < nr_queues;
> +					hairpin_q < nr_queues;
>  					hairpin_q++, std_queue++) {
>  				hairpin_conf.peers[0].port = port_id;
>  				hairpin_conf.peers[0].queue =
> --
> 2.17.1


  reply	other threads:[~2020-07-05 15:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30  8:10 Wisam Jaddo
2020-07-05 15:39 ` Asaf Penso [this message]
2020-07-05 20:39 ` Thomas Monjalon
2020-07-06  8:00   ` Wisam Monther
2020-07-06  7:53 ` [dpdk-dev] [PATCH v2] " Wisam Jaddo
2020-07-06  8:15   ` Thomas Monjalon
2020-07-06  8:32   ` [dpdk-dev] [PATCH v3] " Wisam Jaddo
2020-07-16 14:16     ` [dpdk-dev] [PATCH v4] " Wisam Jaddo
2020-07-19 13:11       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR05MB4289B6DB6C591754EFAEC3FBC0680@AM0PR05MB4289.eurprd05.prod.outlook.com \
    --to=asafp@mellanox.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jackmin@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=wisamm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).