From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E349A052B; Wed, 29 Jul 2020 02:42:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 556401150; Wed, 29 Jul 2020 02:42:30 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75]) by dpdk.org (Postfix) with ESMTP id C15F210A3 for ; Wed, 29 Jul 2020 02:42:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AWFQobl9fcfL8nhp1Eome2yKZGEaZCuU2KzmWFYkCnQ0lmziEtm/BgBvOxwOQq8up+nhuU9F4RKTc9YapdQr0peZIzqWbVJtPNp6aQ3umwnxeqAOu1z2Rhef04QyswNraod4iU+ENkYK2AnBe8URAoQGrLbpd6cr29AhWl45xPtxkLjP0PYunIwJwq2GI55/hhNYIxl62D4tkJ7rEU5IFlUjr8DXKVyHhz5V2W767Mkzk8PdRvUdiaHCe1Ki6g2cD+W8yVGlDgmchKCnmBbD2TMDtTPFCMWyznbA1c34RI6fI/o3X/EM8Zv/Nht2Xb/nMqu7Cje2GVSIgaSs6PWq9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jt2dR+iBgLuXDpWiTyv2kj+p9MS8B/+RXN19YjNDjA=; b=db8uy3+9mt8d8mhnWyhrn6injMD1SgJaQoQjGyHFRuDkSrux/ZThreCvLPeveb+RB+Ln+mLmdBheQBMCQd3vz+CmtSa/vNQvWznIYgGGXEyxj+kDb0A2Dd9vEKm3OEEYcA6fOoLCz2TGT+n5zOlWAAMI86hVDnQlrKgoHv6phSsfdyrbp5WYAqjjFRQFx//JpLdjiYyNQL04PJN7oqFyk8m21ZIg8tHNBuVdf4DgtVjmKqAebXqRLhWgyYX8zwigsR11f4zYa9YdjvYwf9FmVSznGkHVMI1iwK2tULgpazf68Eh010CHeLIK2tD6/+CVebRQNX/qgunayV6bDDvENg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jt2dR+iBgLuXDpWiTyv2kj+p9MS8B/+RXN19YjNDjA=; b=L5WpjQaXD2s/9UtU5pmOBDpDybdJHdqJQ8I3mv4pmzNhytsYMJTTfsdGNCpaXZaSDHaIh1N6rEOH5zufvud6utPvEIy84p9EUBOxNapjgCAc7nA5JO0hmyeqc8C0GY3osFlALblpxjZhO2AUo2hkNRzGyahCqdws7KwkMH+Os+M= Received: from AM0PR05MB4307.eurprd05.prod.outlook.com (2603:10a6:208:59::12) by AM0PR05MB6547.eurprd05.prod.outlook.com (2603:10a6:208:13d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.23; Wed, 29 Jul 2020 00:42:26 +0000 Received: from AM0PR05MB4307.eurprd05.prod.outlook.com ([fe80::a8cf:1350:30b2:b2a1]) by AM0PR05MB4307.eurprd05.prod.outlook.com ([fe80::a8cf:1350:30b2:b2a1%4]) with mapi id 15.20.3216.034; Wed, 29 Jul 2020 00:42:26 +0000 From: Yuval Avnery To: Yuval Avnery , Ori Kam CC: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [PATCH v1] regex/mlx5: fix sq free check on enqueue Thread-Index: AQHWZQg6EzYLcfp1qUi1A8jU84xGkqkduBQA Date: Wed, 29 Jul 2020 00:42:25 +0000 Message-ID: References: <1595958899-67264-1-git-send-email-yuvalav@mellanox.com> In-Reply-To: <1595958899-67264-1-git-send-email-yuvalav@mellanox.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [70.66.202.183] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: da45f95d-a4ce-4830-c361-08d83358440b x-ms-traffictypediagnostic: AM0PR05MB6547: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:204; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KSibTdcf/Ja0RiWK0ow8gvTNvW8wZCENXmuUhir8l+wyTZYNV22omngw9pop9ZJ9W4v1lM/+xvcVi/Ci/E1/FOU14kzUsMCJlNkS3d4yGj8TRkQ3GRrPu2aFjAf5Q7B6sstqbzMQMc89sILL6n9q/jzKqjP+dZmt8lCeBWI3Ubzb9NeAD5IiryFJhqC+mO9zPjtDGiSEMTPNQgow901n4onPajC7l4MjUYDCrBBY2Os2NNEZWd5ZaDV8+zzx3sDMwra6RLKHtnojhJdq3CxBlZosaFg3eI2PdCAyz5JAz5W8QE1x4EPFGqGgNod0bP0z x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR05MB4307.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(39840400004)(346002)(396003)(376002)(6636002)(55016002)(6506007)(54906003)(4326008)(110136005)(53546011)(71200400001)(2906002)(8936002)(316002)(186003)(478600001)(8676002)(7696005)(26005)(52536014)(33656002)(5660300002)(83380400001)(86362001)(66476007)(64756008)(66446008)(66556008)(76116006)(66946007)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: uxBg7HeYLYd9Q9toVHo14g/q1osyvuAIDSlMKogfd3yTBC+fyvProufj5lKhnS4BFg0ocJF4nxinkyGI2UitUq7t0U1EoUXqWmnoj4h8K+8X0r+sx7U/NbN4YAQ0fv+o9tzzqdEZAYOeQgb0Y2eCcvcOT3RhyhNYnnbBLpfCzH8qi31kLT0wCTMh2KTwx3KExJK5nk3Rn2RrxJp6a5kpLJ8K4LVkzn6tQi4j/hoEYcqDCrTpr8VP2k610FBi6UfhERTqmVGeIX7KnqPrS1su13ubl7M9q0rfMKwejTul1IolDxdyt134K5a4O4dcynnzxy5kZegogkOmVn08owwPYjwNkWzCgpT+F+m8vJCD9Q5GAym7ixfUZpCaQxuZw4sldxa37hV2hT0kkhsMW4YtQVvLwgv+IkJB9YqrrNnxTER8d2RklQpLfrS9fZha58CmKVPRIAybXwRYfD1EMghDuvr3fQWK+T2kNL7yWm3ANv60hPgCN4iVDJpt+ridtNTv Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4307.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da45f95d-a4ce-4830-c361-08d83358440b X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2020 00:42:26.3396 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oXd/XDdPEAl/eN/VjI0Ts9kdUe9TiuLL0jvQ/b1onTCyTW5OH64PK8z4gtin+Ap/juONrfvfD/V4HMpgYvu59Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6547 Subject: Re: [dpdk-dev] [PATCH v1] regex/mlx5: fix sq free check on enqueue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is a bug here, will send another version > -----Original Message----- > From: Yuval Avnery > Sent: Tuesday, July 28, 2020 10:55 AM > To: Ori Kam > Cc: Thomas Monjalon ; dev@dpdk.org; Yuval > Avnery > Subject: [PATCH v1] regex/mlx5: fix sq free check on enqueue >=20 > Free sq check had a bug, causing jobs to overwrite. >=20 > Fixes: 8740ba5fe57f ("regex/mlx5: add enqueue implementation") > Signed-off-by: Yuval Avnery > Acked-by: Ori Kam > --- > drivers/regex/mlx5/mlx5_regex_fastpath.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c > b/drivers/regex/mlx5/mlx5_regex_fastpath.c > index fc5a7fc..8dfa72c 100644 > --- a/drivers/regex/mlx5/mlx5_regex_fastpath.c > +++ b/drivers/regex/mlx5/mlx5_regex_fastpath.c > @@ -152,10 +152,7 @@ struct mlx5_regex_job { >=20 > static inline int > can_send(struct mlx5_regex_sq *sq) { > - return unlikely(sq->ci > sq->pi) ? > - MLX5_REGEX_MAX_WQE_INDEX + sq->pi - sq->ci < > - sq_size_get(sq) : > - sq->pi - sq->ci < sq_size_get(sq); > + return ((sq->ci - sq->pi) & (sq_size_get(sq) - 1)) !=3D 1; > } >=20 > static inline uint32_t > -- > 1.8.3.1