Re: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure

[Mordechay Haimovsky <motih@mellanox.com>]

Already done by Ferruh.
See attachment.

Thanks
 Moti H.

> -----Original Message-----
> From: John Daley (johndale) [mailto:johndale@cisco.com]
> Sent: Wednesday, October 10, 2018 9:56 PM
> To: Mordechay Haimovsky <motih@mellanox.com>; Adrien Mazarguil
> <adrien.mazarguil@6wind.com>; Shahaf Shuler <shahafs@mellanox.com>;
> Ori Kam <orika@mellanox.com>; ferruh.yigit@intel.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] app/testpmd: fix flow query failure
> 
> Ok, makes sense now, both flow query and flow list work with this patch,
> yeah.
> 
> Tested-by: John Daley <johndale@cisco.com>
> 
> Remember that
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> ches.dpdk.org%2Fpatch%2F46221%2F&amp;data=02%7C01%7Cmotih%40me
> llanox.com%7C554abadea7134471dc7e08d62ee21143%7Ca652971c7d2e4d9b
> a6a4d149256f461b%7C0%7C0%7C636747945816028762&amp;sdata=7eVxVq0
> AoN0hRVR%2Bb3bQvub5Q%2BXge6Cw9UqripZIWyk%3D&amp;reserved=0
> still needs to be reverted out of dpdk-next-net/master otherwise we are still
> broken. The patch was squished into e5b652ea34.
> 
> -johnd
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Mordechay Haimovsky
> > Sent: Wednesday, October 10, 2018 10:05 AM
> > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Shahaf Shuler
> > <shahafs@mellanox.com>; Ori Kam <orika@mellanox.com>
> > Cc: dev@dpdk.org; Mordechay Haimovsky <motih@mellanox.com>
> > Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
> >
> > This patch fixes a bug found in port_flow_query routine which caused
> > flow query command to fail with the following error "Caught error type
> > 1 (cause
> > unspecified): unknown object type to retrieve the name
> > of: Invalid argument".
> >
> > Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion
> > function")
> >
> > Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> > ---
> >  app/test-pmd/config.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > 009c92c..b11317b 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -1239,7 +1239,8 @@ void print_valid_ports(void)
> >  		return -ENOENT;
> >  	}
> >  	ret = rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR,
> > -			    &name, sizeof(name), action, &error);
> > +			    &name, sizeof(name),
> > +			    (void *)(uintptr_t)action->type, &error);
> >  	if (ret < 0)
> >  		return port_flow_complain(&error);
> >  	switch (action->type) {
> > --
> > 1.8.3.1