From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80083.outbound.protection.outlook.com [40.107.8.83]) by dpdk.org (Postfix) with ESMTP id 6505E1B3D2 for ; Thu, 11 Oct 2018 12:40:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hjysEOVSo0FgziesS11qJ5rxKvgnjqM08NhNZishvKo=; b=AhRedFIu/YASautgJQq5XDedXnoL3240OMaqynmI6dDiVOvwjhx6BJJ8BHY/gFl7OsYHk0rrJMU5112zTL2BdXnVlldNfZiodLnGsyTHgW5izQtrYF8A5bXJsFKhyvFH5hJCLaMKBISzbuxVlfdDeY8Df0FZt6x1qyMKWaZgSSk= Received: from AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.92.20) by AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.92.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Thu, 11 Oct 2018 10:40:39 +0000 Received: from AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::2549:a872:4864:b84e]) by AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::2549:a872:4864:b84e%6]) with mapi id 15.20.1207.029; Thu, 11 Oct 2018 10:40:39 +0000 From: Mordechay Haimovsky To: "John Daley (johndale)" , Adrien Mazarguil , Shahaf Shuler , Ori Kam , "ferruh.yigit@intel.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix flow query failure Thread-Index: AQHUYLtezpIFwK1+5EWur2IGcQ2jJKUY0EewgAEK75A= Date: Thu, 11 Oct 2018 10:40:39 +0000 Message-ID: References: <1539191078-8501-1-git-send-email-motih@mellanox.com> <6ebb000b3d0f47d6baf376fb02e2c5b2@XCH-RCD-007.cisco.com> In-Reply-To: <6ebb000b3d0f47d6baf376fb02e2c5b2@XCH-RCD-007.cisco.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; x-originating-ip: [79.181.109.45] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR05MB4435; 6:VwDLFVMADyuBymFlk9C1VzqiSBp8b572pZA6ypzBlqRd+mMQ4tmt6J1ZtG5mDKLNvbAiT4BG/GMQl/A7uuWMBorxBiO9aYZ4xXY44NvdYL4d1ar7cWRFizkNzw9V/j+4MBlKZS9k8dNyR1BX1UmBlSKmCumkzEFuFvXm0vTN/2MyjUjFJlGvPs59eIzs/c4Euzf5ivXsU+im3UMMA6al4QGrjCX7SFylEMxJhyYU5ZHj2E0+IvJEo3T8/Ittta8c1DqTJd2fljlEfWVnEQ70JnEhJNG1Vwjo3GdtcKf8272cdowOCaMaRjpB+D9z+rzF1PBmWY5lcG3u6iEhJk4QJOnYAQZJXoqtIpoPQSxhCo7l8DQZezK/LH+oS7M5xi/DDi5Hl/HqfTlIRU8X9ALx8OSf2vwbIKT4UcRMmhFfth0LS3gPFIVUo5B7+gQBNoCoXVAjtS4En1NooX7j7bLPAw==; 5:aQO7ty7M310gj2V9gJg+2XuqyJU5YiULDo2XwvTpfj77VUMTG4SNLvvYlsrYIFXQzXM6BSD5SzV/uNXUxcA/tONQVofxluf7AN4LN4NILweM8E26VfwdixSl1LkDwGnkP5mz5RSCiJVpFzW3UqC7HSiSDGvNjd+gAjlCE1TbTBs=; 7:OwqSic6gdwbraIjcUqgi/KWe4r3c0ypQ9kKv9BvcA8W9BRWpdmd/YPUB8GckeyRcCqOoSOD4KqIwTQKyJ7FjC9cKIPQ9yjEqKBl/o5i+QYeqXK/mO2G4qWemulx2BdC/gYHIweO8UdPaENyJ0vtsHSwytA6bAjR+s/SQ5VWJ7wYkFwFmF2Wc02tHnLDUOqvBE4eXwNYeHIeubs65Os08kitzMRh+dRACu0eXaqc7U+hf9gwjmS1LexowW5rhiAWT x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 40b2a607-9ad6-453c-929f-08d62f65fc64 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(49563074)(7193020); SRVR:AM0PR05MB4435; x-ms-traffictypediagnostic: AM0PR05MB4435: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(95692535739014)(228905959029699)(45079756050767)(189930954265078); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(102415395)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231355)(944501410)(4983020)(52105095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201708071742011)(7699051); SRVR:AM0PR05MB4435; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB4435; x-forefront-prvs: 08220FA8D6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(39860400002)(376002)(136003)(396003)(13464003)(189003)(199004)(97736004)(4326008)(8936002)(81166006)(81156014)(6436002)(2501003)(5250100002)(229853002)(2900100001)(305945005)(7736002)(74316002)(33656002)(86362001)(575784001)(71200400001)(71190400001)(68736007)(66066001)(316002)(25786009)(6246003)(8676002)(6506007)(2906002)(5660300001)(486006)(6116002)(3846002)(110136005)(966005)(478600001)(45080400002)(14454004)(446003)(11346002)(26005)(186003)(7696005)(99286004)(5024004)(6306002)(55016002)(9686003)(53936002)(99936001)(256004)(476003)(102836004)(76176011)(53546011)(105586002)(106356001)(14444005)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4435; H:AM0PR05MB4435.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: WMCBwvMAxwDn0+Oa+5JXD+ot4XtVX9vMI3yZngD3oz8l6jNV/G9HMNzEyg2kGa8nHvzKDZtj5ewvW/F7LEjSMjdHtIEU0HduRV6zeogOCmZRrQJT1GNnOQipGhzQhwKZrKs+qR5vZvIWHvrIWJ+vSwi6CGxmBheUdb6OBx+iaqwBTt+LGh+V3RxvVjd2QoOpWotsHGfwVWaMeNcutk/NYujxXrUqVBeMoOUS2FO5QP/CVmWfLchyIBdDGTswbwUO5r7wIA55YZns2lQVZI+E01mdZchceUqFOC5wv2hWbYZbD309gXThW/UNUBrUPXwmvm+glvMHEgXDz+AEeGKjM8wNQmnkbh1qTsBuhsDa0CM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40b2a607-9ad6-453c-929f-08d62f65fc64 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2018 10:40:39.1125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4435 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 10:40:40 -0000 Already done by Ferruh. See attachment. Thanks Moti H. > -----Original Message----- > From: John Daley (johndale) [mailto:johndale@cisco.com] > Sent: Wednesday, October 10, 2018 9:56 PM > To: Mordechay Haimovsky ; Adrien Mazarguil > ; Shahaf Shuler ; > Ori Kam ; ferruh.yigit@intel.com > Cc: dev@dpdk.org > Subject: RE: [PATCH] app/testpmd: fix flow query failure >=20 > Ok, makes sense now, both flow query and flow list work with this patch, > yeah. >=20 > Tested-by: John Daley >=20 > Remember that > https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpat > ches.dpdk.org%2Fpatch%2F46221%2F&data=3D02%7C01%7Cmotih%40me > llanox.com%7C554abadea7134471dc7e08d62ee21143%7Ca652971c7d2e4d9b > a6a4d149256f461b%7C0%7C0%7C636747945816028762&sdata=3D7eVxVq0 > AoN0hRVR%2Bb3bQvub5Q%2BXge6Cw9UqripZIWyk%3D&reserved=3D0 > still needs to be reverted out of dpdk-next-net/master otherwise we are s= till > broken. The patch was squished into e5b652ea34. >=20 > -johnd >=20 > > -----Original Message----- > > From: dev On Behalf Of Mordechay Haimovsky > > Sent: Wednesday, October 10, 2018 10:05 AM > > To: Adrien Mazarguil ; Shahaf Shuler > > ; Ori Kam > > Cc: dev@dpdk.org; Mordechay Haimovsky > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure > > > > This patch fixes a bug found in port_flow_query routine which caused > > flow query command to fail with the following error "Caught error type > > 1 (cause > > unspecified): unknown object type to retrieve the name > > of: Invalid argument". > > > > Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion > > function") > > > > Signed-off-by: Moti Haimovsky > > --- > > app/test-pmd/config.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > 009c92c..b11317b 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -1239,7 +1239,8 @@ void print_valid_ports(void) > > return -ENOENT; > > } > > ret =3D rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR, > > - &name, sizeof(name), action, &error); > > + &name, sizeof(name), > > + (void *)(uintptr_t)action->type, &error); > > if (ret < 0) > > return port_flow_complain(&error); > > switch (action->type) { > > -- > > 1.8.3.1